[1.16.5] Issues with setAttackTarget() and setAngerTime()

[ShipHeatRook]

Hello, I've been working on a mod of mine, recently, and I've found it difficult to implement a certain feature of an item.

What I want to do is: when the player is holding a certain item in the off-hand, even if they hit wolves, they don't attack back.
At first, this looked easy with the methods setAttackTarget() and setAngerTime(), but I've found that wolves actually keep attacking the player, just with the normal texture instead of the angry, red-eyed one. Could someone help me with the code? I'll past here the function.

Be aware that this has nothing to do with recognising the item in the off-hand, as I have made many other similar functions doing different things, and they've all worked: my only issue seems to be with manipulating the wolves' behaviour.

 

 else if (stack.getItem() == ModItems.COOLSWORD.get().getItem()){
                  
                  List<WolfEntity> wolves = worldIn.getEntitiesWithinAABB(WolfEntity.class, new AxisAlignedBB(player.getPosX() - 20.0D, player.getPosY() - 20.0D, player.getPosZ() - 20.0D, player.getPosX() + 20.0D, player.getPosY() + 20.0D, player.getPosZ() + 20.0D));
                    if (wolves.isEmpty())
                    {
                        return;
                    }
                    for (WolfEntity wolf : wolves)
                    {
                        if(wolf.isAggressive() && wolf.getAttackTarget() == player)
                        {
                                wolf.setRevengeTarget((LivingEntity)null);
                                wolf.setAngerTarget((UUID)null);
                                wolf.setAttackTarget((LivingEntity)null);
                                wolf.setAngerTime(0);
                        }
                        return;
                    }

                }

 

Edited April 4, 2022 by ShipHeatRook
Edit: added MC version in the title

[ShipHeatRook]

1 hour ago, diesieben07 said:

You should be able to use LivingSetAttackTargetEvent for this.

I did that now and, while the event itself runs fine, the game crashes as soon as I hit a wolf, with a NullPointerException. These two are respectively:

The function that I implemented
 

    public static void woof(PlayerEntity player, World worldIn) {

        ItemStack stack = player.getHeldItemOffhand();

        if(stack.getItem() == ModItems.COOLSWORD.get().getItem()) {
            List<WolfEntity> wolves = worldIn.getEntitiesWithinAABB(WolfEntity.class, new AxisAlignedBB(player.getPosX() - 20.0D, player.getPosY() - 20.0D, player.getPosZ() - 20.0D, player.getPosX() + 20.0D, player.getPosY() + 20.0D, player.getPosZ() + 20.0D));
            if (wolves.isEmpty()) {
                return;
            }
            for (WolfEntity wolf : wolves) {
                if (wolf.isAggressive() && wolf.getAttackTarget() == player)    
                {

                    wolf.setRevengeTarget((LivingEntity) null);
                    wolf.setAngerTarget((UUID) null);
                    wolf.setAttackTarget((LivingEntity) null);
                    wolf.setAngerTime(0);
                }
            }
        }
    }

And this is the LivingSetAttackTargetEvent:

 

    @SubscribeEvent
    public static void LivingSetAttackTargetEvent (LivingSetAttackTargetEvent event)
    {
        Entity player = event.getTarget();
        World worldIn = event.getEntity().world;

        Actions.woof((PlayerEntity) player, worldIn);
    }

The NullPointerException is fired when the wolf ticks, apparently because it points to a vehicle (???)
 

-- Entity being ticked --
Details:
	Entity Type: minecraft:wolf (net.minecraft.entity.passive.WolfEntity)
	Entity ID: 463
	Entity Name: Wolf
	Entity's Exact location: -193.30, 72.00, -63.07
	Entity's Block location: World: (-194,72,-64), Chunk: (at 14,4,0 in -13,-4; contains blocks -208,0,-64 to -193,255,-49), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,0,-512 to -1,255,-1)
	Entity's Momentum: 0.03, -0.08, 0.03
	Entity's Passengers: []
	Entity's Vehicle: ~~ERROR~~ NullPointerException: null
Stacktrace:
	at net.minecraft.world.World.guardEntityTick(World.java:601) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.server.ServerWorld.tick(ServerWorld.java:407) ~[forge:?] {re:classloading}

What am I doing wrong? Thanks in advance for your help.

[ShipHeatRook]

3 minutes ago, diesieben07 said:

Ah, yeah you can't set the target to null immediately, because the task that sets it expects setTarget to succeed obviously.

You might be better off replacing the wolf's HurtByTargetGoal with a custom implementation that overrides canUse so it returns false for the player holding your item. Just be sure to delegate all other public methods to the original implementation.

Thank you very much for your tip. My original item is an instance of a set of swords, so I don't really know about overriding a method, might as well think of another useful feature to implement ahah.

But while we're at it, I've noticed that 1.16.5 Forge lets you use something like:

wolf.getBrain().setMemory(MemoryModuleType.PACIFIED, true);

But it doesn't seem to do much to me. Am I missing something or is this yet another dead end about easily manipulating a mob's AI?

[Luis_ST]

8 minutes ago, ShipHeatRook said:

But it doesn't seem to do much to me. Am I missing something or is this yet another dead end about easily manipulating a mob's AI?

the Wolf does not have a Brain, it use Goals

 

8 minutes ago, ShipHeatRook said:

My original item is an instance of a set of swords, so I don't really know about overriding a method, might as well think of another useful feature to implement ahah.

then you need to learn basic java before modding minecraft

[ShipHeatRook]

Just now, Luis_ST said:

the Wolf does not have a Brain, it use Goals

 

then you need to learn basic java before modding minecraft

Man, chill. It was my own choice to make them instances and it's just a hassle to me to redo them, but this doesn't mean I won't. I haven't been coding mods since 1.12.2, so this is still pretty new to me and I came to ask lmao.