Search the Forums BEFORE making a new post.

Game crashes when using item

Posted May 19, 20223 yr

Hi, I want to make an item that will heal entities in an area around the player(it doesn't matter if the player will also heal himself) but when I right-click the game will crash. Here's my code:

package com.kuikenpower.falidsmp.init.item;

import java.util.List;

import net.minecraft.core.particles.ParticleTypes;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.effect.MobEffectInstance;
import net.minecraft.world.effect.MobEffects;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.memory.NearestVisibleLivingEntities;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.SwordItem;
import net.minecraft.world.item.Tier;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.AABB;

public class flowerStaff extends SwordItem{

	public flowerStaff(Tier p_43269_, int p_43270_, float p_43271_, Properties p_43272_) {
		super(p_43269_, p_43270_, p_43271_, p_43272_);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public void inventoryTick(ItemStack itemStack, Level world, Entity entity, int p_41407_, boolean p_41408_) {
		Player player = (Player) entity;
		if(player.isCrouching() && player.getMainHandItem().getItem() instanceof flowerStaff) {
            Double x = player.getX();
            Double y = player.getY();
            Double z = player.getZ();
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 2.5, 5, 5, 5);
		}
		super.inventoryTick(itemStack, world, entity, p_41407_, p_41408_);
	}
	
	@Override
	public InteractionResultHolder<ItemStack> use(Level world, Player player, InteractionHand p_41434_) {
		if(world.isClientSide) {
			AABB healArea = new AABB(player.getX() + 5, player.getY() + 2, player.getZ() + 5, player.getX() - 5, player.getY() - 2, player.getZ() - 5);
			if(player.isCrouching()) {
				List<LivingEntity> entityInArea = world.getNearbyEntities(null, null, player, healArea);
				LivingEntity targets = entityInArea.get(EAT_DURATION);
				targets.addEffect(new MobEffectInstance(MobEffects.HEAL, 20));
			}
		}
		return super.use(world, player, p_41434_);
	}
	
}

Quote

May 19, 20223 yr

Author

16 minutes ago, diesieben07 said:

null and null are not valid parameters here.

Hi, Thanks for reacting faster than the flash, but what should I use instead of null and null?

Quote

May 20, 20223 yr

Author

19 hours ago, diesieben07 said:

What if it's not a player?

null and null are not valid parameters here.

Uh, what? Why are you getting the entity at index EAT_DURATION? This makes zero sense. EAT_DURATION is 32, so what if there are only 15 entities nearby? Or none at all? Even if there are 33 or more entities nearby, this achieves nothing useful.

I did everything you said, but it still crashes

package com.kuikenpower.falidsmp.init.item;

import java.util.List;

import net.minecraft.core.particles.ParticleTypes;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.effect.MobEffectInstance;
import net.minecraft.world.effect.MobEffects;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.targeting.TargetingConditions;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.SwordItem;
import net.minecraft.world.item.Tier;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.AABB;

public class flowerStaff extends SwordItem{

	public flowerStaff(Tier p_43269_, int p_43270_, float p_43271_, Properties p_43272_) {
		super(p_43269_, p_43270_, p_43271_, p_43272_);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public void inventoryTick(ItemStack itemStack, Level world, Entity entity, int p_41407_, boolean p_41408_) {
		LivingEntity player = (LivingEntity) entity;
		if(player.isCrouching() && player.getMainHandItem().getItem() instanceof flowerStaff) {
            Double x = player.getX();
            Double y = player.getY();
            Double z = player.getZ();
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 2.5, 5, 5, 5);
		}
		super.inventoryTick(itemStack, world, entity, p_41407_, p_41408_);
	}
	
	@Override
	public InteractionResultHolder<ItemStack> use(Level world, Player player, InteractionHand p_41434_) {
		if(world.isClientSide) {
			AABB healArea = new AABB(player.getX() + 5, player.getY() + 2, player.getZ() + 5, player.getX() - 5, player.getY() - 2, player.getZ() - 5);
			if(player.isCrouching()) {
				List<LivingEntity> entityInArea = world.getNearbyEntities(LivingEntity.class, TargetingConditions.forNonCombat(), player, healArea);
				LivingEntity targets = entityInArea.get(5);
				targets.addEffect(new MobEffectInstance(MobEffects.HEAL, 20));
			}
		}
		return super.use(world, player, p_41434_);
	}
	
}

Quote

May 20, 20223 yr

invert isClientSide check. you are supposed to heal server entities.

get(5) on a list object returns sixth entity, you intended that for testing, right? and you ensured that there will be five or more entities around you when testing, because otherwise it would crash.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/111397-game-crashes-when-using-item/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How Can I Safely Play an Old Version of Minecraft?

Yeah, you can safely play Beta 1.7.3 using the official Minecraft Launcher. Just create a new installation, pick the old version from the list, and set a separate game directory so it won’t interfere with your current saves. The main compatibility issue is that old saves may break if opened in newer versions, so always back them up.

By WinX · 1 hour ago1 hr
Mod for world Templates

No, there isn’t a dedicated Forge mod for world templates in 1.20.1. Your options are to use datapacks for custom worlds or run the Fabric mod through Connector.

By WinX · 1 hour ago1 hr
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I do have to add that this is my answer for 1.12.2 but it should ALSO work for future versions.

By Tiny_Sly · 7 hours ago7 hr
How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

I know this was posted almost 3 years ago but this is for anyone who is still looking for an answer.

First, find your config folder. -> C:\Users\ (desktop user's name) \curseforge(or the application where you've downloaded you mod)\minecraft\Instances\config (The config folder should be in the same folder as your mods folder.) Once you click on the config folder, search for CustomNpcs.cfg. Once found, click on it (you can edit it using notepad) and search for the line "headweartype". Set the value to 0 if you want a 2d head layer, set it to 1 for a 3d head layer. Then save the options and you should be good to go from there! :)

By Tiny_Sly · 7 hours ago7 hr
[1.16.1]Render enchanted glint to item

ik this was 5 years ago but is this the same in 1.20? or is there a different method?

By FireDude123 · Sunday at 08:55 PM1 day

There are no registered users currently online

Sign In

Game crashes when using item

Featured Replies

Join the conversation

Posts

How Can I Safely Play an Old Version of Minecraft?

Mod for world Templates

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

How do I remove 3d headlayer on NPC's skin in CustomNpc? (1.16.5)

[1.16.1]Render enchanted glint to item

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)