I'm trying to get an enchantment from a json file but it doesn't work (I'm making a mod)

[PadFoot2008]

I am trying to make a tile entity with 2 slots - top one will get a tool and bottom one will get a crystal. The tool will be enchanted based on the crystal and get placed in the top slot and the crystal will be deleted. The recipe is provided in I'm using Kaupenjoe's tutorial for this: 

Here's the original code by Kaupenjoe:

@Override
        public LightningChannelerRecipe read(ResourceLocation recipeId, JsonObject json) {
            ItemStack output = ShapedRecipe.deserializeItem(JSONUtils.getJsonObject(json, "output"));
            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new LightningChannelerRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather));
        }

Here the Json file (original):

{
  "type": "immersivesurvival:enchanting",
  "weather": "clear",
  "ingredients" : [
    {
      "item": "minecraft:diamond_sword"
    },
    {
      "item": "immersivesurvival:fire_shard"
    }
  ],
    "output": {
    "item": "minecraft:diamond_shovel"
}}

This code works properly and output a diamond shovel, but of course that's not what I want to do.

I edited the code such that it gets the item from the first slot and the enchantment given in the Json and then enchants it with the enchantment and then returns it.

@Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "output");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));
            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            String rawtool = ingredients.get(0).getAsString();
            Item outputraw = ForgeRegistries.ITEMS.getValue(new ResourceLocation(rawtool));
            ItemStack output = new ItemStack(outputraw);
            output.addEnchantment(enchant,1);

            String weather = JSONUtils.getString(json, "weather");

            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather));
        }

And the recipe json:

{
  "type": "immersivesurvival:enchanting",
  "weather": "clear",
  "ingredients" : [
    {
      "item": "minecraft:diamond_sword"
    },
    {
      "item": "immersivesurvival:fire_shard"
    }
  ],
    "output": {
    "item": "Enchantments.FIRE_ASPECT"
}}

But it isn't working. Any help will be appreciated.

[Luis_ST]

14 minutes ago, PadFoot2008 said:

Enchantments.FIRE_ASPECT

this is not a valid enchantment name, you need to use the Registry name, like you use it for the item

[PadFoot2008]

What's the valid registry name for Enchantments.FIRE_ASPECT?

[Luis_ST]

fire_aspect

[PadFoot2008]

You mean

minecraft:fire_aspect

[Luis_ST]

yes

[PadFoot2008]

Thanks for all the help. Will try it tomorrow morning +0530GMT

[PadFoot2008]

It worked! I also edited the code a bit, and created a new field called enchantment in the recipe json. Thanks for all the help.

@Override
        public EnchantingPedestralRecipe read(ResourceLocation recipeId, JsonObject json) {
            String enchantraw = JSONUtils.getString(json, "enchantment");
            Enchantment enchant = ForgeRegistries.ENCHANTMENTS.getValue(new ResourceLocation(enchantraw));

            ItemStack output = ShapedRecipe.deserializeItem(JSONUtils.getJsonObject(json, "output"));
            output.addEnchantment(enchant,1);

            String weather = JSONUtils.getString(json, "weather");

            JsonArray ingredients = JSONUtils.getJsonArray(json, "ingredients");
            NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY);

            for (int i = 0; i < inputs.size(); i++) {
                inputs.set(i, Ingredient.deserialize(ingredients.get(i)));
            }

            return new EnchantingPedestralRecipe(recipeId, output,
                    inputs, Weather.getWeatherByString(weather));
        }

 

 

Edited May 30, 2022 by PadFoot2008
Mistakenly posted

[PadFoot2008]

And the recipe json:

{
  "type": "immersivesurvival:enchanting",
  "weather": "clear",
  "enchantment": "minecraft:fire_aspect",
  "ingredients" : [
    {
      "item": "minecraft:diamond_sword"
    },
    {
      "item": "immersivesurvival:fire_shard"
    }
  ],
    "output": {
    "item": "minecraft:diamond_sword"
  }
}

Thanks again a lot!