I am having a problem with items in Forge 9.10.0.804. When I create my new item using two old items, I recieve the new one fine, however as soon as I click it my inventory resets to it's previous state. The video explains it better:

[flash=640,360]https://youtube.googleapis.com/v/NXLulVE8x8k

Here is my code for swapping the items:

public void castSpellBlockFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	if(world.getBlockId(x,y,z)==Items.block_spelltable.blockID&&side==1){
		if(player.inventory.getStackInSlot(0)!=null){
			if(player.inventory.getStackInSlot(0).itemID!=Items.item_apprenticewand.itemID){
				/* Here's the items that can turn into spells */
				switch(player.inventory.getStackInSlot(0).itemID){
				case 370:
					player.inventory.consumeInventoryItem(Items.item_apprenticewand.itemID);
					player.inventory.consumeInventoryItem(Item.ghastTear.itemID);
					player.inventory.addItemStackToInventory(new ItemStack(Items.item_apprenticewand_soul, 1, 0));
					break;
				default:
					player.addChatMessage("§cNo available items found in first slot");
					break;
				}
			}else{
				player.addChatMessage("§cWands cannot be transmuted");
			}
		}else{
			player.addChatMessage("§cNo available items found in first slot");
		}
	}
}

 

Any help would be appreciated. If you need any information, just post or PM.

you're not doing the change server side

 

if(!world.isRemote){

//activate effect

}

you're not doing the change server side

 

if(!world.isRemote){

//activate effect

}

 

I thought that was the problem, but ignored it because in another spell I used it and thought I used it in my base function. Thanks!

 

EDIT: Now nothing happens when I right click, and I have a similar problem with my Soul Spell.

 

	public void castSpellBlockFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	if(!world.isRemote&&world.getBlockId(x,y,z)==Items.block_spelltable.blockID&&side==1){
		if(player.inventory.getStackInSlot(0)!=null){
			if(player.inventory.getStackInSlot(0).itemID!=Items.item_apprenticewand.itemID){
				/* Here's the items that can turn into spells */
				switch(player.inventory.getStackInSlot(0).itemID){
				case 370:
					player.inventory.consumeInventoryItem(Items.item_apprenticewand.itemID);
					player.inventory.consumeInventoryItem(Item.ghastTear.itemID);
					player.inventory.addItemStackToInventory(new ItemStack(Items.item_apprenticewand_soul, 1, 0));
					break;
				default:
					player.addChatMessage("§cNo available items found in first slot");
					break;
				}
			}else{
				player.addChatMessage("§cWands cannot be transmuted");
			}
		}else{
			player.addChatMessage("§cNo available items found in first slot");
		}
	}
}

can we see who/what is calling castSpellBlockFirst

Here's four classes: ItemWand, Spell, NullSpell (the one I'm referencing in my first post) and SoulSpell:

ItemWand.java:

 

package lemmy.eldercraft;

import java.util.List;

import org.lwjgl.opengl.GL11;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.FontRenderer;
import net.minecraft.client.gui.ScaledResolution;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.passive.EntityCow;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.player.EntityInteractEvent;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class ItemWand extends Item {
public int type;
public Spell spell=new Spell();
public int cooldown=0;
private final Minecraft mc;

public ItemWand(int id,int type,Spell spell) {
	super(id);
	this.type=type;
	this.spell=spell;
	this.setCreativeTab(CreativeTabs.tabBrewing);
	this.setUnlocalizedName("wand_"+type);
	this.setMaxDamage((type==1?150:(type==2?400:800)));
	this.setMaxStackSize(1);
	this.setNoRepair();
	this.setFull3D();
	this.setHasSubtypes(true);
	mc = Minecraft.getMinecraft();
}

@Override
public boolean isDamageable() {
	return true;
}

@Override
@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister icon) {
	itemIcon=icon.registerIcon("eldercraft:wand_"+type);
}

@Override
public boolean getIsRepairable(ItemStack par1ItemStack,ItemStack par2ItemStack) {
	return false;
}

@SideOnly(Side.CLIENT)
public void addInformation(ItemStack par1ItemStack,EntityPlayer par2EntityPlayer,List par3List,boolean par4) {
	super.addInformation(par1ItemStack,par2EntityPlayer,par3List,par4);
	switch(type){
	case 1:
		par3List.add("§bApprentice");
		String colorCode="2";
		int percentCharged=(int)((par1ItemStack.getMaxDamage()-par1ItemStack.getItemDamage())*100/par1ItemStack.getMaxDamage());
		if(percentCharged>85){
			colorCode="2";
		}else if(percentCharged>57){
			colorCode="a";
		}else if(percentCharged>43){
			colorCode="e";
		}else if(percentCharged>20){
			colorCode="c";
		}else{
			colorCode="4";
		}
		par3List.add("§"+colorCode+percentCharged+"% charged ("+par1ItemStack.getItemDamage()+"/"+par1ItemStack.getMaxDamage()+")");
		par3List.add("§bSpell: "+spell.name);
		for(String s:spell.descriptionlines){
			par3List.add(s);
		}
		break;
	}
}

public boolean onItemUse(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	if(cooldown!=0) return false;
	cooldown=10;
	return spell.castSpellBlockEvent(stack,player,world,x,y,z,side,hitX,hitY,hitZ);
}

public boolean onItemUseFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	if(cooldown!=0) return false;
	cooldown=10;
	return spell.castSpellBlockFirstEvent(stack,player,world,x,y,z,side,hitX,hitY,hitZ);
}

public ItemStack onItemRightClick(ItemStack stack,World world,EntityPlayer player) {
	if(cooldown!=0) return stack;
	cooldown=10;
	return spell.castSpellAirEvent(stack,world,player);
}

public boolean func_111207_a(ItemStack stack,EntityPlayer player,EntityLivingBase entity) {
	if(cooldown!=0) return false;
	cooldown=10;
	return spell.castSpellEntityEvent(stack, player, entity);
}

public void onUpdate(ItemStack par1ItemStack,World par2World,Entity par3Entity,int par4,boolean par5) {
	super.onUpdate(par1ItemStack,par2World,par3Entity,par4,par5);
	if(cooldown>0)
		cooldown--;
	if(cooldown<0)
		cooldown=0;	
}

@SideOnly(Side.CLIENT)
public void renderHelmetOverlay(ItemStack stack,EntityPlayer player,ScaledResolution resolution,float partialTicks,boolean hasScreen,int mouseX,int mouseY) {
	super.renderHelmetOverlay(stack,player,resolution,partialTicks,hasScreen,mouseX,mouseY);
	GL11.glPushMatrix();
	GL11.glDisable(GL11.GL_LIGHTING);
	ScaledResolution res = new ScaledResolution(this.mc.gameSettings,
	this.mc.displayWidth, this.mc.displayHeight);
	FontRenderer fontRender = mc.fontRenderer;
	int width = res.getScaledWidth();
	int height = res.getScaledHeight();
	mc.entityRenderer.setupOverlayRendering();
	fontRender.drawStringWithShadow("Spell:",2,height-32,0xFFFFFF);
	fontRender.drawStringWithShadow(spell.name,2,height-23,0x000000);
	GL11.glPopMatrix();
}
}

 

 

Spell.java:

 

package lemmy.eldercraft;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.EntityInteractEvent;

public class Spell {
public int level=1;
public int castChargeRequired=10;
public int wandRequired=1;
public int id=-1;
public boolean castAir,castBlock,castBlockFirst,castEntity=false;
public boolean renderGUI=true;
public String name="§4Unknown";
public String descriptionlines[]={"§cThis wand is spawned incorrectly.", "§cIf this was crafted, please report"};

public ItemStack castSpellAirEvent(ItemStack stack,World world,EntityPlayer player) {
	if(!castAir) return stack;
	if(stack.getMaxDamage()-stack.getItemDamage()>=castChargeRequired){
		stack.damageItem(castChargeRequired,player);
		castSpellAir(stack,world,player);
	}
	return stack;
}

public void castSpellAir(ItemStack stack,World world,EntityPlayer player) {
	// your code here
}

public boolean castSpellBlockEvent(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ){
	if(!castBlock) return false;
	if(stack.getMaxDamage()-stack.getItemDamage()>=castChargeRequired){
		stack.damageItem(castChargeRequired,player);
		castSpellBlock(stack,player,world,x,y,z,side,hitX,hitY,hitZ);
	}
	return true;
}

public void castSpellBlock(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ){
	// your code here
}

public boolean castSpellBlockFirstEvent(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ){
	if(!castBlockFirst) return false;
	if(stack.getMaxDamage()-stack.getItemDamage()>=castChargeRequired){
		stack.damageItem(castChargeRequired,player);
		castSpellBlockFirst(stack,player,world,x,y,z,side,hitX,hitY,hitZ);
	}
	return true;
}

public void castSpellBlockFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ){
	// your code here
}

public boolean castSpellEntityEvent(ItemStack stack, EntityPlayer player, EntityLivingBase entity){
	if(!castEntity) return false;
	if(stack.getMaxDamage()-stack.getItemDamage()>=castChargeRequired){
		stack.damageItem(castChargeRequired,player);
		castSpellEntity(stack,player,entity);
	}
	return true;
}

public void castSpellEntity(ItemStack stack, EntityPlayer player, EntityLivingBase entity){
	// your code here
}
}

 

 

NullSpell.ava:

 

package lemmy.eldercraft;

import java.util.Random;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.monster.EntityPigZombie;
import net.minecraft.entity.passive.EntityPig;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class NullSpell extends Spell {
public NullSpell() {
	castChargeRequired=0;
	level=-1;
	wandRequired=-1;
	id=0;
	name="§eNo Spell";
	descriptionlines=new String[]{};
	castBlockFirst=true;
}

public void castSpellBlockFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	if(!world.isRemote&&world.getBlockId(x,y,z)==Items.block_spelltable.blockID&&side==1){
		if(player.inventory.getStackInSlot(0)!=null){
			if(player.inventory.getStackInSlot(0).itemID!=Items.item_apprenticewand.itemID){
				/* Here's the items that can turn into spells */
				switch(player.inventory.getStackInSlot(0).itemID){
				case 370:
					player.inventory.consumeInventoryItem(Items.item_apprenticewand.itemID);
					player.inventory.consumeInventoryItem(Item.ghastTear.itemID);
					player.inventory.addItemStackToInventory(new ItemStack(Items.item_apprenticewand_soul, 1, 0));
					break;
				default:
					player.addChatMessage("§cNo available items found in first slot");
					break;
				}
			}else{
				player.addChatMessage("§cWands cannot be transmuted");
			}
		}else{
			player.addChatMessage("§cNo available items found in first slot");
		}
	}
}

}

 

 

SoulSpell.java

 

 

package lemmy.eldercraft;

import java.util.Random;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.monster.EntityPigZombie;
import net.minecraft.entity.passive.EntityPig;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class SoulSpell extends Spell {
Random rand = new Random();
public SoulSpell() {
	castChargeRequired=50;
	level=1;
	wandRequired=1;
	id=1;
	castEntity=true;
	name="§eSoul Swap";
	descriptionlines=new String[]{"§dBasic"};
}

public void castSpellEntity(ItemStack stack,EntityPlayer player,EntityLivingBase entity) {
	if(!player.worldObj.isRemote){
		if(entity instanceof EntityPigZombie){
			EntityPig entity1=new EntityPig(player.worldObj);
			entity1.setPosition(entity.posX,entity.posY,entity.posZ);
			entity1.rotationPitch=entity.rotationPitch;
			entity1.rotationYaw=entity.rotationYaw;
			entity.setDead();
			player.worldObj.spawnEntityInWorld(entity1);
			for(int i=0;i<60;i++){
				player.worldObj.spawnParticle("enchantmenttable",entity.posX+rand.nextDouble()-0.5,entity.posY+(i*0.05)+3,entity.posZ+rand.nextDouble()-0.5,0,-5,0);
			}
		}else if(entity instanceof EntityPig){
			EntityPigZombie entity1=new EntityPigZombie(player.worldObj);
			entity1.setPosition(entity.posX,entity.posY,entity.posZ);
			entity1.rotationPitch=entity.rotationPitch;
			entity1.rotationYaw=entity.rotationYaw;
			entity1.setCurrentItemOrArmor(0,new ItemStack(Item.swordGold));
			entity.setDead();
			player.worldObj.spawnEntityInWorld(entity1);
			for(int i=0;i<60;i++){
				player.worldObj.spawnParticle("enchantmenttable",entity.posX+rand.nextDouble()-0.5,entity.posY+(i*0.05)+3,entity.posZ+rand.nextDouble()-0.5,0,-5,0);
			}
		}
	}
}
}

 

 

Summary: There are events in ItemWand. In spell, there are functions such as castSpellBlockFirstEvent. These do a few checks, then call castSpellBlockFirst. The event functions are called in ItemWand, and the non-event functions are overriden in the new spell.

 

1 just letting you know

onItemFirstUse is called every time a player start usign an item

 

2 in your ItemWand class you have a int cooldown

minecraft is not making a new item for each wand available in the world, so by putting this variable there everybody in the world will have the SAME cooldown

 

Now nothing happens when I right click

can you make a bunch of println and try to see which condition is failing ?

	public void castSpellBlockFirst(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ) {
	System.out.println("1");
	if(!world.isRemote&&world.getBlockId(x,y,z)==Items.block_spelltable.blockID&&side==1){
		System.out.println("2");
		if(player.inventory.getStackInSlot(0)!=null){
			System.out.println("3");
			if(player.inventory.getStackInSlot(0).itemID!=Items.item_apprenticewand.itemID){
				/* Here's the items that can turn into spells */
				System.out.println("4");
				switch(player.inventory.getStackInSlot(0).itemID){
				case 370:
					System.out.println("5");
					player.inventory.consumeInventoryItem(Items.item_apprenticewand.itemID);
					player.inventory.consumeInventoryItem(Item.ghastTear.itemID);
					player.inventory.addItemStackToInventory(new ItemStack(Items.item_apprenticewand_soul, 1, 0));
					break;
				default:
					System.out.println("6");
					player.addChatMessage("§cNo available items found in first slot");
					break;
				}
				System.out.println("7");
			}else{
				System.out.println("8");
				player.addChatMessage("§cWands cannot be transmuted");
			}
		}else{
			System.out.println("9");
			player.addChatMessage("§cNo available items found in first slot");
		}
		System.out.println("10");
	}
	System.out.println("11");
}

 

2013-08-09 15:10:12 [iNFO] [sTDOUT] 1
2013-08-09 15:10:12 [iNFO] [sTDOUT] 11

Spell:

public boolean castSpellBlockFirstEvent(ItemStack stack,EntityPlayer player,World world,int x,int y,int z,int side,float hitX,float hitY,float hitZ){
if(FMLCommonHandler.instance().getEffectiveSide.isServer()){
System.out.println("server side thinks: "+castBlockFirst);
}else{
System.out.println("client side thinks: "+castBlockFirst);
}
	if(!castBlockFirst) return false;
	if(stack.getMaxDamage()-stack.getItemDamage()>=castChargeRequired){
		stack.damageItem(castChargeRequired,player);
		castSpellBlockFirst(stack,player,world,x,y,z,side,hitX,hitY,hitZ);
	}
	return true;
}

 

 

whats the output of thsi ?

Description Resource Path Location Type

getEffectiveSide cannot be resolved or is not a field Spell.java /Minecraft/src/lemmy/eldercraft line 49 Java Problem

 

Edit: Added parenthasis to the end of getEffectiveSide, testing now.

 

2013-08-09 15:19:19 [iNFO] [sTDOUT] client side thinks: true

FMLCommonHandler.instance().getEffectiveSide().isServer()

FMLCommonHandler.instance().getEffectiveSide().isServer()

Re-read, please.

server side thinks what ? nothing ? hmmm

 

 

try the same print in onItemFirstUse

 

if nothing appears there, that mean onItemFirstUse is never called server side :\

After adding castAir=true; to the constructor of NullItem, and adding your code to castAirEvent, then finally right clicking towards the sky, I just got 2013-08-09 15:25:29 [iNFO] [sTDOUT] client side thinks: true. No mention of serverside.

if nothing appears there, that mean onItemFirstUse is never called server side :\

 

youll have to use something else then

*reasearch a bit more in the issue*

*suspicious look*

*wtfbbq*

soooo onItemUseFirst is actually called by a method in ItemInWorldManager which is a class that is mainly used server side ... *suspicious look x2*

 

honestly you should start by changing the cooldown and spell reference to the nbt because its going to cause a butlaod of problem anyway later. and it will probably fix the current one too

It's not too much of a problem, I can simply use onBlockActivated on the Spell Table block. Unfortunately, I cannot use these functions for other spells

 

which is why you should start by changing spell and cooldown to the nbt, everything will work wonderfully after that

which is why you should start by changing spell and cooldown to the nbt, everything will work wonderfully after that

 

Spell should be an int, right? I only really need the object instance for the variables, nothing is stored in it really.

Edit: How would I go about storing NBT in an item?

 

well spell cannot be an int becasue you cant add method to int

but you COUDL store the spellID and whenever someone cast a wand it would check in the SpellLibrary (that you have to create btw) for which spell he is actually casting

 

pseudo code:

public class SpellLibrary{
    public static Spell[] allSpells;

    public static void populateLibrary(){
        allSpells = new Spell[10];
        allSpells[0] = new SpellWtv();
        allSpells[1] = new SpellEtc();
        allSpells[2] = new SpellMore();

    }
}

onItemUse(){
int spellid = getSpellId();
Spell aboutToCast = SpellLibrary.allSpells[spellid];
aboutToCast.cast();
}

How would I store NBT in an item?

not in the item but in the itemStack

 

ItemStack.java(line ~51):

/**
     * A NBTTagMap containing data about an ItemStack. Can only be used for non stackable items
     */
    public NBTTagCompound stackTagCompound;

 

conviniently, the itemStack used in "onItemUseFirst" and similar method is provided by the caller

 

	public int getSpellId(ItemStack stack){
	return stack.getTagCompound().getInteger("spell");
}

Correct?

pretty much, just make sure to create a new NBTTagCompound if its null at this point

pretty much, just make sure to create a new NBTTagCompound if its null at this point

 

So far, it works like a charm! Thanks!