(Forge 1.18.1)

So this seemed like a really easy thing to do but I cannot get it to work. I need to execute some code when the player stops pressing the right click button on an item. I am able to do that for when the item *is* being used, for the whole duration of right clicking, by overriding "use". But I can't get anything to work when I'm not using the item.

Here are the two methods I tried overriding:

    @Override
    public void releaseUsing(ItemStack stack, Level level, LivingEntity entity, int n) {
        holdingBlock = false;
        System.out.println("off");
    }

@Override
    public ItemStack finishUsingItem(ItemStack stack, Level level, LivingEntity entity) {
        holdingBlock = false;
        System.out.println("off");
        return this.isEdible() ? entity.eat(level, stack) : stack;
    }

Everywhere I look to research this people are using one of these two functions with no problems whatsoever. I cannot get them to do anything, prints don't happen etc. Am I misusing these, or is there another thing I can use? Alternatively is there a way for me to detect when the item is being used in a boolean, and just pass that boolean during inventoryTick? Thanks!

Edited June 23, 20223 yr by canslp

first of all you can not store a value like holdingBlock, in your Item class, you need to use a Capability or a Tag on the ItemStack,
since there is only on instance of your Item

Did I understand you correctly in this sense, neither of the two methods was called?
if yes could you please show more of your code, (full Item class & Item registry)

package com.idtech.item;

import com.idtech.Utils;
import net.minecraft.core.BlockPos;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.item.FallingBlockEntity;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.CreativeModeTab;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.AirBlock;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.EntityBlock;
import net.minecraft.world.level.block.FallingBlock;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.material.Material;
import net.minecraft.world.phys.Vec3;



public class GravgunItem extends Item {

    //static instance for registration
    private static Properties properties = new Properties().tab(CreativeModeTab.TAB_MISC);
    public static Item INSTANCE = new GravgunItem(properties).setRegistryName("gravity_gun");
    public boolean holdingBlock = false;
    public boolean using = false;

    //constructor
    public GravgunItem(Properties properties) {
        super(properties);

    }

    @Override
    public InteractionResultHolder<ItemStack> use(Level level, Player playerIn, InteractionHand handIn) {

        ItemStack itemstack = playerIn.getItemInHand(handIn);

        if(!using) {
            if (!holdingBlock) {
                BlockPos location = Utils.getBlockAtCursor(playerIn, 8d, true);
        
        
                if (location != null) {
                    if (level.getBlockState(location).getBlock() == Blocks.MAGENTA_GLAZED_TERRACOTTA) {
                        level.setBlockAndUpdate(location, Blocks.AIR.defaultBlockState());
                        holdingBlock = true;
                        
                        using=true;
                        System.out.println("on");
                    }
                }
            } else {
        
                FallingBlockEntity thrownBlock = new FallingBlockEntity(level, playerIn.position().x(), playerIn.position().y() + 1, playerIn.position().z(), Blocks.MAGENTA_GLAZED_TERRACOTTA.defaultBlockState());
        
                thrownBlock.setDeltaMovement(new Vec3(Math.sin(playerIn.getYRot() * (Math.PI / -180f)) * 0.5f, playerIn.getXRot() / -90f, Math.cos(playerIn.getYRot() * (Math.PI / -180f)) * 0.5f));
                thrownBlock.time = 1;
        
                level.addFreshEntity(thrownBlock);
                holdingBlock = false;

                using=true;
                System.out.println("on");
            }
        }
        return InteractionResultHolder.pass(itemstack);
    }
    /*@Override
    public ItemStack finishUsingItem(ItemStack stack, Level level, LivingEntity entity) {
        using = false;
        System.out.println("off");
        return this.isEdible() ? entity.eat(level, stack) : stack;
    }*/
    /*@Override
    public void releaseUsing(ItemStack stack, Level level, LivingEntity entity, int n) {
        using = false;
        System.out.println("off");
    }*/
}

So obviously I would only be using one of them at a time but not only do they not seem to be setting using to false, they definitely are not printing "out".

The item registration seems to be working because the item indeed shows up in the world, and the "use" function is also working, it's just the two commented out "stop using" functions that don't work. I'm not sure what you mean about the registration being wrong. I will look into checking the player for a using boolean though, thanks. Do you know what it's called?

Hmm, looks like isUsingItem isn't always true while the player is holding right click. I am not fully sure how it works, it seems to alternate between true or false while you are using something.