[1.19] Invalid type when registering packet

[WhatIsABlock]

Hello,

I am attempting to register my packet:

public class SyncStatusToClientPacket{
    // Server -> Client message packet to sync the players' status of the tutorial

    public int tAccessed;
    public int tCrafted;
    public boolean hAccessed;
    public boolean hCrafted;

    public SyncStatusToClientPacket(int tAccessed, int tCrafted, boolean hAccessed, boolean hCrafted){
        this.tAccessed = tAccessed;
        this.tCrafted = tCrafted;
        this.hAccessed = hAccessed;
        this.hCrafted = hCrafted;
    }

    public SyncStatusToClientPacket(FriendlyByteBuf buffer){
        decoder(buffer);
    }
  
    public static void encoder(SyncStatusToClientPacket msg, FriendlyByteBuf buffer){
        buffer.writeInt(msg.tAccessed);
        buffer.writeInt(msg.tCrafted);
        buffer.writeBoolean(msg.hAccessed);
        buffer.writeBoolean(msg.hCrafted);
    }
    
    public static SyncStatusToClientPacket decoder(FriendlyByteBuf buffer){
        return new SyncStatusToClientPacket(buffer);
    }
  
  	// Sending status to client
    public static void handle(SyncStatusToClientPacket msg, Supplier<NetworkEvent.Context> supplier){
        NetworkEvent.Context ctx = supplier.get();
        ctx.enqueueWork(() -> {
            DistExecutor.unsafeRunWhenOn(Dist.CLIENT, () -> () -> ModClientPacketHandler.handleSyncStatusPacket(msg, supplier));
        });
        ctx.setPacketHandled(true);
    }
} 

I am registering it here:

public class Messages {
    private static final String PROTOCOL_VERSION = "1";

    public static SimpleChannel INSTANCE = NetworkRegistry.newSimpleChannel(
        new ResourceLocation(MCAltTutorial.MODID, "modnetwork"), 
        () -> PROTOCOL_VERSION, 
        PROTOCOL_VERSION::equals, 
        PROTOCOL_VERSION::equals);

    private static int packetId = 0;
    private static int id() { return packetId++; }

    public static void register(){

        // Sync from server to client packet message
        INSTANCE.registerMessage(id(), 
            SyncStatusToClientPacket.class, 
            SyncStatusToClientPacket::encoder,
            SyncStatusToClientPacket::decoder,
            SyncStatusToClientPacket::handle);
    }
}

I am getting a compiler error on the line where the method reference for encoder is passed in to registerMessage:

The type SyncStatusToClientPacket does not define encoder(MSG, FriendlyByteBuf) that is applicable here

I have also attempted to satisfy the BiConsumer parameter by passing in a lambda instead:

INSTANCE.registerMessage(id(), 
            SyncStatusToClientPacket.class, 
            (SyncStatusToClientPacket msg, FriendlyByteBuf buf) -> SyncStatusToClientPacket.encoder(msg, buf),
            ...
);

This caused a different error:

Incompatible type specified for lambda expression's parameter msg

Is the SyncStatusToClientPacket.class argument implicitly passed in, or am I missing something?

[warjort]

Your code compiles fine for me.

Just a guess, but what is your import for Supplier?

It should be from java.util.function, not the one from google or netty. 

Otherwise, check your other imports with the types used by registerMessage().

 

Not related to your problem and just a style thing, but you would normally define the encoder as a class instance method, then the first parameter is implicitly passed as "this".

And methods that not getters are usually named using the verb rather than the noun, e.g.

  
    public void encode(FriendlyByteBuf buffer){
        buffer.writeInt(this.tAccessed);
        buffer.writeInt(this.tCrafted);
        buffer.writeBoolean(this.hAccessed);
        buffer.writeBoolean(this.hCrafted);
    }

[WhatIsABlock]

Thank you, you were correct that I had imported the wrong Supplier.

However, after fixing all instances of the wrongly imported Supplier, the "The type SyncStatusToClientPacket does not define encoder(MSG, FriendlyByteBuf)" error persists even after a clean. 

I do not import or use any of the other types used by registerMessage() (BiConsumer, Function)

[WhatIsABlock]

Quote

Not related to your problem and just a style thing, but you would normally define the encoder as a class instance method, then the first parameter is implicitly passed as "this".

I experimented and modified the encoder signature to be static:

public static void encoder(SyncStatusToClientPacket message, FriendlyByteBuf buffer){
    buffer.writeInt(message.tAccessed);
    buffer.writeInt(message.tCrafted);
    buffer.writeBoolean(message.hAccessed);
    buffer.writeBoolean(message.hCrafted);
}

which did solve the compiler issue.   I do want this to be an instance method however - I am still somewhat of a beginner to java, any idea why the compiler doesn't complain about this?

----------EDIT---------

I read about static method references vs instance method references.  My final code looks like what warjort posted.  Thanks for the help!

Edited July 17, 2022 by WhatIsABlock
I read more java documentation