calling Id of block or item

[PlatonCraft]

flintpickaxe = new ItemFlintPickAxe(650).setUnlocalizedName("flintpickaxe");

this string in the mod means that the item flintpickaxe got id 650, and it sends to class ItemFlintPickAxe.

How can i call that id from the bounds from somewhere? if i calling flintpickaxe.itemID nothing happens. whereever i call itemID it alway equals null. Help please!!

[GotoLink]

  On 8/16/2013 at 10:28 AM, PlatonCraft said:

if i calling flintpickaxe.itemID nothing happens. whereever i call itemID it alway equals null. Help please!!

itemInstance.itemID can't return null. At worse, it returns 0.

That is, if your custom item extends Item class.

[PlatonCraft]

  On 8/16/2013 at 11:35 AM, GotoLink said:

  Quote

if i calling flintpickaxe.itemID nothing happens. whereever i call itemID it alway equals null. Help please!!

itemInstance.itemID can't return null. At worse, it returns 0.

That is, if your custom item extends Item class.

 

flintpickaxe is not instance, this is Item. Once i tested it. and it returned null. but im not sure. anyway, when i calling flintpickaxe.itemID or calling itemID from anywhere it don't returns 650. I am sure. please help, haw can i call this int from the bounds?

[hydroflame]

  Quote

flintpickaxe is not instance

its an instance ...

you told us right here->

  Quote

flintpickaxe = new ItemFlintPickAxe(650).setUnlocalizedName("flintpickaxe");

 

also, int never return null, never, its just impossible. like gotolink said, at worst it will return 0.

 

can we see the class where flintpickaxe is created ?

[PlatonCraft]

itemID maybe not an integer. I not at home actually. I release the code tomorrow. In the top of class is a string "Public static Item flintpickaxe". flintpickaxe is an Item. I know that integer cant return null. You are didnt helped me. How can i call the ID of this block from bouns, i cant create new variable. say me please if itemID is integer, how can i define its value?

[PlatonCraft]

Oh sorry i am wrong, itemID is integer but this is final integer

And this is my project:

[spoiler=ItemFlintPickAxe]

package platon.mods.flintstonetools;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.common.EnumHelper;
import net.minecraftforge.common.Property;

import java.util.Random;

public class ItemFlintPickAxe extends ItemPickaxe{

public ItemFlintPickAxe(int par1)
{
super(par1,FlintBase.FLINT);
	this.setCreativeTab(CreativeTabs.tabTools);
}
@Override
public void registerIcons(IconRegister reg){
this.itemIcon = reg.registerIcon("flintstonetools:ItemFlintPickAxe");
}

public boolean onItemUse(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int par4, int par5, int par6, int par7, float par8, float par9, float par10)
{

float rand = itemRand.nextFloat();
return SetBlockOnFire.SBOF(par1ItemStack, par2EntityPlayer, par3World, par4, par5, par6, par7, par8, par9, par10, rand, this.itemID);
}
}

 

[spoiler=ItemFlintShovel]

package platon.mods.flintstonetools;

import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemSpade;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemFlintShovel extends ItemSpade {

public ItemFlintShovel(int par1)
{
super(par1,FlintBase.FLINT);
	this.setCreativeTab(CreativeTabs.tabTools);
}
@Override
public void registerIcons(IconRegister reg){
this.itemIcon = reg.registerIcon("flintstonetools:ItemFlintShovel");
}
public boolean onItemUse(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int par4, int par5, int par6, int par7, float par8, float par9, float par10)
{
float rand = itemRand.nextFloat();
return SetBlockOnFire.SBOF(par1ItemStack, par2EntityPlayer, par3World, par4, par5, par6, par7, par8, par9, par10, rand, this.itemID);
}
}

 

[spoiler=SetBlockOnFire]

package platon.mods.flintstonetools;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

import net.minecraft.world.World;

public class SetBlockOnFire extends FlintBase{
private static int getRandom(int min, int max) {
    Random random = new Random();
    int res = random.nextInt(max);
    res =   res < min ? res + min : res;
    return res;
}
static boolean a;
public static int[] fireableids = new int[200];
public static boolean isblockfireable(World par3World, int par4, int par5, int par6) {
	for (int i = 0;i<fireableids.length;i++){if (par3World.getBlockId(par4, par5-1, par6)==fireableids[i]) {a = true; break;} else {a = false;}}
	return a;
}
static int tooldmg;
public static boolean SBOF(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int par4, int par5, int par6, int par7, float par8, float par9, float par10, float rand, int id)
{
    if (par7 == 0)
    {
        --par5;
    }

    if (par7 == 1)
    {
        ++par5;
    }

    if (par7 == 2)
    {
        --par6;
    }

    if (par7 == 3)
    {
        ++par6;
    }

    if (par7 == 4)
    {
        --par4;
    }

    if (par7 == 5)
    {
        ++par4;
    }

    if (!par2EntityPlayer.canPlayerEdit(par4, par5, par6, par7, par1ItemStack))
    {
        return false;
    }

    else 
    {
        if (par3World.isAirBlock(par4, par5, par6) && getRandom(1,100)<=30 && SetBlockOnFire.isblockfireable(par3World, par4, par5, par6))
        {
        			par3World.playSoundEffect((double)par4 + 0.5D, (double)par5 + 0.5D, (double)par6 + 0.5D, "fire.ignite", 1.0F, rand * 0.4F + 0.8F);
        			par3World.setBlock(par4, par5, par6, Block.fire.blockID);	
        }

        switch(id){
        case 650:
        	SetBlockOnFire.tooldmg = 1;
        	break;
        case 651:
        	SetBlockOnFire.tooldmg = 2;
        	break;
        }
	par1ItemStack.damageItem(tooldmg, par2EntityPlayer);
        return true;
    }

}
static int[] deffireableids = {1,4,14,15,16,21,23,41,42,45,48,49,56,57,61,73,87,97,98,112,129,153,158,173};
}

 

[spoiler=FlintBase]

package platon.mods.flintstonetools;

import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.common.Configuration;
import net.minecraftforge.common.EnumHelper;
import net.minecraftforge.common.Property;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.Mod.PreInit;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.NetworkMod;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.common.registry.LanguageRegistry;
@Mod (modid = FlintBase.modid, name = "Flintstone Tools", version = "1.0.1a") 
@NetworkMod (clientSideRequired = true, serverSideRequired = false)

public class FlintBase {
public static final String modid = "flintstonetools";
public static FlintBase instance = new FlintBase();
public static Item flintpickaxe;
static int flintpickaxeid;
public static Item flintshovel;
static int flintshovelid;
@EventHandler
public void preLoad(FMLPreInitializationEvent event)
{
Configuration config = new Configuration(event.getSuggestedConfigurationFile());
config.load();
config.defaultEncoding="windows-1251";
flintpickaxeid = config.get("Mod IDs", "flintpickaxeid", 650).getInt();
flintshovelid = config.get("Mod IDs", "flintshovelid", 651).getInt();
SetBlockOnFire.fireableids = config.get("flintpickaxe", "fireableids", SetBlockOnFire.deffireableids).getIntList();
config.addCustomCategoryComment("flintpickaxe", "Here is the list of IDs of blocks that can be setted on fire by the flint pickaxe.\nThat list can be modified. Just add the Ids you want in column.\n\nЗдесь в столбик указаны ID блоков, которые можно поджигать кремневой киркой.\nВы можете изменять его. Просто добавьте свои ID в колонку с новой строки");
config.save();
}
@EventHandler
public void load(FMLInitializationEvent event)
{
flintpickaxe = new ItemFlintPickAxe(flintpickaxeid).setUnlocalizedName("flintpickaxe");
GameRegistry.addRecipe(new ItemStack(FlintBase.flintpickaxe, 1), new Object[]{ "XXX", " # ", " # ",
Character.valueOf('X'), Item.flint, ('#'), Item.stick});
LanguageRegistry.instance().addNameForObject(flintpickaxe, "en_US", "Flint Pickaxe");
LanguageRegistry.instance().addNameForObject(flintpickaxe, "ru_RU", "Кремневая Кирка");


flintshovel = new ItemFlintShovel(flintshovelid).setUnlocalizedName("flintshovel");
int flintshovelid;
GameRegistry.addRecipe(new ItemStack(FlintBase.flintshovel, 1), new Object[]{ " X ", " # ", " # ",
Character.valueOf('X'), Item.flint, ('#'), Item.stick});
LanguageRegistry.instance().addNameForObject(flintshovel, "en_US", "Flint Shovel");
LanguageRegistry.instance().addNameForObject(flintshovel, "ru_RU", "Кремневая Лопата");
}
static EnumToolMaterial FLINT = EnumHelper.addToolMaterial("FLINT", 2, 150, 5.0F, 2.0F, 10);
}

 

[PlatonCraft]

if i define id by another way, all works.

[PlatonCraft]

also i have question: what means this string?

public static FlintBase instance = new FlintBase();

[GotoLink]

flintshovel = new ItemFlintShovel(flintshovelid).setUnlocalizedName("flintshovel");
int flintshovelid;

Remove the variable declaration line, this might confuse with the field.

 

Basic Java:

public static FlintBase instance = new FlintBase();

means you are creating an object which is a new FlintBase().

You don't need to do this with Forge.

@Instance(FlintBase.modid)
public static FlintBase instance;

is recommended. "instance" field will be populated by the API.

 

[PlatonCraft]

I didn't completly understood you. If you want me to delete flintshovelid variable it will not help. I replaced this var in the bounds by integer 650 and it wasn't helped. Or have I misunderstood you?

[GotoLink]

flintshovel = new ItemFlintShovel(flintshovelid).setUnlocalizedName("flintshovel");
//this line is a reference i take in your class file, it uses flintshovelid, which is a field declared (static int flintshovelid;) at the beginning, this is good
int flintshovelid;
//this line is below, doesn't do anything and conflict with the field, this is bad ->remove

Now you can use flintshovel.itemID, after this line, it won't be null or 0.

From an external class: FlintBase.instance.flintshovel.itemID

[PlatonCraft]

still not work. I want to call flintpickaxe id from class ItemFlintPickAxe with something like this.itemID. And from class ItemFlintShovel flintshovel id by the same string. I dont want to write something like FlintBase.instance.flintpickaxe.itemID.

And itemID still undefined and returns 0 after your changes.

 

int flintshovelid is just my error

[PlatonCraft]

Listen, once i had the same problem, I had a problem with calling blockID, it returned me 0, too. And i fixed this error with this forum's help. http://www.minecraftforge.net/forum/index.php/topic,9557.msg48255.html#msg48255 This is that topic. Read it, because I dont understand what did i done.

[GotoLink]

Did you replace

public static FlintBase instance = new FlintBase();

with

@Instance(FlintBase.modid)
public static FlintBase instance;

?

[ILuvYouCompanionCube]

If I recalll corectly, you can't trust item IDs the way you're doing inside your switch, The IDs for items are changed internally. Try replacing the constants inside the switch for your items' field itemID instead (i.e. make the cases in your switch block be flintshovel.itemID and flintaxe.itemID).

 

 

[PlatonCraft]

  On 8/17/2013 at 9:59 AM, GotoLink said:

Did you replace

public static FlintBase instance = new FlintBase();

with

@Instance(FlintBase.modid)
public static FlintBase instance;

?

 

Yes, i did.

[PlatonCraft]

  On 8/17/2013 at 10:17 AM, ILuvYouCompanionCube said:

If I recalll corectly, you can't trust item IDs the way you're doing inside your switch, The IDs for items are changed internally. Try replacing the constants inside the switch for your items' field itemID instead (i.e. make the cases in your switch block be flintshovel.itemID and flintaxe.itemID).

 

 

itemID is not static. but you gave me one thing, real ids is id + 256. I ll try to write new ids

[PlatonCraft]

YES!!! Thank you man!! and you too, gotolink!! Now its works. I have comletely forgot about the real ids. It is the best minecraft modding forum. If I would go to some our russian forums, I likely would not get some help  Thank you!!

[ILuvYouCompanionCube]

you're welcome