Jump to content

How to create an instance to hook into a variable from another class


Conraad

Recommended Posts

Working on 1.6.2, doing a vehicle extension for my existing mod.

 

My problem, I want to add wheel yaw and wheel turning to the vehicle when it drives, the variable inside the vehicle class file won't work unless I make it static which off course end up in turning the wheels of every single entity of vehicle type so a no go.

 

eventually I came up with the following but it still does not work.

 

    public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5)
    {
        for (int i = 0; i < this.vehicleModel.length; i++)
        {
        	this.vehicleModel[i].render(f5);
        }

        for (int j = 0; j < this.wheelModel.length; j++)
        {
        	this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);
        }
    }

 

(((EntityTrucks)entity) just simply does nothing does anyone have any idea on how i should go about making this work\

 

if you need any extra class file code I will pastebin

Link to comment
Share on other sites

your entity truck extends vehicule right ? then you should be able to add a new field inside truck and just use that variable to get the wheel orientation.

did you try printing inside your render method to check that the wheel rotation value was correct ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

your entity truck extends vehicule right ? then you should be able to add a new field inside truck and just use that variable to get the wheel orientation.

did you try printing inside your render method to check that the wheel rotation value was correct ?

 

Weird enough that's what I did the code above have EntityTruck, I've had EntityBedfordTruck which extends to Entitytruck in there just playing around testing.

 

public float wheelYaw; is set in EntityTrucks and set to 0.0F and on entity update when the wheel should move, wheelyaw is changed. but using what you see there doesn't seem to work if i do it the other way around using static works like a charm.

 

her's the code

 

EntityBedfordTruck

http://pastebin.com/PNguVU8a

 

EntityTrucks

http://pastebin.com/m2j42CZ0

 

ModelBedfordTruck

http://pastebin.com/991xK0dx

 

 

On a side note I can see the wheels being rendered, so I know the code is running past that line of code, but that line of code simply does nothing using it the static way would be to add

 

this.wheelModel[j].rotateAngleY = (EntityTrucks.wheelYaw * 3.141593F) / 60F;

 

do that but then you need the wheelyaw float static which interferes with wheels of all vehicles

 

Link to comment
Share on other sites

yeye for sure we dont want it static, makes no sens anyway

but was i mean is, can you print right before that rotation yaw thing? so you can clearly know what is the value at this moment ?

 

System.out.println("value of rotation: "+((EntityTrucks)entity).wheelYaw);
this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

yeye for sure we dont want it static, makes no sens anyway

but was i mean is, can you print right before that rotation yaw thing? so you can clearly know what is the value at this moment ?

 

System.out.println("value of rotation: "+((EntityTrucks)entity).wheelYaw);
this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);

 

Value stays on 0.0 and yeah need to learn debug 101 rofl

Link to comment
Share on other sites

WheelYaw is changed when left/right key is pressed, that sends the key update thru to server and the keys works and been tested on smp truck drives, just this dam wheelyaw when it's static it works when it's not static it won't work

 

Used the print code to print directly where it changes AKA when key is pressed and I can see wheelyaw values are changing

also tested onupdate() and wheelyaw changes when i press the key's but that info is not used by the rendering of the wheel, there value stay on 0.0

 

Link to comment
Share on other sites

don't the entity updates get called server side only? i'm not sure actually. but i vaguely remember that it's only server side. hence the data watchers

 

was typing that but nevermind. if they update client side first for your truck, then i guess you aren't updating it properly like hydroflame said

Link to comment
Share on other sites

So how do you go about updating Entity, apart from the keys where packets are use to update, the rest of the entity is run inside onUpdate method, which does everything and then datawatchers.

 

I even tried a get and set method now, with no avail, so maybe I need to setup a datawatcher to monitor that variable for changes. still clueless of why it works when variable is static but not when it's not static that is like the golden question, answer to that will solve this mystery.

 

This vehicle code is also heavily based of entityboat, to ensure everything works properly, back in 1.2.5 i used to

add EntityBedfordTruck to the rendering method, but with 1.6.2 and new rendering that just doesn't wanna work anymore so

   

public void render(EntityBedfordTruck entity, float f, float f1, float f2, float f3, float f4, float f5) renders an invisible truck

 

 

 

 

 

Link to comment
Share on other sites

what i would do is either calculate the difference between last position and current position and derivate the rotation of the wheels from that, or use the datawatcher, whatever you feel like :)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

and just to clarify. onUpdate() is only called server side. so if you call pressKeyClient() in onUpdate() and only there, you're gonna have to change your set up because it won't work on a dedicated server

 

It works on smp and dedicated servers, that call is for checking whether a key is down and if it is down it sends the packets and runs the public void pressKey(int i) that in turns starts the movement.

 

Why I do it like that because register a new keybinding  with forge for instance WASD keys is a living nightmare, this way you can drive your vehicle using WASD without having to remap vehicle keys differently.

 

assuming onUpdate() is only server side then i will have to look into sending a packet to the client with the wheelyaw values, and it still doesn't make any sense really because if you change public float wheelYaw; to public static float wheelYaw;

 

and change this.wheelModel[j].rotateAngleY = (((EntityBedfordTruck)entity).wheelYaw * 3.141593F) / 60F; to

this.wheelModel[j].rotateAngleY = (EntityBedfordTruck.wheelYaw * 3.141593F) / 60F;

 

without having to change any code the wheels turn and also turn on a dedicated server.

 

So what exactly makes static so special that it works, is my next question.

Link to comment
Share on other sites

@hydroflame yep

 

@OP that's really weird because i just tested it on a dedicated server and it wouldn't even get past the "if (Class.forName() && Keyboablablaba)" part. and it shouldn't. if it's working on a dedicated server, where the heck is it getting the keyboard input from?:o it can't be from the clients because the only checks for keyboard input is in pressClientKey() which is called by the server. also, i don't think you need packets. you can probably just use the datawatcher.

Link to comment
Share on other sites

@hydroflame yep

 

@OP that's really weird because i just tested it on a dedicated server and it wouldn't even get past the "if (Class.forName() && Keyboablablaba)" part. and it shouldn't. if it's working on a dedicated server, where the heck is it getting the keyboard input from?:o it can't be from the clients because the only checks for keyboard input is in pressClientKey() which is called by the server. also, i don't think you need packets. you can probably just use the datawatcher.

 

    @SidedProxy(

            clientSide = "simcraft.core.KeyboardClient",

            serverSide = "simcraft.core.Keyboard"

    )

    public static Keyboard keyboard;

 

and then that sends packets via

 

    @SidedProxy(

            clientSide = "simcraft.core.network.NetworkManagerClient",

            serverSide = "simcraft.core.network.NetworkManager"

    )

    public static NetworkManager network;

 

The mod is like mecca huge the vehicles is just a small part I'm working on right now to extend it even more, in fact the total amount of class files this mod has atm is round about 1400+ so although the keys might not be working on your side, you would need the rest of the mod to actually get this to work let alone send info to server and back to client.

 

Issues is not with the keys, but with that variables information not being send to the renderer or updating it if the value is not static, i will play around see if I can find out what the heck or why the heck that value is not being used correctly, I even tried get and set methods and that didn't work either, will run through the code and track it down, just hoped someone had a keen eye and could save me hours of looking for the problem

Link to comment
Share on other sites

Issues is not with the keys, but with that variables information not being send to the renderer or updating it if the value is not static, i will play around see if I can find out what the heck or why the heck that value is not being used correctly, I even tried get and set methods and that didn't work either, will run through the code and track it down, just hoped someone had a keen eye and could save me hours of looking for the problem

Well if you hardcoded the key check into the entity, the only person able to drive the entity will be the server owner.

Entities should be affected by the packets, not the other way around.

 

Just make the value non static, seriously. It can't make a difference on the way it is sent.

Link to comment
Share on other sites

OK so finally got this to work, information provided by everyone helped.

 

Final results, is that yes when you use a static variable it syncs across client/server interesting actually

 

Easiest way to fix this problem was to use a DataWatcher to monitor the Wheelyaw and then update the DataWatcher whenever the value changes and to get the information across to the model and render properly use a get method, instead of getting the actual value get the current value from the DataWatcher via the get method.

 

Thanks for all the help and advise

 

Link to comment
Share on other sites

Final results, is that yes when you use a static variable it syncs across client/server interesting actually

Only because you tested on your own server.

When you are the server owner, obviously, both client and server classes will share static fields because they are on the same computer. This isn't magic, only JVM at work :)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.