Jump to content

How to create an instance to hook into a variable from another class


Recommended Posts

Posted

Working on 1.6.2, doing a vehicle extension for my existing mod.

 

My problem, I want to add wheel yaw and wheel turning to the vehicle when it drives, the variable inside the vehicle class file won't work unless I make it static which off course end up in turning the wheels of every single entity of vehicle type so a no go.

 

eventually I came up with the following but it still does not work.

 

    public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5)
    {
        for (int i = 0; i < this.vehicleModel.length; i++)
        {
        	this.vehicleModel[i].render(f5);
        }

        for (int j = 0; j < this.wheelModel.length; j++)
        {
        	this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);
        }
    }

 

(((EntityTrucks)entity) just simply does nothing does anyone have any idea on how i should go about making this work\

 

if you need any extra class file code I will pastebin

Posted

your entity truck extends vehicule right ? then you should be able to add a new field inside truck and just use that variable to get the wheel orientation.

did you try printing inside your render method to check that the wheel rotation value was correct ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

your entity truck extends vehicule right ? then you should be able to add a new field inside truck and just use that variable to get the wheel orientation.

did you try printing inside your render method to check that the wheel rotation value was correct ?

 

Weird enough that's what I did the code above have EntityTruck, I've had EntityBedfordTruck which extends to Entitytruck in there just playing around testing.

 

public float wheelYaw; is set in EntityTrucks and set to 0.0F and on entity update when the wheel should move, wheelyaw is changed. but using what you see there doesn't seem to work if i do it the other way around using static works like a charm.

 

her's the code

 

EntityBedfordTruck

http://pastebin.com/PNguVU8a

 

EntityTrucks

http://pastebin.com/m2j42CZ0

 

ModelBedfordTruck

http://pastebin.com/991xK0dx

 

 

On a side note I can see the wheels being rendered, so I know the code is running past that line of code, but that line of code simply does nothing using it the static way would be to add

 

this.wheelModel[j].rotateAngleY = (EntityTrucks.wheelYaw * 3.141593F) / 60F;

 

do that but then you need the wheelyaw float static which interferes with wheels of all vehicles

 

Posted

yeye for sure we dont want it static, makes no sens anyway

but was i mean is, can you print right before that rotation yaw thing? so you can clearly know what is the value at this moment ?

 

System.out.println("value of rotation: "+((EntityTrucks)entity).wheelYaw);
this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

yeye for sure we dont want it static, makes no sens anyway

but was i mean is, can you print right before that rotation yaw thing? so you can clearly know what is the value at this moment ?

 

System.out.println("value of rotation: "+((EntityTrucks)entity).wheelYaw);
this.wheelModel[j].rotateAngleY = (((EntityTrucks)entity).wheelYaw * 3.141593F) / 60F;
        	this.wheelModel[j].render(f5);

 

Value stays on 0.0 and yeah need to learn debug 101 rofl

Posted

well then now you know that somewhere in your entity update code you are not properly updating your wheelYaw :)

 

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

WheelYaw is changed when left/right key is pressed, that sends the key update thru to server and the keys works and been tested on smp truck drives, just this dam wheelyaw when it's static it works when it's not static it won't work

 

Used the print code to print directly where it changes AKA when key is pressed and I can see wheelyaw values are changing

also tested onupdate() and wheelyaw changes when i press the key's but that info is not used by the rendering of the wheel, there value stay on 0.0

 

Posted

don't the entity updates get called server side only? i'm not sure actually. but i vaguely remember that it's only server side. hence the data watchers

 

was typing that but nevermind. if they update client side first for your truck, then i guess you aren't updating it properly like hydroflame said

Posted

So how do you go about updating Entity, apart from the keys where packets are use to update, the rest of the entity is run inside onUpdate method, which does everything and then datawatchers.

 

I even tried a get and set method now, with no avail, so maybe I need to setup a datawatcher to monitor that variable for changes. still clueless of why it works when variable is static but not when it's not static that is like the golden question, answer to that will solve this mystery.

 

This vehicle code is also heavily based of entityboat, to ensure everything works properly, back in 1.2.5 i used to

add EntityBedfordTruck to the rendering method, but with 1.6.2 and new rendering that just doesn't wanna work anymore so

   

public void render(EntityBedfordTruck entity, float f, float f1, float f2, float f3, float f4, float f5) renders an invisible truck

 

 

 

 

 

Posted

what i would do is either calculate the difference between last position and current position and derivate the rotation of the wheels from that, or use the datawatcher, whatever you feel like :)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

and just to clarify. onUpdate() is only called server side. so if you call pressKeyClient() in onUpdate() and only there, you're gonna have to change your set up because it won't work on a dedicated server

Posted

and just to clarify. onUpdate() is only called server side

 

 

really ?? you sure ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

and just to clarify. onUpdate() is only called server side. so if you call pressKeyClient() in onUpdate() and only there, you're gonna have to change your set up because it won't work on a dedicated server

 

It works on smp and dedicated servers, that call is for checking whether a key is down and if it is down it sends the packets and runs the public void pressKey(int i) that in turns starts the movement.

 

Why I do it like that because register a new keybinding  with forge for instance WASD keys is a living nightmare, this way you can drive your vehicle using WASD without having to remap vehicle keys differently.

 

assuming onUpdate() is only server side then i will have to look into sending a packet to the client with the wheelyaw values, and it still doesn't make any sense really because if you change public float wheelYaw; to public static float wheelYaw;

 

and change this.wheelModel[j].rotateAngleY = (((EntityBedfordTruck)entity).wheelYaw * 3.141593F) / 60F; to

this.wheelModel[j].rotateAngleY = (EntityBedfordTruck.wheelYaw * 3.141593F) / 60F;

 

without having to change any code the wheels turn and also turn on a dedicated server.

 

So what exactly makes static so special that it works, is my next question.

Posted

@hydroflame yep

 

@OP that's really weird because i just tested it on a dedicated server and it wouldn't even get past the "if (Class.forName() && Keyboablablaba)" part. and it shouldn't. if it's working on a dedicated server, where the heck is it getting the keyboard input from?:o it can't be from the clients because the only checks for keyboard input is in pressClientKey() which is called by the server. also, i don't think you need packets. you can probably just use the datawatcher.

Posted

the part where the server doesnt know about keyboard input is obvious :P

but the part about client not calling onUpdate on every entity im not sure about

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

@hydroflame yep

 

@OP that's really weird because i just tested it on a dedicated server and it wouldn't even get past the "if (Class.forName() && Keyboablablaba)" part. and it shouldn't. if it's working on a dedicated server, where the heck is it getting the keyboard input from?:o it can't be from the clients because the only checks for keyboard input is in pressClientKey() which is called by the server. also, i don't think you need packets. you can probably just use the datawatcher.

 

    @SidedProxy(

            clientSide = "simcraft.core.KeyboardClient",

            serverSide = "simcraft.core.Keyboard"

    )

    public static Keyboard keyboard;

 

and then that sends packets via

 

    @SidedProxy(

            clientSide = "simcraft.core.network.NetworkManagerClient",

            serverSide = "simcraft.core.network.NetworkManager"

    )

    public static NetworkManager network;

 

The mod is like mecca huge the vehicles is just a small part I'm working on right now to extend it even more, in fact the total amount of class files this mod has atm is round about 1400+ so although the keys might not be working on your side, you would need the rest of the mod to actually get this to work let alone send info to server and back to client.

 

Issues is not with the keys, but with that variables information not being send to the renderer or updating it if the value is not static, i will play around see if I can find out what the heck or why the heck that value is not being used correctly, I even tried get and set methods and that didn't work either, will run through the code and track it down, just hoped someone had a keen eye and could save me hours of looking for the problem

Posted
n fact the total amount of class files this mod has atm is round about 1400+

what the even fuck ?

1400?!?!

are you making like every mod ever ? (ok exgagerating but wtf ?)

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

Issues is not with the keys, but with that variables information not being send to the renderer or updating it if the value is not static, i will play around see if I can find out what the heck or why the heck that value is not being used correctly, I even tried get and set methods and that didn't work either, will run through the code and track it down, just hoped someone had a keen eye and could save me hours of looking for the problem

Well if you hardcoded the key check into the entity, the only person able to drive the entity will be the server owner.

Entities should be affected by the packets, not the other way around.

 

Just make the value non static, seriously. It can't make a difference on the way it is sent.

Posted

OK so finally got this to work, information provided by everyone helped.

 

Final results, is that yes when you use a static variable it syncs across client/server interesting actually

 

Easiest way to fix this problem was to use a DataWatcher to monitor the Wheelyaw and then update the DataWatcher whenever the value changes and to get the information across to the model and render properly use a get method, instead of getting the actual value get the current value from the DataWatcher via the get method.

 

Thanks for all the help and advise

 

Posted

Final results, is that yes when you use a static variable it syncs across client/server interesting actually

Only because you tested on your own server.

When you are the server owner, obviously, both client and server classes will share static fields because they are on the same computer. This isn't magic, only JVM at work :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.