Jump to content

[1.19] getStateForPlacement not returning the right blockstate


tomatosauce

Recommended Posts

Hi, I am trying to register a very simple "Connected Block" block with 4 boolean properties with default state of false for all. On placement, where getStateForPlacement is called, I just want to set the "south_connected" property to true for testing. However, the F3 console displays all 4 properties as true once placed. PS removing the custom implementation of getStateForPlacement returns a block state with all 4 properties as false as expected.

 

public class ConnectedBlock extends Block {
    public static final BooleanProperty SOUTH_CONNECTED = BooleanProperty.create("south_connected");
    public static final BooleanProperty EAST_CONNECTED = BooleanProperty.create("east_connected");
    public static final BooleanProperty WEST_CONNECTED = BooleanProperty.create("west_connected");
    public static final BooleanProperty NORTH_CONNECTED = BooleanProperty.create("north_connected");

    public ConnectedBlock() {
        super(BlockBehaviour.Properties.of(Material.STONE));

        registerDefaultState(stateDefinition.any()
                .setValue(SOUTH_CONNECTED, false)
                .setValue(EAST_CONNECTED, false)
                .setValue(WEST_CONNECTED, false)
                .setValue(NORTH_CONNECTED, false)
        );
    }

    @Override
    public BlockState getStateForPlacement(BlockPlaceContext context) {
        return getStateDefinition().any().setValue(SOUTH_CONNECTED, true);
    }

    @Override
    protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> builder) {
        builder.add(SOUTH_CONNECTED, EAST_CONNECTED, WEST_CONNECTED, NORTH_CONNECTED);
    }
}

Why is that? Thanks in advanced

Link to comment
Share on other sites

 return this.defaultBlockState().setValue(SOUTH_CONNECTED, true);

The why is look at Block.getStateForPlacement()

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Yes. You might want to look at what FenceBlock does. That sounds close to what you are doing?

  • Like 1

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to add trees to my mod but all the examples I've seen so far include data generation, and not json files. The json files for the blocks are not the issue here. Unless trees require certain json files as a structure, I'm certain I've got this part covered. The thing I'm looking for is probably a deferred register or any other way to register something as a tree so it will grow from a sapling. Here is what I currently have: public static final DeferredRegister<ConfiguredFeature<?, ?>> TREES = DeferredRegister.create(Registries.CONFIGURED_FEATURE, ExtinctionCraft.MOD_ID); // How do I register the tree? public static final ResourceKey<ConfiguredFeature<?, ?>> SEQUOIA_KEY = registerKey("sequoia"); public static void bootstrap(BootstapContext<ConfiguredFeature<?, ?>> context) { register(SEQUOIA_KEY, Feature.TREE, new TreeConfiguration.TreeConfigurationBuilder( BlockStateProvider.simple(ModBlocks.SEQUOIA_LOG.get()), new StraightTrunkPlacer(5, 4, 3), BlockStateProvider.simple(ModBlocks.SEQUOIA_LEAVES.get()), new PineFoliagePlacer(ConstantInt.of(3), ConstantInt.of(2), ConstantInt.of(3)), new TwoLayersFeatureSize(1, 0, 2)).build()); } public static ResourceKey<ConfiguredFeature<?, ?>> registerKey(String name) { return ResourceKey.create(Registries.CONFIGURED_FEATURE, new ResourceLocation(ExtinctionCraft.MOD_ID, name)); } private static <FC extends FeatureConfiguration, F extends Feature<FC>> void register(BootstapContext<ConfiguredFeature<?, ?>> context, ResourceKey<ConfiguredFeature<?, ?>> key, F feature, FC configuration) { context.register(key, new ConfiguredFeature<>(feature, configuration)); } I also have this Grower class: public class SequoiaGrower extends AbstractTreeGrower { @Nullable @Override protected ResourceKey<ConfiguredFeature<?, ?>> getConfiguredFeature(RandomSource pRandom, boolean pHasFlowers) { return ModConfiguredFeatures.SEQUOIA_KEY; } } And the registry of the blocks that make up the tree (excluding wood blocks that I have registered but that don't make up part of a tree): public static final RegistryObject<Block> SEQUOIA_LOG = registerBlock("sequoia_log", () -> new ModFlammableRotatedPillarBlock(BlockBehaviour.Properties.copy(Blocks.OAK_LOG).strength(3))); public static final RegistryObject<Block> SEQUOIA_LEAVES = registerBlock("sequoia_leaves", () -> new ModLeavesBlock(BlockBehaviour.Properties.copy(Blocks.OAK_LEAVES))); public static final RegistryObject<Block> SEQUOIA_SAPLING = registerBlock("sequoia_sapling", () -> new SaplingBlock(new SequoiaGrower(), BlockBehaviour.Properties.copy(Blocks.OAK_SAPLING)));   How do I move on from here? Examples of your code are welcome too.
    • These libraries failed to download. Try again. com.google.code.findbugs:jsr305:3.0.2 commons-io:commons-io:2.4
    • Make a test just with Forge - without any mods Then add the latest.log from your logs-folder
    • Make a test with a custom directory https://minecrafthopper.net/help/guides/changing-game-directory/
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.