Jump to content

Saving data w/ items [Solved]


Lua

Recommended Posts

Okay Im trying to save the items in container item based gui. This is what ive got so far but I cant seem to get it to work:

 

ItemBagpackInventory(Ive written some comments on some bits which I think is the problem

 

package simplecamping;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;

public class ItemBagpackInventory implements IInventory
{

private ItemStack[] inv;
private ItemStack bagpack;

public ItemBagpackInventory(ItemStack itemstack)
{
	inv = new ItemStack[27];
	bagpack = itemstack;
}

@Override
public int getSizeInventory()
{
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inv[slot];
}

@Override
public ItemStack decrStackSize(int slot, int amt)
{
	ItemStack stack = getStackInSlot(slot);
	if(stack != null)
	{
		if(stack.stackSize <= amt)
		{
			setInventorySlotContents(slot, null);
		}
		else
		{
			stack = stack.splitStack(amt);
			if(stack.stackSize == 0)
			{
				setInventorySlotContents(slot, null);
			}
		}
	}
	return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	if(stack != null)
	{
		setInventorySlotContents(slot, null);
	}
	return stack;
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	inv[slot] = stack;
	if(stack != null && stack.stackSize > getInventoryStackLimit())
	{
		stack.stackSize = getInventoryStackLimit();
	}
}

@Override
public String getInvName()
{
	return "Bagpack";
}

@Override
public boolean isInvNameLocalized()
{
	return false;
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public void onInventoryChanged()
{}

@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer)
{
	return true;
}

public NBTTagCompound writeToNBT(NBTTagCompound tagCompound)
{
	NBTTagList itemList = new NBTTagList();
	for(int i = 0; i < inv.length; i++)
	{
		ItemStack stack = inv[i];
		if(stack != null)
		{
			NBTTagCompound tag = new NBTTagCompound();
			tag.setByte("Slot", (byte) i);
			stack.writeToNBT(tag);
			itemList.appendTag(tag);
		}
	}
	tagCompound.setTag("Inventory", itemList);
	return tagCompound;
}

public void readFromNBT(NBTTagCompound tagCompound)
{
	NBTTagList tagList = tagCompound.getTagList("Inventory");

	for(int i = 0; i < tagList.tagCount(); i++)
	{
		NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
		byte slot = tag.getByte("Slot");
		System.out.println(i);

		if(slot >= 0 && slot < inv.length)
		{
			inv[slot] = ItemStack.loadItemStackFromNBT(tag);
			System.out.println("slot");
		}
	}
}

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack)
{
	return true;
}

@Override
public void openChest()
{
	if(bagpack.hasTagCompound())
	{
		System.out.println("hastag");//never gets printed
		readFromNBT(bagpack.getTagCompound());
	}
}

@Override
public void closeChest()
{
	if(! bagpack.hasTagCompound())
	{

		System.out.println("writing without tag compound"); //Prints all the time, even after its set and it should be false
		bagpack.setTagCompound(new NBTTagCompound());
	}

	NBTTagCompound tag = bagpack.getTagCompound();
	writeToNBT(tag);

}

}

 

 

Container Bagpack:

 

package simplecamping;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;

public class ContainerBagpack extends Container
{

private ItemBagpackInventory bginv;

public ContainerBagpack(InventoryPlayer inventoryPlayer, ItemBagpackInventory bagpack)
{
	bginv = bagpack;
	bagpack.openChest();

	for(int i = 0; i < 3; i++)
	{
		for(int j = 0; j < 9; j++)
		{
			addSlotToContainer(new Slot(bginv, j + i * 3, 8 + j * 18, 17 + i * 18));
		}
	}

	bindPlayerInventory(inventoryPlayer);
}

@Override
public boolean canInteractWith(EntityPlayer player)
{
	return bginv.isUseableByPlayer(player);
}

protected void bindPlayerInventory(InventoryPlayer inventoryPlayer)
{
	for(int i = 0; i < 3; i++)
	{
		for(int j = 0; j < 9; j++)
		{
			addSlotToContainer(new Slot(inventoryPlayer, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
		}
	}

	for(int i = 0; i < 9; i++)
	{
		addSlotToContainer(new Slot(inventoryPlayer, i, 8 + i * 18, 142));
	}
}

public void onContainerClosed(EntityPlayer par1EntityPlayer)
{
	super.onContainerClosed(par1EntityPlayer);
	this.bginv.closeChest();
}
}

 

 

GuBagpack:

package simplecamping;

import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

import cpw.mods.fml.client.FMLClientHandler;

public class GuiBagpack extends GuiContainer
{
    public ItemBagpackInventory bagpack;

    public GuiBagpack(InventoryPlayer par1InventoryPlayer, ItemBagpackInventory bgInv)
    {
        super(new ContainerBagpack(par1InventoryPlayer, bgInv));
        this.bagpack = bgInv;
    }

    /**
     * Draw the foreground layer for the GuiContainer (everything in front of the items)
     */
    protected void drawGuiContainerForegroundLayer(int par1, int par2)
    {
        String s = this.bagpack.isInvNameLocalized() ? this.bagpack.getInvName() : I18n.func_135053_a(this.bagpack.getInvName());
        this.fontRenderer.drawString(s,  8, 6, 4210752);
        this.fontRenderer.drawString(I18n.func_135053_a("container.inventory"), 8, this.ySize - 96 + 2, 4210752);
    }

    /**
     * Draw the background layer for the GuiContainer (everything behind the items)
     */
    protected void drawGuiContainerBackgroundLayer(float par1, int par2, int par3)
    {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
	FMLClientHandler.instance().getClient().renderEngine.func_110577_a(new ResourceLocation(Strings.MOD_ID, "/textures/gui/bagpack.png"));
        int k = this.guiLeft;
	int l = this.guiTop;
	this.drawTexturedModalRect(k, l, 0, 0, 256, 256);
    }
}

 

GuiHandler:

 

package simplecamping;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import cpw.mods.fml.common.network.IGuiHandler;

public class GuiHandler implements IGuiHandler
{
@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);
	ItemBagpackInventory bp = new ItemBagpackInventory(player.inventory.getCurrentItem());

	switch(id)
	{
	case 0:
		return new ContainerCampfire(player.inventory, (TileEntityCampfire) tile_entity);
	case 1: 
		return new ContainerBagpack(player.inventory, (ItemBagpackInventory) bp);
	}
	return true;
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{		
	TileEntity tile_entity = world.getBlockTileEntity(x, y, z);
	ItemBagpackInventory bp = new ItemBagpackInventory(player.inventory.getCurrentItem());//is not 100% the backpack

	switch(id)
	{
	case 0:
		return new GuiCampfire(player.inventory, (TileEntityCampfire) tile_entity);
	case 1:
		return new GuiBagpack(player.inventory, (ItemBagpackInventory) bp);
	}
	return true;
}
}

 

Link to comment
Share on other sites

  • Replies 51
  • Created
  • Last Reply

Top Posters In This Topic

@GotoLink Okay this is what i tried and it didnt work:

 

@Override
public void openChest()
{
	NBTTagCompound compound = new NBTTagCompound();
	ItemStack stack = ItemStack.loadItemStackFromNBT(compound);
	if(bagpack.hasTagCompound())
	{
		System.out.println("hastag");//never gets printed
		//readFromNBT(bagpack.getTagCompound());
		readFromNBT(stack.getTagCompound());
	}
}

@Override
public void closeChest()
{
	NBTTagCompound compound = new NBTTagCompound();
	ItemStack stack = ItemStack.loadItemStackFromNBT(compound);
		System.out.println("writing without tag compound"); //Prints all the time, even after its set and it should be false
		//bagpack.setTagCompound(new NBTTagCompound());
		if(stack != null)
		{
		writeToNBT(stack.getTagCompound());
		}
}

Link to comment
Share on other sites

I stand corrected, I didn't read all of your code. This should work :

@Override
public void openChest()
{
		if(bagpack.hasTagCompound())
	 {
  			readFromNBT(bagpack.getTagCompound());//Bag pack has some info for the inventory
	 }
                else
                {
                        bagpack.setTagCompound(writeToNBT(new NBTTagCompound()));//this is a "new" bagpack
                }
}

@Override
public void closeChest()
{
	if(! bagpack.hasTagCompound())
	 {
                        //Should never be reached, since done when opening the first time
		 bagpack.setTagCompound(writeToNBT(new NBTTagCompound()));
	}
                else
                {//We made changes to the inventory, save them
	        bagpack.setTagCompound(writeToNBT(bagpack.getTagCompound()));
                }

}

Link to comment
Share on other sites

well what you are trying to do is obviously possible, did you even debug at all?? try to check where it was saving/not saving

 

System.out.println("text");

System.out.println("the value of derp is: "+derp);

 

or even

 

try{

throw new Exception("weird thing happenning here !");

}catch(Exception e{

e.printStackTrace();

}

 

if you really need ?

 

i dont knwo just by looking at it whats wrong, but i know what you are trying to do is not impossible

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Yes I have

@Override
public void openChest()
{
	if(bagpack.hasTagCompound())
	{
		System.out.println("hastag");//never gets printed
		readFromNBT(bagpack.getTagCompound());
	}
}

@Override
public void closeChest()
{
	if(! bagpack.hasTagCompound())
	{

		System.out.println("writing without tag compound"); //Prints all the time, even after its set and it should be false
		bagpack.setTagCompound(new NBTTagCompound());
	}

	NBTTagCompound tag = bagpack.getTagCompound();
	writeToNBT(tag);

}

 

It seems that the tag never gets properly because it always seems to get set everytime and always goes through the if statement. But the hasCompound never gets printed

Link to comment
Share on other sites

public void openChest()
{
	if(bagpack.hasTagCompound())
	{
		System.out.println("hastag");//never gets printed
		readFromNBT(bagpack.getTagCompound());
	}
}

well this code alone will not make bagpack magicly have a tagCompount

 

you should have a else then set a new tag compound like gotolink said in his post

 

public void openChest()
{
	if(bagpack.hasTagCompound())
	{
		System.out.println("hastag");//never gets printed
		readFromNBT(bagpack.getTagCompound());
	}else{
                    bagpack.stackTagCompound = new NBTTagCompound();//im assuming that bagpack is an instance of ItemStack .. ?? ?
                }
}

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Okay, after some more testing, it seems that it writes to nbt when opened to according to the console. And its trying to read the nbt but it looks like nothing is there. Also yeah bagpack is an instance of itemstack

Link to comment
Share on other sites

after setting the new nbt, did you write anythign to it? because if not thats kindof normal

 

public class vec3{
public float x = 0, y = 0, z = 0;
}


in program:
vec3 = new vec3();
println(vec3.x);

"oh its 0 :\"
"yeah thats normal"

 

or are you legitimatelly writing to it and its not apparing :P

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.