Jump to content

Open Vanilla GUI w/ item right click?


GravityWolf
 Share

Recommended Posts

Hello! I am trying to get an item to get items to open chests, furnaces, and crafting tables. I can't seem to get it to work. Here is the code I am trying to use:

 

public boolean onItemUse(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    {
        if (par1World.isRemote)
        {
            return true;
        }
        else
        {
            par5EntityPlayer.displayGUIWorkbench(par2, par3, par4);
            return true;
        }
        
    }

 

I'm pretty sure it's not working cause this never gets called, but I can't put this in onItemRightClick()...anyone have any ideas?

Link to comment
Share on other sites

Alrighty. I got this far:

 

	@Override
 public boolean onItemUse(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int x, int y, int z, int par7, float par8, float par9, float par10)
        {
  if (!par3World.isRemote)
                {
                        return true;
                }
                else
                {
                        par2EntityPlayer.displayGUIWorkbench(x, y, z);
                        return true;
                }
        }
}

 

It only works whilst right clicking on the ground, though. Any ideas?

Link to comment
Share on other sites

Alrighty. I got this far:

 

	@Override
 public boolean onItemUse(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int x, int y, int z, int par7, float par8, float par9, float par10)
        {
  if (!par3World.isRemote)
                {
                        return true;
                }
                else
                {
                        par2EntityPlayer.displayGUIWorkbench(x, y, z);
                        return true;
                }
        }
}

 

It only works whilst right clicking on the ground, though. Any ideas?

 

Try using onItemRightClick() method... And also, why are you returning true in both statements? I am thinking you might want to make on e false

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Alrighty. I got this far:

 

	@Override
 public boolean onItemUse(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int x, int y, int z, int par7, float par8, float par9, float par10)
        {
  if (!par3World.isRemote)
                {
                        return true;
                }
                else
                {
                        par2EntityPlayer.displayGUIWorkbench(x, y, z);
                        return true;
                }
        }
}

 

It only works whilst right clicking on the ground, though. Any ideas?

 

Try using onItemRightClick() method... And also, why are you returning true in both statements? I am thinking you might want to make on e false

 

This doesn't work at all:

 

public ItemStack onItemRightClick(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, World par3World, int x, int y, int z, int par7, float par8, float par9, float par10)
        {
  if (!par3World.isRemote)
                {
                        return null;
                }
                else
                {
                        par2EntityPlayer.displayGUIWorkbench(x, y, z);
                        return null;
                        
                }
        }
}

Link to comment
Share on other sites

No... Just.... No...... Do you even know what a null does???? IT RETURNS A NULL POINTER EXCEPTION!!!!! You should return the par1ItemStack....

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

try taking off the if(!world.isRemote)

 

I don't think client EntityPlayers can open GUIs

 

No, no they can't.... No wonder I thought there was something wrong with this xD

 

Thanks for clearing my mind :D

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Are you using onItemUse or onItemRightClick ? use both just to be safe, if it works, undo one of them to figure which one worked :P

 

onItemUse is just when you right click a block with an item, so that's not really what I want. I am using onItemRightClick, but onItemUse did work when I tried it. Just wasn't right, though.

Link to comment
Share on other sites

navigating through some the minecraft classes I've found out what was wrong.

 

you need to damage the ItemStack, so a method called tryUseItem will return true. This method is in a class called net.minecraft.item.ItemInWorldManager. If it returns false it is as if you failed on using the item. So, you have to set the item maxDamage (using the method setMaxDamage of the Item, maybe in the constructor), which is the maximum number of times you can use the item. If you don't set this, it will be zero, and tryUseItem will return false even earlier.

 

The item will break eventually, but it's just a matter of setting a very very large number if you don't want it to break soon. (Like Integer.MAX_VALUE if you want it to last reeeally long)

 

This is what you have to do:

 

public *nameOfYourConstructor*(*parameter list of your constructor*)
{
     super(*parameter list of superclass constructor*);
     *whatever else your constructor does*
     setMaxDamage(*whatever int you want*);
}

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World world, EntityPlayer player)
{
     if(world.isRemote)
     {
          player.displayGUIWorkbench((int)player.posX, (int)player.posY, (int)player.posZ);
          setDamage(par1ItemStack, par1ItemStack.getItemDamage() + 1);
     }
     return par1ItemStack;
}

Link to comment
Share on other sites

navigating through some the minecraft classes I've found out what was wrong.

 

you need to damage the ItemStack, so a method called tryUseItem will return true. This method is in a class called net.minecraft.item.ItemInWorldManager. If it returns false it is as if you failed on using the item. So, you have to set the item maxDamage (using the method setMaxDamage of the Item, maybe in the constructor), which is the maximum number of times you can use the item. If you don't set this, it will be zero, and tryUseItem will return false even earlier.

 

The item will break eventually, but it's just a matter of setting a very very large number if you don't want it to break soon. (Like Integer.MAX_VALUE if you want it to last reeeally long)

 

This is what you have to do:

 

public *nameOfYourConstructor*(*parameter list of your constructor*)
{
     super(*parameter list of superclass constructor*);
     *whatever else your constructor does*
     setMaxDamage(*whatever int you want*);
}

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World world, EntityPlayer player)
{
     if(world.isRemote)
     {
          player.displayGUIWorkbench((int)player.posX, (int)player.posY, (int)player.posZ);
          setDamage(par1ItemStack, par1ItemStack.getItemDamage() + 1);
     }
     return par1ItemStack;
}

 

Thanks, it brings up the GUI, but now I have another problem =/

When I click on the item, it moves right back to the slot it was on previously. Any ideas?

Link to comment
Share on other sites

You only open the GUI client-side [if (world.isRemote)].

Don't do that. If you check the side, only open it server side (world.isRemote == false).

 

Btw: I doubt you can open the Workbench GUI with this. The ContainerWorkbench requires an actual workbench block to be present at the coordinates you give it.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.