Jump to content

Crash at handleMobSpawn - Packet24MobSpawn


Mazetar

Recommended Posts

When I roam the world I after a while get a crash which seems to be due to a mob spawning and a packet being sent but I'm unable to figure out why and whats wrong.

 

As far as I can tell the packet is of a ID number which is not associated with any entity in the hashmap. On the web I read about a bug in which this happens and that was related to the ID being converted to a byte, this was seemingly only a problem if one registered using EntityRegistry.registerGlobalEntityID.

 

As we are using EntityRegistry.registerModEntity I thought that this would not be a problem, but it seems to be so anyways, or maybe this is a different problem?

 

Here's the log, although it doesn't say much:

 

Description: Exception in world tick

java.lang.NullPointerException
at net.minecraft.client.multiplayer.NetClientHandler.handleMobSpawn(NetClientHandler.java:952)
at net.minecraft.network.packet.Packet24MobSpawn.processPacket(Packet24MobSpawn.java:143)
at net.minecraft.network.MemoryConnection.processReadPackets(MemoryConnection.java:89)
at net.minecraft.client.multiplayer.NetClientHandler.processReadPackets(NetClientHandler.java:281)
at net.minecraft.client.multiplayer.WorldClient.tick(WorldClient.java:99)
at net.minecraft.client.Minecraft.runTick(Minecraft.java:1916)
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:898)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:826)
at net.minecraft.client.main.Main.main(Main.java:93)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:57)
at net.minecraft.launchwrapper.Launch.main(Launch.java:18)

 

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Hmm this is odd, because all entity registration calls upon one method for registration.

public static int NEXT_MOD_ENTITY_ID = 100;
    
public static void registerModEntity(Class<? extends Entity> clazz, String name, int modID, int trackingRange, int updateFrequency, boolean sendsVelocityUpdates) {
    EntityRegistry.registerModEntity(clazz, name, NEXT_MOD_ENTITY_ID++, DivineRPG.instance, trackingRange, updateFrequency, sendsVelocityUpdates);
}

 

So the modID should never be passed in as 0 hmm

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

EntityRegistry.registerModEntity(args) doesn't register any Entity id.

The given modID is internal to Forge, and has nothing to do with the id in EntityList.

You can start your modID at 0, it doesn't matter.

 

The error you are having can be due to left-over from old code. Try in a new world.

Also check that all your entities have a default (World) constructor.

Link to comment
Share on other sites

EntityRegistry.registerModEntity(args) doesn't register any Entity id.

The given modID is internal to Forge, and has nothing to do with the id in EntityList.

You can start your modID at 0, it doesn't matter.

 

The error you are having can be due to left-over from old code. Try in a new world.

Also check that all your entities have a default (World) constructor.

 

Okay well I tested with new worlds, same result but I will go trough all the entities and check that they have a public constructor which takes World as the only argument.

 

Thanks for your help so far :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Okay so I went and looked into every entity, and there was one which didn't have the constructor so i fixed it.

But he was never called or spawned by anything in the code.

 

The only thing not having the mentioned constructor are EntityFX's and as far as I can tell they don't have them at all, their super does not accept world as a single argument for any constructor so I assume it's fine as it is :)

 

Now I created three new worlds and I crashed the same crash type on every one of them.

The

 
2013-08-28 00:48:36 [WARNING] [Minecraft-Client] Skipping Entity with id 0 

still shows in the console as well :/

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Asking around on the minecraft boards I got the following reply:

Check your code again because registering mob entities does not use Vanilla packets for spawning, e.g., Packet24MobSpawn. It uses FML's EntitySpawnPacket which is sent as Packet250CustomPayload and handled/executed in their own Network Manager.

 

If this is true, then what would be causing the Packet24MobsSpawn to be sent?

I'm using some custom mob spawners, could that be the case? I will try to look into that at least.

 

And even if the above is true, it doesn't explain the "Skipping Entity with id 0" part?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

The only thing not having the mentioned constructor are EntityFX's and as far as I can tell they don't have them at all, their super does not accept world as a single argument for any constructor so I assume it's fine as it is :)

The Entity, which is super of EntityFX, has a World only constructor.

Provided your are registering and making them client-side, I don't see them likely to crash this way.

 

Your custom spawners are worth investigating.

 

Check your code again because registering mob entities does not use Vanilla packets for spawning, e.g., Packet24MobSpawn. It uses FML's EntitySpawnPacket which is sent as Packet250CustomPayload and handled/executed in their own Network Manager.

I didn't know that...I suppose it makes sense since the registration is separated...

Link to comment
Share on other sites

I looked into spawners and as far as I can tell they aren't doing anything weird.

It's just an extension of the vanilla mob spawner except that it takes the entity name as a param which it uses to decide which mob to spawn. And for the spawning it doesn't seem to do anything weird so I dunno but I don't think that's the problem.

 

I've looked into the calling for the Packet24MobSpawn and the only place it's called is during the method getPacketForThisEntity(args) inside EntityTrackerEntry.

 

If it fails several if checks, it ends up at this one here:

else if (!(this.myEntity instanceof IAnimals) && !(this.myEntity instanceof EntityDragon))

If it passes it's packet23 and we are good, if it fails it's packet24MobSpawn.

So if I'm not totally blind now the above sentence means that if the entity inherits from EntityDragon or IAnimals it will result in packet24MobSpawn.

 

Inside the code we have some mobs which extends upon EntityWaterMob and EntityTameable which in turn implements IAnimals!

I'm guessing this could be a possible reason as to why this happens, although I'm not exactly sure as to why we end up at this code place.

So I will now try to go up the calling hierarchy and see what happens futher uo the path.

 

I will try to remove the mobs which extend the mentioned classes / comment them out and if that works I will re-write the entities code to avoid having to extend/implement those classes.

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Okay just to test, I set the update velocity to false. That made no difference for the crash.

 

The thing that makes me wonder still is the following line from the log:

2013-08-30 20:49:50 [WARNING] [Minecraft-Client] Skipping Entity with id 0

This happens as soon as I enter a world.

I'd assume there's some entity not being registered properly but I can't figure out which one, as I look at the lists everything seems to be in order.

 

A breakpoint at the two points in the minecraft code which outputs such text reveals that it's output from EntityList.Java when it's createEntityByID is called with ID 0. Resulting in null for the entity found and therefore outputting that msg.

 

The call stack reveals that it's called by NetClientHandler.handleMobSpawn(Packet24MobSpawn) : 951.

The packet contains an EntityID of 1038. O.o

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I may have found a solution, by placing a breakpoint at the line creating the packet I thought earlier I could look at every packet and find the one causing the trouble. But I quickly realized that there was insanely many packets of that type being sent.

 

Now I have to admit I was quite thoughtless, I could have done it so much easier.

Conditional breakpoints ftw. By using them to filter out any packet related to vanilla mobs I was able to find the entity responsible for the crash.

 

I found it to be added to the a spawnlist but never registered anywhere.

*sighs* What a relief! I hope this was the only rogue entity in this damn code base.

 

Thank you for all your help GotoLink!

<3

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.