Jump to content

[1.19.2] Teleporting player to custom dimension freezes the game on "Loading terrain..." but the /tp command still works


SparkyTD

Recommended Posts

I messing around with a "Dream" dimension where players get teleported when they go to bed. To detect sleeping time, I am subscribing to the SleepingTimeCheckEvent, and after the player's sleep tick reaches 100, I call entity.changeDimension() passing in my custom dimension as a parameter. After I go to bed and wait a couple seconds, the game switches over to the usual loading screen that says "Loading terrain...", but then it hangs there with no error messages or exceptions on the console (it just says "Saving and pausing game..."). As I understand, this sleep time event is server-sided, so this probably isn't a networking issue, and the teleportation itself should be handled automatically by Minecraft.

I know that the dimension itself works, because I can teleport there with the following command, and it loads in with no issues:

/execute in lunareclipse:sleep_dim run tp Dev ~ 120 ~

The weirdest thig is that the first time I tested this, the bed teleported me to my dimension successfully without freezing, or any other issues. I haven't changed anything in the teleportation code since, so I don't understand what's going on.

I've uploaded all the relevant files on pastebin:

I figured there is no point uploading a full debug.log, because as I mentioned, there are no error messages whatsoever, and the dimension itself works with vanilla teleport commands.

Link to comment
Share on other sites

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

7 minutes ago, warjort said:

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

I moved the teleportation logic over to the PlayerTickEvent, but it still freezes while loading the dimension. https://pastebin.com/7YRWiWpu

Link to comment
Share on other sites

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

6 minutes ago, warjort said:

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

Using ((ServerPlayer)event.player).teleportTo() works, thanks for the hint!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.