Jump to content

[1.19.2] Teleporting player to custom dimension freezes the game on "Loading terrain..." but the /tp command still works


SparkyTD

Recommended Posts

I messing around with a "Dream" dimension where players get teleported when they go to bed. To detect sleeping time, I am subscribing to the SleepingTimeCheckEvent, and after the player's sleep tick reaches 100, I call entity.changeDimension() passing in my custom dimension as a parameter. After I go to bed and wait a couple seconds, the game switches over to the usual loading screen that says "Loading terrain...", but then it hangs there with no error messages or exceptions on the console (it just says "Saving and pausing game..."). As I understand, this sleep time event is server-sided, so this probably isn't a networking issue, and the teleportation itself should be handled automatically by Minecraft.

I know that the dimension itself works, because I can teleport there with the following command, and it loads in with no issues:

/execute in lunareclipse:sleep_dim run tp Dev ~ 120 ~

The weirdest thig is that the first time I tested this, the bed teleported me to my dimension successfully without freezing, or any other issues. I haven't changed anything in the teleportation code since, so I don't understand what's going on.

I've uploaded all the relevant files on pastebin:

I figured there is no point uploading a full debug.log, because as I mentioned, there are no error messages whatsoever, and the dimension itself works with vanilla teleport commands.

Link to comment
Share on other sites

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

7 minutes ago, warjort said:

I don't think you should be using arbitrary code in an event that is obviously a policy decision callback. i.e. It's not meant to have side-effects

Look at the code that follows that event in ServerPlayer.startSleepingInBed() and see what code you will break by moving the player to a different dimension.

e.g. updating the sleeping players in the wrong dimension

 

A safer place to do that teleport code is in your own PlayerTickEvent handler.

handleNetherPortal() which also calls Entity.changeDimension() is called from Entity.baseTick()

I moved the teleportation logic over to the PlayerTickEvent, but it still freezes while loading the dimension. https://pastebin.com/7YRWiWpu

Link to comment
Share on other sites

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

6 minutes ago, warjort said:

I don't know then, it's not my area of expertise.

Most likely it has something to do with changeDimension() being for vanilla dimensions that have "portals" or for dimensions that are already loaded?

Look at TeleportCommand.performTeleport() which uses different code.

Using ((ServerPlayer)event.player).teleportTo() works, thanks for the hint!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Maybe your file codes are missing. Therefore it is crashing.
    • I've been trying to make a mod pack for the last day or so now and I haven't been able to launch it once even with all mods disabled. It keeps showing up with Exit Code 1. I gave the modpack to a friend to try and it didn't launch on their pc either due to the same exit code, so I'm not entirely certain what the problem is or how to check it in the logs. So far I've attempted: - Changing from forge version 43.3.0 to 43.3.5 - Downloading Java - Disabling mods (both entirely and individually) I have an NVIDIA GeForce GTX 1070 driver, and I haven't tried to uninstall or reinstall it yet because I'm not certain how to and would have to mess anything up further. I have the latest .txt file of the crash report here: [16:24:34] [main/WARN]: Failed to add PDH Counter: \Paging File(_Total)\% Usage, Error code: 0xC0000BB8 [16:24:34] [main/WARN]: Failed to add counter for PDH counter: \Paging File(_Total)\% Usage [16:24:34] [main/WARN]: Disabling further attempts to query Paging File. [16:24:36] [main/WARN]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile [16:24:39] [Datafixer Bootstrap/INFO]: 198 Datafixer optimizations took 149 milliseconds [16:24:40] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD] [16:24:40] [Render thread/INFO]: Setting user: CatDoodlee [16:24:41] [Render thread/INFO]: Backend library: LWJGL version 3.3.2+13 [16:24:42] [Render thread/INFO]: Reloading ResourceManager: vanilla [16:24:42] [Worker-Main-11/INFO]: Found unifont_all_no_pua-15.1.04.hex, loading [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [16:24:44] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Speakers (Atrix Wired Elite Headset) [16:24:44] [Render thread/INFO]: Sound engine started [16:24:44] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas [16:24:44] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [16:24:45] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [16:24:45] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas [16:24:45] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [16:24:45] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [16:24:45] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas [16:25:41] [Render thread/INFO]: Stopping! any form of help is greatly appreciated ❤️
    • Tanks for answer, I added SleepTight and I removed Modernfix, but it still crashing: new log new crash log
    • Hi, I'm trying to hide specific vanilla effects such as levitation or slow falling from the inventory GUI, but I haven't been able to figure out how to do this. I need this because they are triggered by another effect and I don't need them all showing up. Unfortunately, I don't know of any mods that include this feature, and I couldn't find any documentation on the process. I've already looked into the IClientMobEffectExtensions interface, but I'm uncertain about how to implement it in my own effect, let alone in any existing vanilla effect. Please help I am using Forge 47.2.0. for Minecraft 1.20.1
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.