Problem with a self filling fluid capability item

[nexoner]

I'm currently trying to make an item that fills itself with fluid when clicked on entities, all the capability stuff works, the item works with tanks and whatnot, but I can't get it to fill itself for some reason, any help'd be appreciated

    @Override
    public InteractionResult interactLivingEntity(ItemStack pStack, Player pPlayer, LivingEntity pInteractionTarget, InteractionHand pUsedHand) {
        if (pInteractionTarget instanceof WitherSkeleton){
            WitherSkeleton entity = (WitherSkeleton) pInteractionTarget;

            pStack.getCapability(CapabilityFluidHandler.FLUID_HANDLER_ITEM_CAPABILITY).ifPresent(handler ->{
                handler.fill(new FluidStack(Fluids.WATER,500), IFluidHandler.FluidAction.EXECUTE);
            });

            spawnParticles(pPlayer.getLevel(),entity.getOnPos());
            entity.remove(Entity.RemovalReason.KILLED);
            return InteractionResult.SUCCESS;
        }
        return InteractionResult.FAIL;

    }

 

[warjort]

Look at DyeItem.interactLivingEntity() or one of the other vanilla items for the correct pattern.

In particular pay attention to the use of isClientSide/sidedSuccess().

I think your code only modifies the capability on the client?

Edited October 10, 2022 by warjort

[nexoner]

That makes a lot of sense, thanks

[nexoner]

So, when looking back at it, the problem seems to not be related with client side problems, I've tested with other things that require server side, I've added client side checks, and this still doesn't seem to work for some reason, only draining and filling of the tank are disfunctional