[SOLVED] 1.19.2 problems with access transformers

[Kosh]

Hello. I'm trying to update my mod from 1.12.2 to 1.19.2. Some work already done, but I got a few errors.

One of the problematic thing is a private inner classes which were transformed to protected(Wolf.WolfPanicGoal and Wolf.WolfAvoidEntityGoal).

When I run it in an ide all goes well, but when I built a mod jar and tried to test as mod I've got an error:

java.lang.IllegalAccessError: failed to access class net.minecraft.world.entity.animal.Wolf$WolfPanicGoal from class sophisticated_wolves.entity.SophisticatedWolf (net.minecraft.world.entity.animal.Wolf$WolfPanicGoal is in module minecraft@1.19.2 of loader 'TRANSFORMER' @5478ce1e; sophisticated_wolves.entity.SophisticatedWolf is in module sophisticated_wolves@4.0.0b of loader 'TRANSFORMER' @5478ce1e)

full crash log:

https://gist.github.com/NightKosh/2a9c7239da0f26372c144f007faa6b91

My accesstransformer.cfg file:

https://github.com/NightKosh/Sophisticated-wolves/blob/feature/1.19.2_update/src/main/resources/META-INF/accesstransformer.cfg

And here is a link on a line of code, which is crashed:

https://github.com/NightKosh/Sophisticated-wolves/blob/feature/1.19.2_update/src/main/java/sophisticated_wolves/entity/SophisticatedWolf.java#L87

Edited November 2, 2022 by Kosh

[warjort]

Your project doesn't build for me.

Issues with old class names, e.g. in https://github.com/NightKosh/Sophisticated-wolves/blob/feature/1.19.2_update/src/main/java/sophisticated_wolves/SWGui.java

So I don't think the thing you have on github is what you are testing.

 

First thing to check is whether the META-INF/accesstransformer.cfg is actually in the mod jar? i.e. you are not filtering it out somehow.

You should also post the full logs/debug.log

Edited November 1, 2022 by warjort

[Kosh]

  On 11/1/2022 at 1:00 PM, warjort said:

Your project doesn't build for me.

Expand  

Some things still not updated, so such of them weren't commited yet.

logs/latest.log file - https://gist.github.com/NightKosh/3b5695800f46d467dc9bd73b2312aca4

Accsess transformer file in mod jar

 

[warjort]

I think you need to update your project so we can see what you are really doing.

I just tried simulating what you are doing with your access transformer and it doesn't even compile for me (each class below is in different packages)

public class TestA { // Wolf
    protected class Inner {} // WolfPanicGoal
}
public class TestB extends TestA { // Your api class
}
public class TestC extends TestB { // Your implementation
    public Inner test() {
        return new Inner(); // Compiler says not visible
    }
}

If I change the Inner class to public it does compile.

But you have protected in your accesstransformer.cfg

[Kosh]

  On 11/1/2022 at 7:29 PM, warjort said:

I think you need to update your project so we can see what you are really doing.

Expand  

Ok. I've done. Not completelly. At least there should be no broken files in repository.

Sources: https://github.com/NightKosh/Sophisticated-wolves/tree/1.19.2

I use git submodules for mod API, so look at readme.md file to read about it

jar file https://github.com/NightKosh/Sophisticated-wolves/releases/tag/1.19.2

[warjort]

Interesting.

So my simple test above compiles if I add a public constructor to the Inner class.

What is actually happening is the compiler is "cheating". When I look at the byte code, it is making that Inner class public not protected as it says in the source.

 

I guess forge's runtime access transformer code doesn't do the same cheat, which is why it is not working.

 

If I change your access transformer to use public instead of protected for those inner classes then obviously there is no crash.

[Kosh]

  On 11/2/2022 at 1:02 AM, warjort said:

Interesting.

So my simple test above compiles if I add a public constructor to the Inner class.

What is actually happening is the compiler is "cheating". When I look at the byte code, it is making that Inner class public not protected as it says in the source.

 

I guess forge's runtime access transformer code doesn't do the same cheat, which is why it is not working.

 

If I change your access transformer to use public instead of protected for those inner classes then obviously there is no crash.

Expand  

Thank you very much!