[1.19.2] Generation of tree not working as expected

[Maciej916]

Hello I'm having problems with three generations on the 1.19.2. Basically the tree has the proper blockstates and look when it is growth from sapling but when it comes to worldgen it have the shape and look like standard oak tree and all of them looks the same. Here is what im talking about:

 

This is how the tree should looks like and how it looks when it is growth from sapling:

 

And this is how it looks like in worldgen:

 

It used to work in 1.18.2 but after I updated to 1.19.2 it started to behave like this.

Here is my tree classes: https://github.com/Maciej916/Industrial-Reborn/tree/1.19/src/main/java/com/maciej916/indreb/common/world/feature/tree

And the configured futures and placed futures: https://github.com/Maciej916/Industrial-Reborn/blob/1.19/src/main/java/com/maciej916/indreb/common/world/feature/ModConfiguredFeatures.java https://github.com/Maciej916/Industrial-Reborn/blob/1.19/src/main/java/com/maciej916/indreb/common/world/feature/ModPlacedFeatures.java

And biome modifiers: https://github.com/Maciej916/Industrial-Reborn/tree/1.19/src/main/resources/data/indreb/forge/biome_modifier

 

Can someone help me with that I probably missed something.

Edited November 2, 2022 by Maciej916

[warjort]

I don't know much about trees, but I had a quick look at your links.

I noticed you have.

https://github.com/Maciej916/Industrial-Reborn/blob/260eec5ce4635c982c77eb34a5c155e62367d0af/src/main/resources/data/indreb/forge/biome_modifier/add_rubber_tree_rich.json#L3

There is no #minecraft:swamp biome tag. There is a normal biome (remove the #) or a #forge:is_swamp biome tag.

I couldn't see anything else obviously wrong.

[Maciej916]

3 hours ago, warjort said:

I don't know much about trees, but I had a quick look at your links.

I noticed you have.

https://github.com/Maciej916/Industrial-Reborn/blob/260eec5ce4635c982c77eb34a5c155e62367d0af/src/main/resources/data/indreb/forge/biome_modifier/add_rubber_tree_rich.json#L3

There is no #minecraft:swamp biome tag. There is a normal biome (remove the #) or a #forge:is_swamp biome tag.

I couldn't see anything else obviously wrong.

Thank you, I will update the tag but the issue i have is still valid.

Btw is there list of available tags in documentation?

[warjort]

For Tags, just look at the source code, e.g. vanilla's BiomeTags or forge's Tags.Biomes

The default contents are in the datagen classes BiomeTagsProvider and ForgeBiomesTagProvider

 

For your issue, I don't know.

If it were me, I would copy the TreeFeature class and register my own Feature. Then use that in my ConfiguredFeature(s).

That way I could debug it (break points or logging) without vanilla tree generation making a lot of noise.

Edited November 2, 2022 by warjort