[1.19] Refresh Villager Trades

[HutchCS]

Hello all, I am trying to make a villager refresh mod, it is supposed to be able to refresh the most recent trade if it has not been traded with at that level. I am able to refresh the trades at level 1 by simply setting them as null and they auto regenerate, but for the later levels, that does not suffice, I was able to separate the MerchantOffers at the new trade (meaning if level three, it has the 4 trades from level 1 and 2 as one MerchantOffers, but the level 3 trades are a separate MerchantOffers). I have not been able to successfully regenerate new trades to replace for that final level. Any ideas?

[warjort]

If you look at AbstractVillager.getOffers() it will only regenerate the trades if the offers field is null.

It does this by calling updateTrades().

But if you look in that method it calls addOffersFromItemListing() with a maximum of 2.

So, it will only ever create 2 trades.

 

You could use an access transformer to make the Villager.updateTrades() method public.

https://forge.gemwire.uk/wiki/Access_Transformers

Then call it multiple times to fill all the levels for the villager?

 

[HutchCS]

On 11/11/2022 at 3:17 PM, warjort said:

If you look at AbstractVillager.getOffers() it will only regenerate the trades if the offers field is null.

It does this by calling updateTrades().

But if you look in that method it calls addOffersFromItemListing() with a maximum of 2.

So, it will only ever create 2 trades.

 

You could use an access transformer to make the Villager.updateTrades() method public.

https://forge.gemwire.uk/wiki/Access_Transformers

Then call it multiple times to fill all the levels for the villager?

 

I didnt end up using the access transformer as I wasn't able to find the proper srg name for the updateTrades method even though i copied the same one used https://github.com/Favouriteless/SeasonalVillagers/blob/main/src/main/resources/META-INF/accesstransformer.cfg in this mod, but whatever. I was however able to get new trades through copying the old villager data into a new villagerdata variable, this will give me new trades (tested using println, I can see the result and costA and costB are different), but it wont update in the Villager GUI