Jump to content

Save villager offers as Items


Recommended Posts

I'm trying to save all offers of a villager on Items with a MerchantOffer property. I wrote a function to convert a MerchantOffers-object to and ItemStack[]:

public ItemStack[] generateOfferItems(MerchantOffers offers){
    ItemStack[] stacks = new ItemStack[offers.size()];
    for(int i = 0; i < offers.size(); i++){
        OfferItem offerItem = new OfferItem(offers.get(i));
        stacks[i] = new ItemStack(offerItem,1);
    return stacks;

That's my OfferItem-class:

public class OfferItem extends Item {

    public MerchantOffer offer = null;

    public OfferItem() {
        super(new Item.Properties().tab(ModCreativeModeTab.TEST_TAB).stacksTo(1));

    public OfferItem(MerchantOffer offer){
        super(new Item.Properties().tab(ModCreativeModeTab.TEST_TAB).stacksTo(1));
        this.offer = offer;

But the problem is that in "OfferItem offerItem = new OfferItem(offers.get(i));" the game crashes with this error: "Registry is already frozen".

The exception was thrown in the "guardEntityTick"-function of the Level.java file.

Link to comment
Share on other sites

You don't create items at runtime.

If you created a new Item on a server during the game, how would all the clients know what this item means?


ItemStacks hold the instance data of items.

You need one OfferItem and then add to the NBT of the ItemStack by creating your own tag. ItemStack.getOrCreateTag() -

Usually you use your modid as the top level element name to avoid collisions.

MerchantOffer already has createTag() method to get it in NBT form.

If you want examples, research how enchantments are stored in ItemStacks.


If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.