1.19.2 can't detroy/remove water

[Daziel]

I tried to make a projectile that put water on nearby it falls. I just need that water source pop and directly disapear. I do :

Spoiler

@Override
	public void onHitBlock(BlockHitResult blockHitResult) {
		super.onHitBlock(blockHitResult);
		if (level instanceof ServerLevel _level){
			FallingBlockEntity waterfall =	FallingBlockEntity.fall(_level, new BlockPos(blockHitResult.getBlockPos().getX(), blockHitResult.getBlockPos().getY()+1, blockHitResult.getBlockPos().getZ()),
						Blocks.WATER.defaultBlockState());
			System.out.println("HI " + waterfall.getBlockX() + waterfall.getBlockY() + waterfall.getBlockZ());
			if ((_level.getFluidState(new BlockPos(waterfall.getBlockX(), waterfall.getBlockY(), waterfall.getBlockZ())).createLegacyBlock()).getFluidState().isSource()) {
				System.out.println("I M WATER");
				_level.removeBlock(new BlockPos(waterfall.getBlockX(), waterfall.getBlockY(), waterfall.getBlockZ()),false);
				_level.destroyBlock(new BlockPos(waterfall.getBlockX(), waterfall.getBlockY(), waterfall.getBlockZ()),false);
			}
			if ((_level.getFluidState(new BlockPos(waterfall.getBlockX(), waterfall.getBlockY(), waterfall.getBlockZ())).createLegacyBlock()).getFluidState().isSource()) {
				System.out.println("I M STILL WATER");
			}
		}
	}

 

Water appears but still remains despite removeBlock or DestroyBlock. Any idea ?

[warjort]

remove/destroyBlock() don't remove the fluid . Did you look at the code?

 

Those methods are intended for things like breaking a waterlogged fence post.

It will remove the post but leave the water behind.

 

Try doing something like:

Level.setBlockAndUpdate(pos, Blocks.AIR.defaultState());

[Daziel]

Doesn't work 😞  Water still there.

But if i use Blocks.STONE.defaultBlockState()  ...  it works and change the source water by a Stone block immediately.
I have tried to look inside BucketItem to look how it works when bucket is used but i don't understand how water disappear and is replaced by air on targeting pos 😞

[warjort]

That effectively uses LiquidBlock.pickupBlock() - assuming you are dealing with a LiquidBlock?

That calls setBlock() with flags = 11 while setBlockAndUpdate() calls setBlock() with flags = 3

Which means it is setting the "UPDATE_IMMEDIATE" flag as well - see the Block class.

I don't know what difference that makes? It's not a flag I am familiar with.

Edited December 5, 2022 by warjort

[warjort]

You know when you create a falling block the actual fall will be delayed to later processing?

So, it could be you are setting the block to air, then on a later tick the block is failling and creating the source block.

Setting the block to stone would likely stop the falling block from creating the source block? Probably it tries to spawn the ItemEntity drop for water which doesn't have one.

Edited December 5, 2022 by warjort