Button Widget not working

[Hypericats]

Hi, so I am new to modding and I have been making my first mod with some basic hacks like fly. However, while trying to add button widgets to the Save and exit/disconnect screen the Button Widget is highlighted red and gives me an error.  There is not much information about why but I have spent 5 hours trying to fix this and I don't know what to do anymore. I think it once said something about the ButtonWidget class being protected but that didn't really help me. I was using a tutorial to learn to do this and I think I had the exact same code (With different names) I followed it word for word and checked everything. I'm using fabric 1.19.3.

package net.hypericats.hyperionclient.mixin;


import net.hypericats.hyperionclient.HyperionClientModuleScreen;
import net.minecraft.client.gui.screen.GameMenuScreen;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.text.Text;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;


@Mixin(GameMenuScreen.class)
public abstract class GameMenuButtonsMixin extends Screen {
    protected GameMenuButtonsMixin(Text text) { super(text); }

    @Inject(at = @At("HEAD"), method = "initWidgets", require = 1)
    void initWidgets(CallbackInfo ci) {
        assert this.client != null;
        this.addDrawableChild(new ButtonWidget(10, 10, 90, 20, Text.literal("Hyperion Client Modules"),
                btn -> {this.client.setScreen(new HyperionClientModuleScreen(this, this.client.options));
        }));
    }
}

This is my Mixin class for the buttons

package net.hypericats.hyperionclient;

import net.hypericats.hyperionclient.event.KeyInputHandler;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.ButtonWidget;
import net.minecraft.client.option.GameOptions;
import net.minecraft.screen.ScreenTexts;
import net.minecraft.text.Text;


public class HyperionClientModuleScreen extends Screen {

    private final Screen parent;
    private final GameOptions settings;

    public HyperionClientModuleScreen(Screen parent, GameOptions gameOptions) {
        super(Text.literal("Hyperion Client Modules"));
        this.parent = parent;
        this.settings = gameOptions;
    }

    Text flyHackText() {
       if(KeyInputHandler.FlyHax) {
           return Text.literal("Flying is enabled");
       } else {
           return Text.literal("Flying is disabled");
       }
    }

        protected void init() {

            assert this.client != null;
            this.addDrawableChild(new ButtonWidget(10, 10, 90, 20, flyHackText(), (btn) -> {
                KeyInputHandler.FlyHax = !KeyInputHandler.FlyHax;
                btn.setMessage(flyHackText());
            }));

            this.addDrawableChild(new ButtonWidget(10, this.height - 10, 90, 20, ScreenTexts.BACK, (btn) -> this.client.setScreen(this.parent)));
        }
}

And this is the screen referenced in the mixin.

Also while running the client I get this error:

 class ButtonWidget cannot be applied to given types;
            this.addDrawableChild(new ButtonWidget(10, 10, 90, 20, flyHackText(), (btn) -> {
                                  ^
  required: int,int,int,int,Text,PressAction,NarrationSupplier
  found:    int,int,int,int,Text,(btn)->{ K[...])); }
  reason: actual and formal argument lists differ in length

I looked it up and it seems I missing something (Narraration supplier?) but I think that's not needed. I also tried adding some in but it didn't work, unless I did it wrong?

[Hypericats]

Is there maybe another way to make buttons?

Edited December 12, 2022 by Hypericats

[warjort]

Neither mixins or your version of minecraft is supported in these forums.

 

But there is another way (the following shows adding a button to the inventory screen in  modern supported versions of minecraft)

https://forums.minecraftforge.net/topic/117992-tooltip-depth/#comment-519260

[Jontom Xire]

You're a hero, Warjort...again.

I was having a similar problem with the Button class and could not find anything about the CreateNarration parameter that the compiled was complaining of as missing.

[Jontom Xire]

I take it back - it still doesn't work for me.

 

Using Minecraft 1.19.3 and the equivalent Forge, and this code:

        addRenderableWidget(new Button((m_slider_x + SLIDER_WIDTH - SPEND_WIDTH),
                                       (grid_y + (ROW_HEIGHT * (PlayerData.STAT_COUNT + 1))),
                                       SPEND_WIDTH,
                                       SPEND_HEIGHT,
                                       Component.translatable("stats_and_skills.spend_label"),
                                       this::onSpend));

I get this error:

    constructor Button.Button(int,int,int,int,Component,OnPress,CreateNarration) is not applicable

 

What is "CreateNarration" exactly? The Button constructor seems to need another parameter that is a Lamda/function that returns a MutableComponent, but I cannot figure out the parameter list for the lambda.

[Jontom Xire]

Oh this is painful. This compiles, not sure if it works yet:

 

        addRenderableWidget(new SpendButton((m_slider_x + SLIDER_WIDTH - SPEND_WIDTH),
                                            (grid_y + (ROW_HEIGHT * (PlayerData.STAT_COUNT + 1)))));

...

    public class SpendButton extends Button
    {
        public SpendButton(int x, int y)
        {
            super(x,
                  y,
                  SPEND_WIDTH,
                  SPEND_HEIGHT,
                  Component.translatable("stats_and_skills.spend_label"),
                  (button) -> { onSpend(); },
                  (button) -> { return Component.translatable("stats_and_skills.spend_label"); });
        }
    }

 

[Hypericats]

@Jontom Xire I noticed something similar where it asked for the narration but I couldn’t find what to put there. I still haven’t figured it out but I saw that apparently there was a another version of the function that didn’t have any narration but the compiler didn’t seem to know it existed. Lmk if the addRenderableWidget worked or if you found another solution.

[Jontom Xire]

@Hypericats Sorry for the late reply.

 

The code I quoted above is what I used in the end.

 

[Hypericats]

Hi, I managed to figure it out. I didn’t end up using Jontom’s code, I used a simpler method. I hadn’t realized this at first but my solution was just to go in minecraft’s code and read how the button widget was implemented. For any future readers, you can probably copy and paste the code from minecraft’s code in the options file under the gui. The code was similar to what I first posted but used something like “.builder” and “build()” at the end. This was the solution for minecraft 1.19.3 fabric but you could probably use the same steps for future versions.