Get player's dimension

[Roland]

Hello. I'm writing anti-griefing mod. I'm trying to find out in what kind of dimension player currently is. My code sample (just to show that I have ServerPlayer instance and nothing more):

public void onServerTick(TickEvent.ServerTickEvent event) throws SQLException {
    List<ServerPlayer> pl = ServerLifecycleHooks.getCurrentServer().getPlayerList().getPlayers();
    for (ServerPlayer player : pl) {
        // How to get player's dimension??? player.getDimension() not exist

MC version is 1.19.2. Help, please.

Edited January 16, 2023 by Roland

[warjort]

This is like minecraft 101.

player.level

Or if you really want what mojang calls the dimension (its registry name)

player.level.dimension()

e.g. Level.OVERWORLD

 

Also,

* If you throw SQLException from that event it will crash the game

* You should check event.haveTime() to see if the server is running slow before doing intense processing (like querying an SQL database)

* There is event.getServer() in 1.19

* All TickEvents are called twice per tick. You need to check event.phase (start or end) to avoid doing it twice per tick

[Roland]

  On 1/16/2023 at 9:50 AM, warjort said:

This is like minecraft 101.

player.level

Or if you really want what mojang calls the dimension (its registry name)

player.level.dimension()

e.g. Level.OVERWORLD

Expand  

Thank you! But I need integer representation of current dimention. Because I want to put it to database as integer. BTW, I have tried the following with not result. I miss something simple, because I have no idea what are "ResourceKey", "ResourceLocation" and so on. And why they are implemented.

LOGGER.info(String.valueOf(player.level.dimension()));
// Log:
// ResourceKey[minecraft:dimension / minecraft:overworld]

LOGGER.info(String.valueOf(Level.OVERWORLD));
// Log:
// ResourceKey[minecraft:dimension / minecraft:overworld]

LOGGER.info(String.valueOf(player.level.dimensionTypeId()));
// Log:
// ResourceKey[minecraft:dimension_type / minecraft:overworld]

LOGGER.info(String.valueOf(player.level.dimensionType()));
// Log:
// DimensionType[fixedTime=OptionalLong.empty, hasSkyLight=true, hasCeiling=false, ultraWarm=false, natural=true, coordinateScale=1.0, bedWorks=true, respawnAnchorWorks=false, minY=-64, height=384, logicalHeight=384, infiniburn=TagKey[minecraft:block / minecraft:infiniburn_overworld], effectsLocation=minecraft:overworld, ambientLight=0.0, monsterSettings=MonsterSettings[piglinSafe=false, hasRaids=true, monsterSpawnLightTest=[0-7], monsterSpawnBlockLightLimit=0]]

LOGGER.info(String.valueOf(player.level.dimension() == Level.OVERWORLD));
// Log:
// true

Added later: My guess is that the dimension is stored as an enum somewhere. And so I can get its numeric representation. Seems I'm wrong...

  On 1/16/2023 at 9:50 AM, warjort said:

* If you throw SQLException from that event it will crash the game

Expand  

Yes, I know. Already, haha. It's okay for now.

  On 1/16/2023 at 9:50 AM, warjort said:

* You should check event.haveTime() to see if the server is running slow before doing intense processing (like querying an SQL database)

Expand  

Very interesting! But if tick is gone it will never repeat... And if I want to write some kind of logger... Well. Do I need to create new threads with SQL-insert-queries? The reason is: I _need_ to write some data to database exactly when it happened and never-never-never skip writing operations. I think MineCraft hasn't things like queues?

  On 1/16/2023 at 9:50 AM, warjort said:

* There is event.getServer() in 1.19

Expand  

Thank you! I'm new in modding. Any information is useful. Does Forge community has some guides may be? I google every time I need something. It's not the best way to learn something new. And to code correctly.

  On 1/16/2023 at 9:50 AM, warjort said:

* All TickEvents are called twice per tick. You need to check event.phase (start or end) to avoid doing it twice per tick

Expand  

Oh, thank you, sir! That's why I wondering how it work twice a time... I'll fix it right now.

Edited January 16, 2023 by Roland

[warjort]

There hasn't been a numeric representation of dimensions since 1.12

[Roland]

  On 1/16/2023 at 2:31 PM, warjort said:

There hasn't been a numeric representation of dimensions since 1.12

Expand  

Strings only? Okay, thanks, now I got it.

[Roland]

  On 1/16/2023 at 2:31 PM, warjort said:

There hasn't been a numeric representation of dimensions since 1.12

Expand  

Sorry for wasting your time. My last question (in this thread, haha). 

Is that okay approach for Minecraft mods? It this approach okay for mod development?

// Somewhere in main Mod class (marked as @Mod):
(new LogThread()).start();

// Thread class (example with SQL insert query):
public class LogThread extends Thread {
    public void run() {
        try {
            db.createStatement().executeUpdate("INSERT INTO ...");
        } catch (Exception e) {
            // ...
        }
    }
}

 

[warjort]

You can start a new thread If you know what you are doing.

But Minecraft is not designed to be used concurrently, except in a very few specific places. There is only one main client and server thread..

If you start using datastructures that are not designed to be accessed concurrently you are at best going to see inconsistent data,

at worst you will get exceptions (NPEs, ConcurrentModification on iterators, etc.) due to incorrect concurrent access.

e.g. https://bugs.mojang.com/browse/MC-258939

Edited January 16, 2023 by warjort

[Roland]

  On 1/16/2023 at 3:24 PM, warjort said:

You can start a new thread If you know what you are doing.

But Minecraft is not designed to be used concurrently, except in a very few specific places. There is only one main client and server thread..

If you start using datastructures that are not designed to be accessed concurrently you are at best going to see inconsistent data,

at worst you will get exceptions (NPEs, ConcurrentModification on iterators, etc.) due to incorrect concurrent access.

e.g. https://bugs.mojang.com/browse/MC-258939

Expand  

I understand. There is no need in any state for logger for now. Thank you for answering!