OnDeath

[ashtonr12]

i have made an event that spawns a modified zombie, potion effects items, etc.

and i have seen that there is the forgehook onlivingdeath and in the zombie class there is an ondeath event, bu i cant seem to figure out how to use them.

 

i want check (from a seperate class that the zombie is created from) that the zombie is dead before i allow somthing, how would i do this? nbt's?

[GotoLink]

With the LivingDeathEvent:

if(event.entityLiving instanceof EntityZombie)//allows subclass of EntityZombie

or

if(event.entityLiving.getClass() == EntityZombie.class)//more specific

[ashtonr12]

but do these distinguish between zombie next door and specially summoned zombie?

[GotoLink]

You can add data to the zombies with IExtendedEntityProperties, then check for it in this event.

[ashtonr12]

couldnt i try and get the custom zombies custom name? and use that to check hes the right one?

[ashtonr12]

ok so have done it with the custom name and it seems to work but i cant get the names to match up, in one class i have "entityZombie.setCustomNameTag("Mythical"+name2+name1);"

and name1 and name2 and random names.

and in my onDeath event i have "x = entityzombie.getCustomNameTag();

if(x == ("Mythical"+CriticalStrike.common.summoningStone.name2+CriticalStrike.common.summoningStone.name1)){

but it doesnt work, i have checked that the event is working i just cant seem to get the zombie? oh and x is a typical string just btw.

[GotoLink]

Use .equals(obj)

[ashtonr12]

Thanks...

 

Where

.

.

.

and for future reference what does that do?

[WorldsEnder]

String comparison is not like it would first seem it would be. There can be two different String objects although both Strings could contain "Hello". This is like any other object, two objects with the same properties but they are not the same object (which would mean that they are stored at the same location in RAM, etc.). .equals is designed for that specifique case where you have two objects that have the same properties and somehow the user should know that (he can't know about private fields). So the mthod .equals in String is designed for the case that both Strings contain the same charsequence but are not really the same object. .equals return true in this case, == doesn't.

 

PS: String has a method named .intern(). All Strings charsequences are stored in an String-class intern list with exactly one String object as reference. Calling .intern() returns exactly that String object meaning that if you use this before comparing two string containing the same char** with ==, the operation would return true.

Example: x.intern() == ("Mythical"+CriticalStrike.common.summoningStone.name2+CriticalStrike.common.summoningStone.name1).intern().

 

PSS: All strings you literally type in like "Mythical" are automatically intern, this is why normally == would succeed. A random charsqeunce-generator though normally returns a new String-object, not the .intern() one.

 

PSSS: Use .equals() instead of .intern() twice, code style.

[ashtonr12]

Error

A detailed walkthrough of the error, its code path and all known details is as follows:
2013-09-12 21:12:10 [iNFO] [sTDOUT] ---------------------------------------------------------------------------------------
2013-09-12 21:12:10 [iNFO] [sTDOUT] 
2013-09-12 21:12:10 [iNFO] [sTDOUT] -- Head --
2013-09-12 21:12:10 [iNFO] [sTDOUT] Stacktrace:
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at CriticalStrike.common.CriticalStrikeMain.onDeath(CriticalStrikeMain.java:190)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraftforge.event.ASMEventHandler_5_CriticalStrikeMain_onDeath_LivingDeathEvent.invoke(.dynamic)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraftforge.event.ASMEventHandler.invoke(ASMEventHandler.java:39)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraftforge.event.EventBus.post(EventBus.java:108)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraftforge.common.ForgeHooks.onLivingDeath(ForgeHooks.java:340)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.entity.EntityLivingBase.onDeath(EntityLivingBase.java:982)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.entity.EntityLivingBase.attackEntityFrom(EntityLivingBase.java:945)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.entity.monster.EntityMob.attackEntityFrom(EntityMob.java:72)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.entity.monster.EntityZombie.attackEntityFrom(EntityZombie.java:196)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.entity.player.EntityPlayer.attackTargetEntityWithCurrentItem(EntityPlayer.java:1362)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.network.NetServerHandler.handleUseEntity(NetServerHandler.java:845)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.network.packet.Packet7UseEntity.processPacket(Packet7UseEntity.java:57)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.network.MemoryConnection.processReadPackets(MemoryConnection.java:89)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.network.NetServerHandler.networkTick(NetServerHandler.java:141)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 
2013-09-12 21:12:10 [iNFO] [sTDOUT] -- Ticking connection --
2013-09-12 21:12:10 [iNFO] [sTDOUT] Details:
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Connection: net.minecraft.network.NetServerHandler@1f898a7
2013-09-12 21:12:10 [iNFO] [sTDOUT] Stacktrace:
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:54)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.integrated.IntegratedServerListenThread.networkTick(IntegratedServerListenThread.java:109)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:689)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:585)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:129)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 
2013-09-12 21:12:10 [iNFO] [sTDOUT] -- System Details --
2013-09-12 21:12:10 [iNFO] [sTDOUT] Details:
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Minecraft Version: 1.6.2
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Operating System: Windows 7 (x86) version 6.1
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Java Version: 1.7.0_07, Oracle Corporation
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Java VM Version: Java HotSpot(TM) Client VM (mixed mode), Oracle Corporation
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Memory: 914576744 bytes (872 MB) / 1046937600 bytes (998 MB) up to 1046937600 bytes (998 MB)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	AABB Pool Size: 2705 (151480 bytes; 0 MB) allocated, 2401 (134456 bytes; 0 MB) used
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Suspicious classes: FML and Forge are installed
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	IntCache: cache: 0, tcache: 0, allocated: 3, tallocated: 63
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	FML: MCP v8.04 FML v6.2.35.804 Minecraft Forge 9.10.0.804 4 mods loaded, 4 mods active
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	mcp{8.04} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	FML{6.2.35.804} [Forge Mod Loader] (coremods) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Forge{9.10.0.804} [Minecraft Forge] (coremods) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	criticalstrikemod{1.00} [Critical$trike] (bin) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Profiler Position: N/A (disabled)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Vec3 Pool Size: 919 (51464 bytes; 0 MB) allocated, 895 (50120 bytes; 0 MB) used
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Player Count: 1 / 8; [EntityPlayerMP['Player251'/232, l='New World', x=-48.91, y=66.11, z=233.33]]
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Type: Integrated Server (map_client.txt)
2013-09-12 21:12:10 [iNFO] [sTDOUT] 	Is Modded: Definitely; Client brand changed to 'fml,forge'
2013-09-12 21:12:10 [iNFO] [sTDOUT] #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\owner\Documents\Rob's Crap\Minecraft\CriticalStrikeModEclipse 1.62\forge\mcp\jars\.\crash-reports\crash-2013-09-12_21.12.10-server.txt
2013-09-12 21:12:10 [iNFO] [Minecraft-Server] Stopping server
2013-09-12 21:12:10 [iNFO] [Minecraft-Server] Saving players
2013-09-12 21:12:10 [iNFO] [Minecraft-Server] Saving worlds
2013-09-12 21:12:10 [iNFO] [Minecraft-Server] Saving chunks for level 'New World'/Overworld
AL lib: (EE) alc_cleanup: 1 device not closed

 

Code

@ForgeSubscribe
public void onDeath(LivingDeathEvent e){
	Entity killed = e.entity;
	Entity killer = e.source.getEntity();	
	EntityZombie entityzombie = new EntityZombie(e.entity.worldObj);
	if(killer instanceof EntityPlayer && !e.entity.worldObj.isRemote){
		if(e.entity instanceof EntityZombie){
		x.equals(entityzombie.getCustomNameTag());
		if(x.equals("§6§oMythical~§r"+CriticalStrike.common.summoningStone.name2+CriticalStrike.common.summoningStone.name1)){
			CriticalStrike.common.CriticalStrikeMain.hasSummoned = 0;
			System.out.println(CriticalStrike.common.CriticalStrikeMain.hasSummoned);
	}
		}}}

 

x.equals(entityzombie.getCustomNameTag()); is line 190

[GotoLink]

You are not doing anything with that line. It is a simple boolean.

I would think that x is not correct. (probably null)

[ashtonr12]

ok i am a moron is this better? no errors but it doesnt work...

 

event

@ForgeSubscribe
public void onDeath(LivingDeathEvent e){
	Entity killed = e.entity;
	Entity killer = e.source.getEntity();	
	EntityZombie entityzombie = new EntityZombie(e.entity.worldObj);
	if(killer instanceof EntityPlayer && !e.entity.worldObj.isRemote){
		if(e.entity instanceof EntityZombie){
		if(entityzombie.getCustomNameTag().equals("§6§oMythical~§r"+CriticalStrike.common.summoningStone.name2+CriticalStrike.common.summoningStone.name1)){
			CriticalStrike.common.CriticalStrikeMain.hasSummoned = 0;
	}
		}}}

 

spawning naming code

entityZombie.setCustomNameTag("§6§oMythical~§r"+name2+name1);