Coremod and ModContainers

[Taigore]

Hello, I'm Taigore.

I'm trying to make my mod turned coremod work again. The coremod part worked fine almost since when I added it. However, the rest of the mod refuses to get back working. I managed to, after a long time, get back working the blocks, items, textures and all mod class events, but I can't get the GUI on again. I spent a lot of time reading FML code and, from what I have seen, I can't find anything else not involving reflection to register the GUI. The usual NetworkRegistry method won't work, and it seems that the InjectedModContainer wrapping my mod (that gets automatically created) isn't registered at all in LoadController.modObjectList.

I attach both my IFMLLoadingPlugin implementation and my DummyModContainer extension, if anyone could help me pointing out what FML expects from me to be able to process my mod without resorting to crazy hacks I'd be grateful. Mind that the plugin is correctly identified and called, and the container has its events called, even though it took some effort and much exploration. I likely haven't used the "correct" method to make it work. I followed this guide for the most part, although the change I made is slightly more extensive.

 

InventorySaver (ModContainer)

 

  Reveal hidden contents

@NetworkMod
(
clientSideRequired=true,
serverSideRequired=false,
clientPacketHandlerSpec=@SidedPacketHandler
(
	packetHandler=PacketHandler.class,
	channels={Packet250DeathUpdate.channel}
)
)
public class InventorySaver extends DummyModContainer
{
    public static String getResourceId(String resourcePath) { return String.format("%s:%s", instance.getModId().toLowerCase(), resourcePath); }
    
public static InventorySaverBak instance;
public static Logger log;

public static ProxyCommon proxy = FMLCommonHandler.instance().getEffectiveSide() == Side.CLIENT ? new ProxyClient() : new ProxyCommon();

/////////////////
// Mod settings
/////////////////
private boolean enabled = true;
public ModSettings settings = null;

public InventorySaverBak()
{
    super(new ModMetadata());
    instance = this;
    FMLLog.makeLog("Inventory Saver");
    log = Logger.getLogger("Inventory Saver");
    
    ModMetadata meta = this.getMetadata();
    
        meta.modId = "Taigore_InventorySaver";
        meta.name = "Inventory Saver";
        meta.version = "3.2";
        meta.authorList = Arrays.asList(new String[] { "Taigore" });
        meta.description = "Modifies what happens at player's death, putting all their drops into a bag, that is not affected by item despawn time. No more mindless rushing!";
        meta.url = "www.minecraftforum.net/topic/1703327-152-taigores-inventory-saver-v3/";
        meta.credits = "A cute little mod by Taigore";
}

@Subscribe
public void configSetup(FMLPreInitializationEvent event)
{
    InventorySaverBak.log.info("Reading config file");
    
    this.settings = new ModSettings(new Configuration(event.getSuggestedConfigurationFile()), DebugLevel.MODSETTINGS);
    
    this.settings.init("Item:DeathCompass", null, 4000);
        this.settings.alias("Item:DeathCompass", "DeathCompassID");
        
        this.settings.init("Block:Bag", null, 300);
        this.settings.alias("Block:Bag", "BagBlockID");
    
    this.settings.init("Bag:ProtectLoot", "Prevents the bag from interacting with someone that's not the owner", false);
    this.settings.alias("Bag:ProtectLoot", "ProtectLoot");
    
    this.settings.init("Bag:Gravity", "If gravity affects the bag. If ProtectLoot is true, this is overridden as false", true);
    this.settings.alias("Bag:Gravity", "BagGravity");
    
    this.settings.init("Bag:IgnoreLava", "If true, the bag is unaffected by lava. If ProtectLoot is true, this is overridden as true", false);
    this.settings.alias("Bag:IgnoreLava", "IgnoreLava");
    
    this.settings.save();
}

///////////////////
// Items & Blocks
///////////////////
public BlockBag blockBag = null;

    public ItemDeathCompass itemDeathCompass = null;

@Subscribe
public void initialization(FMLInitializationEvent event)
{
    proxy.registerItems();
	proxy.registerBlocks();

	InventorySaverBak.log.info("Registering handlers");

	if(this.blockBag != null)
	    NetworkRegistry.instance().registerGuiHandler(this, new GuiHandler());

	if(this.blockBag != null || this.itemDeathCompass != null)
	    MinecraftForge.EVENT_BUS.register(new EventHandler());
}

@Subscribe
    public void modConstruction(FMLConstructionEvent evt)
    {
        try
        {
            NetworkModHandler ownNetworkHandler = new NetworkModHandler(this, InventorySaverBak.class.getAnnotation(NetworkMod.class));
            
            FMLNetworkHandler.instance().registerNetworkMod(ownNetworkHandler);
        }
        catch (Exception e)
        {
            FMLLog.log(Level.SEVERE, e, "MEH!");
        }
    }

/////////////////
// ModContainer
/////////////////
@Override
    public boolean registerBus(EventBus bus, LoadController controller)
    {
        if(this.enabled)
            bus.register(this);
        
        for (ModContainer mc : Loader.instance().getModList())
            if (((mc instanceof InjectedModContainer)) && (((InjectedModContainer)mc).wrappedContainer == this))
            {
                try
                {
                    Field f_source = InjectedModContainer.class.getDeclaredField("source");
                    f_source.setAccessible(true);
                    f_source.set(mc, FMLLoadingPlugin.location);
                }
                catch (Exception e)
                {
                    e.printStackTrace();
                    throw new RuntimeException(e);
                }
            }
        
        return this.enabled;
    }
@Override
public Class<?> getCustomResourcePackClass()
{
    try
    {
        return Class.forName("cpw.mods.fml.client.FMLFileResourcePack", true, getClass().getClassLoader());
    }
    catch (ClassNotFoundException e) {
    }
    return null;
}
@Override
public Object getMod() { return this; }
    @Override
    public boolean isNetworkMod() { return true; }
    @Override
    public void setEnabledState(boolean enabled) { this.enabled = enabled; }
}

 

 

FMLLoadingPlugin (Plugin class)

 

  Reveal hidden contents

@MCVersion("1.6.2")
@TransformerExclusions("taigore.inventorysaver.asm")
public class FMLLoadingPlugin implements IFMLLoadingPlugin
{
    static public File location;
    
    @Override
    public void injectData(Map<String, Object> data)
    {
        if (data.containsKey("coremodLocation"))
            location = (File)data.get("coremodLocation");
    }
    @Override
    public String[] getASMTransformerClass() { return new String[]{RenderFallingSandTransformer.class.getName()}; }
    @Override
    public String getModContainerClass() { return InventorySaver.class.getName(); }
    @Override
    public String getSetupClass() { return null; }
    @Override
    @Deprecated
    public String[] getLibraryRequestClass() { return null; }
}

 

 

Thanks in advance for the help.

[Taigore]

Thanks for the reply, but I'm actually using the coremod to modify the rendering of EntityFallingSand.

My block is not a standard cube, it's a detailed shape with a non square texture that I plan to make fall, so I'm modifying the renderer to use the actual block rendering for everything that uses a non standard one (even other mod blocks).

I could get the same result for my block by duplicating EntityFallingSand and adding a new renderer for it, that uses the block rendering, but it's redundant.

Even if you still think is better, I could still use to know what the problem with my mod is, in case I need it for future works.

[LexManos]

IF you have to write a coremod for something you can do without it...

You're doing it wrong.

Just because it's 'redundant' doesn't mean you're right.