[1.19.2] Creating a Boat?

[DakotaPride]

I've done this with fabric using a library but noticed that the classes related to Boats in Forge also handle it in a similar fashion, using an enum for boat types, making it harder to create a custom boat. Is there any documentation or anything that would help as a reference or guide to this?

[Hipposgrumm]

You can use BYG as a reference.

[DakotaPride]

4 hours ago, Hipposgrumm said:

You can use BYG as a reference.

Okay, after some time, I've got part of it working. The boats register as items, but I'm running into an issue when I try to place down the boat (regular and chest boats). Here's the crash report for this and here's the git repo (Forge) in case it may help.

[Hipposgrumm]

11 hours ago, DakotaPride said:

Here's the crash report for this and here's the git repo (Forge) in case it may help.

It's saying that an "entityrender" variable is null, check that. 

Funnily enough, I once played on a server where the BYG boats crashed the game and they had to make a rule where crafting BYG boats was not allowed, but that was in 1.16.5.

[DakotaPride]

2 hours ago, Hipposgrumm said:

It's saying that an "entityrender" variable is null, check that. 

Is there any easy way to check where this variable is located? As I have gone through the files and haven't found a null entityrender variable. Unless I'm just missing it somehow

Or do you know how BYG managed to fix their issue?

Edited March 16, 2023 by DakotaPride

[Hipposgrumm]

46 minutes ago, DakotaPride said:

Is there any easy way to check where this variable is located? As I have gone through the files and haven't found a null entityrender variable. Unless I'm just missing it somehow

You must check the shouldrender method in your renderer class. If you can't find it, try searching for it in the parent class (that minecraft has).

48 minutes ago, DakotaPride said:

Or do you know how BYG managed to fix their issue?

All I know is that BYG had a similar issue and it was with other mods. I didn't think to look at the crash report back then.

[DakotaPride]

1 hour ago, Hipposgrumm said:

You must check the shouldrender method in your renderer class. If you can't find it, try searching for it in the parent class (that minecraft has).

What exactly am I checking it for? (I know that I should check it since that seems to be where the problem is. However, the method doesn't seem to even have an entityrenderer variable inside of the parent class.) Again, I may just be missing something, sorry.

[Hipposgrumm]

16 hours ago, DakotaPride said:

here's the git repo (Forge)

I checked your code; instead of creating a new renderer for your boat, just extend the original BoatRenderer class.

[DakotaPride]

10 minutes ago, Hipposgrumm said:

 just extend the original BoatRenderer class.

Still comes out with the same crash report sadly. I think I may just wait until 1.20 releases and see if there are any more effective ways of doing this or any new documentation/guides (would've liked it to be sooner, but can't really control that)

[Hipposgrumm]

2 minutes ago, DakotaPride said:

Still comes out with the same crash report sadly.

Can you update the github page so that I can see?

[DakotaPride]

2 minutes ago, Hipposgrumm said:

Can you update the github page so that I can see?

done

[Hipposgrumm]

14 minutes ago, DakotaPride said:

Still comes out with the same crash report sadly.

Can you send the crash report? It might not be completely identical.

[DakotaPride]

10 minutes ago, Hipposgrumm said:

Can you send the crash report? It might not be completely identical.

Most recent crash report

[warjort]

https://github.com/DakotaPride/Hibernal-Herbs/blob/master/Forge/src/main/java/net/dakotapride/hibernalHerbs/client/render/HibernalEntityRenderers.java

Your EntityRenderer doesn't get registered.

The correct way to do it is to use the EntityRenderersEvent.RegisterRenderers event:

https://github.com/MinecraftForge/MinecraftForge/blob/31e73355c310430ce1816009895b3eff1b5f5fc4/src/main/java/net/minecraftforge/client/event/EntityRenderersEvent.java#L94

It gets fired on the MOD event bus.

[DakotaPride]

On 3/16/2023 at 3:50 PM, warjort said:

https://github.com/DakotaPride/Hibernal-Herbs/blob/master/Forge/src/main/java/net/dakotapride/hibernalHerbs/client/render/HibernalEntityRenderers.java

Your EntityRenderer doesn't get registered.

The correct way to do it is to use the EntityRenderersEvent.RegisterRenderers event:

https://github.com/MinecraftForge/MinecraftForge/blob/31e73355c310430ce1816009895b3eff1b5f5fc4/src/main/java/net/minecraftforge/client/event/EntityRenderersEvent.java#L94

It gets fired on the MOD event bus.

Is there any examples of how this is used? I've never really used events before, so I'm not sure how I would get started with this. (sidenote, sorry for the long reply. Have been having Pc issues for the past couple of days)

[warjort]

https://forge.gemwire.uk/wiki/Events

 

There are about 3,000 examples on github:

https://github.com/search?l=Java&q=EntityRenderersEvent&type=Code