[1.19.2] Creating a Boat?

[DakotaPride]

I've done this with fabric using a library but noticed that the classes related to Boats in Forge also handle it in a similar fashion, using an enum for boat types, making it harder to create a custom boat. Is there any documentation or anything that would help as a reference or guide to this?

[Hipposgrumm]

You can use BYG as a reference.

[DakotaPride]

  On 3/15/2023 at 9:24 PM, Hipposgrumm said:

You can use BYG as a reference.

Expand  

Okay, after some time, I've got part of it working. The boats register as items, but I'm running into an issue when I try to place down the boat (regular and chest boats). Here's the crash report for this and here's the git repo (Forge) in case it may help.

[Hipposgrumm]

  On 3/16/2023 at 2:37 AM, DakotaPride said:

Here's the crash report for this and here's the git repo (Forge) in case it may help.

Expand  

It's saying that an "entityrender" variable is null, check that. 

Funnily enough, I once played on a server where the BYG boats crashed the game and they had to make a rule where crafting BYG boats was not allowed, but that was in 1.16.5.

[DakotaPride]

  On 3/16/2023 at 1:56 PM, Hipposgrumm said:

It's saying that an "entityrender" variable is null, check that. 

Expand  

Is there any easy way to check where this variable is located? As I have gone through the files and haven't found a null entityrender variable. Unless I'm just missing it somehow

Or do you know how BYG managed to fix their issue?

Edited March 16, 2023 by DakotaPride

[Hipposgrumm]

  On 3/16/2023 at 3:49 PM, DakotaPride said:

Is there any easy way to check where this variable is located? As I have gone through the files and haven't found a null entityrender variable. Unless I'm just missing it somehow

Expand  

You must check the shouldrender method in your renderer class. If you can't find it, try searching for it in the parent class (that minecraft has).

  On 3/16/2023 at 3:49 PM, DakotaPride said:

Or do you know how BYG managed to fix their issue?

Expand  

All I know is that BYG had a similar issue and it was with other mods. I didn't think to look at the crash report back then.

[DakotaPride]

  On 3/16/2023 at 4:38 PM, Hipposgrumm said:

You must check the shouldrender method in your renderer class. If you can't find it, try searching for it in the parent class (that minecraft has).

Expand  

What exactly am I checking it for? (I know that I should check it since that seems to be where the problem is. However, the method doesn't seem to even have an entityrenderer variable inside of the parent class.) Again, I may just be missing something, sorry.

[Hipposgrumm]

  On 3/16/2023 at 2:37 AM, DakotaPride said:

here's the git repo (Forge)

Expand  

I checked your code; instead of creating a new renderer for your boat, just extend the original BoatRenderer class.

[DakotaPride]

  On 3/16/2023 at 7:38 PM, Hipposgrumm said:

 just extend the original BoatRenderer class.

Expand  

Still comes out with the same crash report sadly. I think I may just wait until 1.20 releases and see if there are any more effective ways of doing this or any new documentation/guides (would've liked it to be sooner, but can't really control that)

[Hipposgrumm]

  On 3/16/2023 at 7:51 PM, DakotaPride said:

Still comes out with the same crash report sadly.

Expand  

Can you update the github page so that I can see?

[DakotaPride]

  On 3/16/2023 at 7:54 PM, Hipposgrumm said:

Can you update the github page so that I can see?

Expand  

done

[Hipposgrumm]

  On 3/16/2023 at 7:51 PM, DakotaPride said:

Still comes out with the same crash report sadly.

Expand  

Can you send the crash report? It might not be completely identical.

[DakotaPride]

  On 3/16/2023 at 8:06 PM, Hipposgrumm said:

Can you send the crash report? It might not be completely identical.

Expand  

Most recent crash report

[warjort]

https://github.com/DakotaPride/Hibernal-Herbs/blob/master/Forge/src/main/java/net/dakotapride/hibernalHerbs/client/render/HibernalEntityRenderers.java

Your EntityRenderer doesn't get registered.

The correct way to do it is to use the EntityRenderersEvent.RegisterRenderers event:

https://github.com/MinecraftForge/MinecraftForge/blob/31e73355c310430ce1816009895b3eff1b5f5fc4/src/main/java/net/minecraftforge/client/event/EntityRenderersEvent.java#L94

It gets fired on the MOD event bus.

[DakotaPride]

  On 3/16/2023 at 8:50 PM, warjort said:

https://github.com/DakotaPride/Hibernal-Herbs/blob/master/Forge/src/main/java/net/dakotapride/hibernalHerbs/client/render/HibernalEntityRenderers.java

Your EntityRenderer doesn't get registered.

The correct way to do it is to use the EntityRenderersEvent.RegisterRenderers event:

https://github.com/MinecraftForge/MinecraftForge/blob/31e73355c310430ce1816009895b3eff1b5f5fc4/src/main/java/net/minecraftforge/client/event/EntityRenderersEvent.java#L94

It gets fired on the MOD event bus.

Expand  

Is there any examples of how this is used? I've never really used events before, so I'm not sure how I would get started with this. (sidenote, sorry for the long reply. Have been having Pc issues for the past couple of days)

[warjort]

https://forge.gemwire.uk/wiki/Events

 

There are about 3,000 examples on github:

https://github.com/search?l=Java&q=EntityRenderersEvent&type=Code