Jump to content

Add NBT data to an item just picked up in the ItemPickupEvent


Recommended Posts

Is there a way to add data to an item just picked up by a player using the ItemPickupEvent?

I'm currently doing this and it's not working:

ItemStack stack = event.getStack();
Player player = event.getEntity();
CompoundTag nbtData = stack.getOrCreateTag();
if(nbtData.getString("myMod:myTag") == player.getStringUUID()){
	// Do something
} else {
  nbtData.putString("myMod:myTag", player.getStringUUID());

Every time I pick up the item it doesn't find the tag and tries to set it again. I'm thinking maybe the item either can't be modified or I'm modifying the wrong item and it's already in the players inventory?

Edited by Silvertide
Link to comment
Share on other sites

  • Silvertide changed the title to Add NBT data to an item just picked up in the ItemPickupEvent

The event.getStack() is just a copy of the items that were picked up so you can see how many were picked up (e.g. if the player didn't have room to pickup the whole stack).

The real items will already be in the player's inventory at this point and might have been merged into another ItemStack of the same items.

See ItemEntity.playerTouch() for the full logic.


If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Ah okay, interesting. I see the hook there for the forge event, yeah it just passes the ItemEntity and Player to the event to check. Do you know of a way to get this functionality? I haven't done a ton with NBT data. I'm not sure where the best place to set this would be. I also noticed there is a Owner attribute already on the ItemEntity. I wonder if that could be used.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.