getResultItem requires Registry Access?

[elytraByte]

I am working to add recipes to my tile entity, but I've run into an issue. The method getResultItem from the Recipe class requires a Registry Access parameter, but I am not sure what to place in this field. Does anyone have any information on how I should proceed?

Here is my method that use getResultItem

        @Override
        public void toNetwork(FriendlyByteBuf buf, StoneMillRecipe recipe) {
            buf.writeInt(recipe.getIngredients().size());

            for (Ingredient ing : recipe.getIngredients()) {
                ing.toNetwork(buf);
            }
            buf.writeItemStack(recipe.getResultItem(), false);
        }

 

All my code is available on my Github.

The file in question is here.

 

Thank you for your time!

[warjort]

You already have the "output" of your recipe?

https://github.com/elytraByte/Boulanger/blob/98045e09372fa72f86486a21d419cfe84b7be5fb/src/main/java/org/l3e/Boulanger/recipe/StoneMillRecipe.java#L20

Look at what the vanilla recipe serializers do.

[elytraByte]

After looking into this issue some more, I have made some changes to my methods. I have added level.registryAccess() to my getResultItem() fields but my recipes are still not functioning. I've committed my changes to my repo for viewing.
 

        @Override
        public void toNetwork(FriendlyByteBuf buf, StoneMillRecipe recipe) {
            buf.writeInt(recipe.getIngredients().size());


            for (Ingredient ing : recipe.getIngredients()) {
                ing.toNetwork(buf);
            }
            buf.writeItem(recipe.getResultItem(level.registryAccess()));
        }

 

[warjort]

You can't staticly cache the level like that. You will cause memory leaks or worse.

Putting non-singleton, non effectively immutable data in static fields is asking for trouble.

 

Why do you need to call a method that isn't designed for the purpose you are using it for, when you already have the data in the "output" field?

If you feel you must call a method, add a getOutput() method that takes no parameters.

Edited April 8, 2023 by warjort

[elytraByte]

I must have something wrong then because buf.writeItem(recipe.output) doesn't work either.

[warjort]

Define "doesn't work"?

One obvious thing I see from trying your mod, is your recipes are not being loaded because you haven't put them in a namespace (like your loot tables are).

https://github.com/elytraByte/Boulanger/tree/master/src/main/resources/data

[elytraByte]

Well when I refactored, I must have made an error. Changing the location of my recipes folder has fixed the issue of the recipes producing a result inside the Stone Mill. I'm sorry I am still new at this. I appreciate your assistance.

Edited April 8, 2023 by elytraByte