Jump to content

Recommended Posts

Posted

I am working to add recipes to my tile entity, but I've run into an issue. The method getResultItem from the Recipe class requires a Registry Access parameter, but I am not sure what to place in this field. Does anyone have any information on how I should proceed?

Here is my method that use getResultItem

        @Override
        public void toNetwork(FriendlyByteBuf buf, StoneMillRecipe recipe) {
            buf.writeInt(recipe.getIngredients().size());

            for (Ingredient ing : recipe.getIngredients()) {
                ing.toNetwork(buf);
            }
            buf.writeItemStack(recipe.getResultItem(), false);
        }

 

All my code is available on my Github.

The file in question is here.

 

Thank you for your time!

Posted

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted

After looking into this issue some more, I have made some changes to my methods. I have added level.registryAccess() to my getResultItem() fields but my recipes are still not functioning. I've committed my changes to my repo for viewing.
 

        @Override
        public void toNetwork(FriendlyByteBuf buf, StoneMillRecipe recipe) {
            buf.writeInt(recipe.getIngredients().size());


            for (Ingredient ing : recipe.getIngredients()) {
                ing.toNetwork(buf);
            }
            buf.writeItem(recipe.getResultItem(level.registryAccess()));
        }

 

Posted (edited)

You can't staticly cache the level like that. You will cause memory leaks or worse.

Putting non-singleton, non effectively immutable data in static fields is asking for trouble.

 

Why do you need to call a method that isn't designed for the purpose you are using it for, when you already have the data in the "output" field?

If you feel you must call a method, add a getOutput() method that takes no parameters.

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted

Define "doesn't work"?

One obvious thing I see from trying your mod, is your recipes are not being loaded because you haven't put them in a namespace (like your loot tables are).

https://github.com/elytraByte/Boulanger/tree/master/src/main/resources/data

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted (edited)

Well when I refactored, I must have made an error. Changing the location of my recipes folder has fixed the issue of the recipes producing a result inside the Stone Mill. I'm sorry I am still new at this. I appreciate your assistance.

Edited by elytraByte

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.