Particle Beam???

[Fennx1000]

So I am working on a wand in 1.19.2 forge and for the event it is the 

InteractionResultHolder<>

event...

I created a particle beam but it is not showing up here is my code

    public ElementalWand(Properties properties) {
        super(properties);
    }

    @Override
    public InteractionResultHolder<ItemStack> use(Level level, Player player, InteractionHand hand) {
        if (!level.isClientSide()) { // only execute on server side
            // get player's position and facing direction
            Vec3 pos = player.getEyePosition(1.0f);
            Vec3 dir = player.getLookAngle();

            // get the block in front of the player
            BlockPos blockPos = new BlockPos(pos.add(dir.scale(2.0)));
            BlockState blockState = level.getBlockState(blockPos);

            // create particle beam
            for (int i = 0; i < 40; i++) { // spawn 40 particles along beam
                Vec3 particlePos = pos.add(dir.scale(i * 0.2)); // spawn particles every 0.2 blocks
                level.addParticle(ParticleTypes.DRAGON_BREATH, particlePos.x(), particlePos.y(), particlePos.z(), 0.0, 0.0, 0.0);
            }

            // schedule particle beam to dissipate after 2 seconds
            int particleCount = 40;
            double x = pos.x();
            double y = pos.y();
            double z = pos.z();
            ClientboundLevelParticlesPacket particlePacket = new ClientboundLevelParticlesPacket(
                    ParticleTypes.DRAGON_BREATH,
                    true,
                    (float) x,
                    (float) y,
                    (float) z,
                    0.0f,
                    0.0f,
                    0.0f,
                    0.0f,
                    particleCount
            );
            ((ServerPlayer) player).connection.send(particlePacket);

            // return success
            return new InteractionResultHolder<>(InteractionResult.SUCCESS, player.getItemInHand(hand));
        }

        // return pass if executed on client side
        return new InteractionResultHolder<>(InteractionResult.PASS, player.getItemInHand(hand));
    }

 

[warjort]

Quote

// return pass if executed on client side

return new InteractionResultHolder<>(InteractionResult.PASS, player.getItemInHand(hand));

"PASS" means you are not interested in this interaction and so it won't send a network packet to the server, making the other code pointless.

Use InteractionResult.sidedSuccess(), e.g. see EggItem.use() for a simple example.

[Fennx1000]

Shouldn't I just put success...

[Fennx1000]

since this is 1.19.2

 

[warjort]

That is what the method I proposed does on the client side.

But you will find it easier and less error prone to use Mojang's intended way of writing simple handlers:
 

if (!checkConditionsAreRelevant()) {
   return "PASS";
}
if (!level.isClientSide) {
// server code that actually does stuff
}
// Code common to server and client here, e.g. playing sounds
return InteractionResult.sidedSuccess(itemStack, level.isClientSide);

 

If you don't want to follow similar code patterns used in vanilla code that is your choice.

But don't expect to get much help in this forum, beyond  "you are doing it wrong" or just being ignored.

Edited April 11, 2023 by warjort

[warjort]

By the way, this is rubbish

Quote

((ServerPlayer) player).connection.send(particlePacket);

Only the player using the item will see the particles.

Use the sendParticles() which will broadcast the particles to all players in range. See for example PotionItem.