Jump to content

How to Stop a Sword Hitting an Entity


TheElementGuy

Recommended Posts

So it wasn't very clear to put that in words in the title, so here is a better explanation. I have a sword and I want it only to hurt enemies. I can distinguish between enemies and not enemies, but how do I make it not hurt non-enemies?

Please don't put anything from 1.16.5, 1.12.2, 1.14, 1.15, 1.0, or anything not 1.18.x or 1.19.x!

Link to comment
Share on other sites

This probably isn't perfect practice, but what I would do is create a Mixin and mix into the LivingEntity#hurt(DamageSource, float) class and add the following check:

  • DamageSource is Entity
    • If so, check if the entity is holding the sword.
    • Any other conditions, such as making sure the entity is a player.

If the check above is true, return false.

Something like this:

package com.example.examplemod.mixin;

import com.example.examplemod.Mod;
import net.minecraft.world.damagesource.DamageSource;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityType;
import net.minecraft.world.entity.EquipmentSlot;
import net.minecraft.world.entity.LivingEntity;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@Mixin(LivingEntity.class)
public abstract class SuperCoolSwordThing {
    @Inject(method="hurt(Lnet/minecraft/world/damagesource/DamageSource;F)Z", at = @At("HEAD"), cancellable = true)
    private void superCoolSword_onlyDamageEnemy(DamageSource p_21016_, float p_21017_, CallbackInfoReturnable<Boolean> cir) {
        if (p_21016_.getEntity()!=null&&p_21016_.getEntity() instanceof LivingEntity&&((LivingEntity)p_21016_.getEntity()).getMainHandItem().is(Mod.SUPERCOOLSWORD) && Mod.checkIsEntity((LivingEntity)(Object)this)) {
            cir.setReturnValue(false);
        }
    }
}

I will remind you that this probably isn't professional and that there are probably better ways to do it. (This is just how I would do it.)

Edited by Hipposgrumm
See warjort's answer.

I'm not good at modding, but at least I can read a crash report (well enough). That's something, right?

Link to comment
Share on other sites

AttackEntityEvent, LivingAttackEvent or LivingHurtEvent.

Which one you use depends upon on what you are trying to achieve.

e.g. the first is only for players that are attacking

while the last one is generally used to change the damage amount, which you could set to 0 but it will still show the animations.

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Quote

I will remind you that this probably isn't professional

Please don't encourage people to use mixins.

They are a last resort for special behaviour can't be achieved in safer ways.

e.g. stuff that forge would be unlikely to include as an event because it is just too niche of a usecase

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.