Jump to content

Need help with mod version


Neometron

Recommended Posts

Hi,

 

I'm having troubles with version numbers with my mod. My mod is designed to be backward compatible with my older version of my mod. My server contains an older version and my client has a newer version. When I attempt to log on the server, I get rejected for the missing older version of my mod. How can I have my server allow newer client versions of the mod?

 

[edit]

 

I suppose I should also mention that I have:

              @VersionCheckHandler
public boolean VersionCheck(String var, INetworkManager netManager)
{
	return true;
}

 

However, adding a breakpoint here never gets hit.

Link to comment
Share on other sites

To use VersionCheckHandler annotation, you must have a @NetworkMod and put it in the same class, with a public method accepting a String as only argument. See NetworkModHandler class for details on how it work.

 

I had done this, unless I'm doing it wrong. I have @NetworkMod as part of my class.

 

@NetworkMod(clientSideRequired=true,
       	       serverSideRequired=false,
       channels={
	          "CLIENT_INITSYNC",
	          "CLIENT_TIMESYNC",
	          "SERVER_INITSYNC",
	          "SERVER_TIMESYNC",
	          "CLIENT_CALENDAR",
	          "SERVER_CALENDAR"
  	       },
       packetHandler = AdvanceTimePackets.class,
       connectionHandler = AdvanceTimeConnections.class)


public class AdvanceTimeMod
{...

    @VersionCheckHandler
    public boolean VersionCheck(String var, INetworkManager netManager)
   {
     return true;
   }

...

 

I originally had @VersionCheckHandler like this:

 

   @VersionCheckHandler
    public boolean VersionCheck(String var)
   {
     return true;
   }

 

The reason I placed INetworkManager as a parameter was because it said it needed a string and a NetworkManager. In both cases, it does not reach my breakpoint in the VersionCheck method.

Link to comment
Share on other sites

NetworkModHandler is searching for a method with String as a parameter.

Method checkHandlerMethod = networkModClass.getDeclaredMethod(versionCheckHandlerMethod, String.class);
                if (checkHandlerMethod.isAnnotationPresent(NetworkMod.VersionCheckHandler.class))
                {
                    this.checkHandler = checkHandlerMethod;
                }

And invoking it with "version", which is a String...

if (checkHandler != null)
        {
            try
            {
                return (Boolean)checkHandler.invoke(container.getMod(), version);
}
            catch (Exception e)
            {
                FMLLog.log(Level.WARNING, e, "There was a problem invoking the checkhandler method %s for network mod id %s", checkHandler.getName(), container.getModId());
                return false;
            }

This should work unless this is actually deprecated.

Did you get any warning in your log when you tried with String as only parameter ?

I would try with Boolean as return type, just in case.

Link to comment
Share on other sites

I tried everything suggested, however it appears that checkHandler is always null.

 

But, what is this in the same method of NetworkModHandler.acceptVersion(String version)

 

if (acceptableRange!=null)
{
   return acceptableRange.containsVersion(new DefaultArtifactVersion(version));
}

 

acceptableRange seems to always be valid. How do I use this?

Link to comment
Share on other sites

Will this correctly allow my mod to accept newer versions?

 

@Mod(modid="advancetime", name="Advance Time", version="1.1")

@NetworkMod( clientSideRequired=true,
             serverSideRequired=false,
             versionBounds="[1.1, )",
                  ...)

Link to comment
Share on other sites

Will this correctly allow my mod to accept newer versions?

 

@Mod(modid="advancetime", name="Advance Time", version="1.1")

@NetworkMod( clientSideRequired=true,
             serverSideRequired=false,
             versionBounds="[1.1, )",
                  ...)

 

I'll answer myself - Yes

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, Hi and I am making a forge 1.12.2 mod and also trying to get a custom model helmet item (I made a joker mask) and exported it to .json format and put it in the ~/namespace/models/item folder. Though, I'm struggling to get the item to render what I want it to be rendered like as I've positioned it in the 'head' window view in blockbench. How did you render out your model? I checked your code and it looks like no references to the actual model are being made. I'm new to this forge modding stuff (was a fabric modder) and I desperately need some help. Is there a way to standardly render out armor models made using blockbench? any methods that one can use? My model in JSON: ```json { "credit": "Made with Blockbench", "texture_size": [160, 160], "textures": { "0": "ydyrn:items/joker_mask_texture", "particle": "ydyrn:items/joker_mask_texture" }, "elements": [ { "from": [0, 0, 0], "to": [16, 16, 1], "faces": { "north": {"uv": [0, 1.7, 16, 14.2], "texture": "#0"}, "east": {"uv": [0, 4, 0.9, 5.6], "texture": "#0"}, "south": {"uv": [0, 5.8, 1.6, 7.4], "texture": "#0"}, "west": {"uv": [0, 1.9, 1.3, 3.5], "texture": "#0"}, "up": {"uv": [0, 3.4, 1.6, 4.2], "texture": "#0"}, "down": {"uv": [0, 9, 1.6, 9.7], "texture": "#0"} } }, { "from": [15.8, 11, 0.5], "to": [16.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } }, { "from": [0.2, 11, 14.6], "to": [15.8, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"} } }, { "from": [-0.2, 11, 0.5], "to": [0.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "thirdperson_lefthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "firstperson_righthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "firstperson_lefthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "ground": { "rotation": [40, 0, 0], "translation": [0, -2.5, 0], "scale": [0.5, 0.5, 0.5] }, "gui": { "rotation": [0, 180, 0] }, "head": { "translation": [0, 0, 0.25], "scale": [0.82773, 0.73594, 0.9] }, "fixed": { "translation": [0, 0, 8.75] } }, "groups": [ 0, { "name": "straps", "origin": [0, 0, 0], "color": 0, "children": [1, 2, 3] } ] } ```
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • In your config folder, delete the sophisticatedcore-common.toml file and test it again
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.