Damage Item No Work

[Fennx1000]

So hi but I have a item that summons particles around the nearest entity but deals damage to but it seems to be not dealing the damage. here is my code... https://pastebin.com/bNrD7iK7

[warjort]

https://forums.minecraftforge.net/topic/122906-particle-beam/#comment-534628

Quote

If you don't want to follow similar code patterns used in vanilla code that is your choice.

But don't expect to get much help in this forum, beyond  "you are doing it wrong" or just being ignored.

 

But your main problem is: DONT store data in static fields unless they are effectively immutable.

You need to store the data against the object it relates to.

In this case, either the player or the ItemStack. I don't know which of those you intend to have the cooldown.

 

Here's what your code does:

1) Checks the cooldown and if it is ok finds the nearest entity and tries it hurt it on the client which will do nothing except maybe make it turn red?

2) Sets that static field and returns SUCCESS so it ill pass the work the server

3) The server (in single player mode) then checks the same static field and so says the item is on cooldown meaning it does nothing.

 

I bet your code "works" on a dedicated on server, but only if there is one player using the item at once.

You should also really be using "ticks" not real time. e.g. player.tickCount