[SOLVED][1.19.4] Link vanilla block entity to modded block

[JimiIT92]

I'm trying to create some lectern blocks, and so far the block itself works. However the rendering of the book doesn't, and by looking at the debugger it seems that the renderer class doesn't get linked to the custom block, even thou I'm not using a custom block class. So I've tried to instead create my own lectern block entity, however the LecternBlockEntity constructor doesn't allow to change the blockentitytype (is hardcoded into the constructor itself), so if I had to do this I'd have to basically clone the entire class, which is something I want to avoid.

This is how I register the block
 

public static final RegistryObject<Block> SPRUCE_LECTERN = RegisterHelper.registerBlock("spruce_lectern", () -> new LecternBlock(PropertyHelper.copyFromBlock(Blocks.LECTERN)));

You can see the full implementation here to check what the helper methods does: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlocks.java#L1183

I've also already created the block entity and the rendering like so
 

public static final RegistryObject<BlockEntityType<LecternBlockEntity>> SPRUCE_LECTERN = RegisterHelper.registerBlockEntity("spruce_lectern", LecternBlockEntity::new, MWBlocks.SPRUCE_LECTERN);

//rendering
BlockEntityRenderers.register(SPRUCE_LECTERN.get(), LecternRenderer::new);

You can also see this here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlockEntityTypes.java#L19

 

So how can I attach the vanilla block entity to my custom block? Or at least make so that the custom lectern block will use the custom block entity type, but without copy/pasting the entire class, if is even possible?

Edited April 26, 2023 by JimiIT92
solved

[warjort]

https://github.com/MinecraftForge/MinecraftForge/blob/d4f211b81586d24ab6b734c7815fc067579b09b9/src/main/java/net/minecraftforge/client/event/EntityRenderersEvent.java#L93

 

But as to why it doesn't work, look at the constructor for LecternBlockEntity and what BlockEntityType it hardwires.

In general you can't reuse vanilla blocks because of such hardwiring made by Mojang.

 

In this case, you can probably hack it by doing something like (untested pseudo code):

public class MyLecternBlockEntity extends LecternBlockEntity {

    public MyLecternBlockEntity(BlockPos p_155622_, BlockState p_155623_) {
        super(p_155622_, p_155623_);
    }

    // Make this block entity return your type
    @Override
    public BlockEntityType<?> getType() {
        return MWBlockEntityTypes.SPRUCE_LECTERN.get();
    }
}

public class MyLecternBlock extends LecternBlock {

    public MyLecternBlock(Properties p_54479_) {
        super(p_54479_);
    }

    // Make the block create your block entity 
    @Override
    public BlockEntity newBlockEntity(BlockPos p_153573_, BlockState p_153574_) {
        return new MyLecternBlockEntity(p_153573_, p_153574_);
    }
}

but such hacks only work when there isn't other hardcoding elsewhere.

e.g. you will also have to use an event to workaround the hardwiring of the LecternBlock instance in Writable/WrittenBookItem.useOn()

There might be other places?

 

Edited April 26, 2023 by warjort

[JimiIT92]

Yeah I've tried doing a custom block that extends LecternBlock and creates a custom LecternBlockEntity, but unfortunately the LecternBlockEntity hardwires the BlockEntityType.LECTERN into the constructor  If I do that I can surely solve the issue, as I can link the custom block entity to the LecternRederer class using BlockEntityRenderers, is just that I'm wondering if I can avoid duplicating the class, since it would be harder to mantain in future due to changes.

As for the book I've already hooked it up on the RightClickBlock event and using the static tryPlaceBook method on the block class itself, so that's not really an issue

EDIT:
Ok, I got it, and I feel so dumb to not thought about this earlier. Turns out that all I needed to do is to override the getType method inside the custom block entity
 

public class MWLecternBlockEntity extends LecternBlockEntity {

    public MWLecternBlockEntity(final BlockPos blockPos, final BlockState blockState) {
        super(blockPos, blockState);
    }

    @Override
    public @NotNull BlockEntityType<?> getType() {
        return MWBlockEntityTypes.SPRUCE_LECTERN.get();
    }
}

And inside the custom block I now instantiate this block entity instead
 

@Override
        public BlockEntity newBlockEntity(BlockPos blockPos, BlockState blockState) {
            return new MWLecternBlockEntity(blockPos, blockState);
        }

This way I don't need to copy the vanilla class and can hook up my custom block entity type to the vanilla render
 

Edited April 26, 2023 by JimiIT92
found solution

[warjort]

  Quote

but unfortunately the LecternBlockEntity hardwires the BlockEntityType.LECTERN into the constructor

Expand  

Yes, but look at how my class overrides getType() to ignore that value and return your own.

[JimiIT92]

  On 4/26/2023 at 11:43 AM, warjort said:

but look at how my class overrides getType() to ignore that value and return your own

Expand  

Ironically I've just did that without noticing your comment 😅 I've edited my previous answer, and again feel so dumb for not thinking about that before 😅 Closing this, thank you for the help as always