Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.19.4] How did we add enchantments by default to items with getDefaultInstance?

Featured Replies

Posted

So I'm trying to add piercing by default already applied to my custom ranged weapon, I got this currently, I did this in the past but I forgot, I do remember it had something to do with getDefaultInstance:

 

    @Override
    public ItemStack getDefaultInstance()
    {
        ItemStack defaultInstance = new ItemStack(this);
        EnchantmentHelper.setEnchantments(Collections.singletonMap(Enchantments.PIERCING, 1), defaultInstance);
        return defaultInstance;
    }

 

Thank you so much in advance

  • Author

#Edit

 

Apparently getDefaultInstance is maybe not what we're looking for, in that case what can we do?

getDefaultInstance() is what you want, assuming that is what is actually used to create the ItemStack which is not always true.

e.g.

new ItemStack(item, 1)

wouldn't call that method.

 

For recipes you will likely need to use the Forge NBT extension:

https://docs.minecraftforge.net/en/latest/resources/server/recipes/#additional-features

or you might want create a custom recipe type with its own assemble() to do it programmatically

https://docs.minecraftforge.net/en/latest/resources/server/recipes/custom/#recipe

 

And loot tables have a number of LootItemFunctions for enchanting.

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.