Jump to content

[1.19.4] Custom biomes aren't counted in the adventuring time advancement


Recommended Posts

I'm editing some vanilla advancements to include my mod's features, and I've noticed something strange about the adventuring time advancement (the one where you have to discover all overworld biomes).

You can see my edited advancement json file here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/resources/data/minecraft/advancements/adventure/adventuring_time.json

What I did is simply add 3 biomes to the criteria and add them into the requirements as well. So the biomes required for the advancement should now be 56 instead of 53. However, in the advancement screen, it keeps saying that I need to discover 53 biomes, instead of 56, which is also strange due to the fact that if I go inside one of the 3 added biomes the counter for the discovered biomes increases, so it recognize that going into that biome will count towards the advancement.

I don't know what's causing this, since I did a similar thing to the "a balanced diet" advancement, where I added 2 foods to the requirements and the counter properly says the correct amount (which is 42 instead of vanilla 40, you can find the JSON here).

I've also tried to remove both modded biomes and a vanilla biome from the requirements, from which I expected the counter to at least go down by one, but it still says 53 no matter what... So how can I change this counter to display the correct amount of biomes that are required for the advancement? Could it have something to do with how I register the biomes (which I do here)?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

When I try your mod it says I need 55 biomes.

I doubt advancements will change once you have created them? Unless you do something like vanilla's datafixerupper.

You probably need to create a new world/player to test any changes to the definition.

 

The way you are doing this is very brittle. Another mod doing the same thing is going to conflict.

But I don't know a better way to do it.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

That's really weird, I've just created a new world both in a dev environment or with a real account, and in both cases the count is incorrect for some reason.

By the way I know this will cause mod conflicts, but since there aren't any other ways the only compromise I can think of is to use tags, but I don't know if that will actually work

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hiya! I've just been using FTB Launcher there since I was having problems with Curseforge and now I've run into bother with this as well. It began out of nowhere but whenever I was trying to load AllTheMods 8 one day it didn't work so I deleted the config for some broken mods; usually works for me. Nothing worked so I uninstalled the whole instance, and I've been redownloading it again and again trying different things - Allocating more ram, reinstalling Java, the works.   It'd be greatly appreciated if anyone were able to help me, every couple of weeks I have to tear these modpacks apart to actually get them to work and it's so annoying.   Here's the log if that helps? The guy on the other post said to post the whole debug but I couldn't get it: https://ibb.co/5G03gX4 Sorry that it's linked it wouldn't let me copy and paste, the newest debug will be below too:   [09Jun2023 15:31:10.155] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, SillyDillyXoxo, --version, 1.19.2-forge-43.2.11, --gameDir, D:\ftb\c4f3a60c-f9e7-49d8-970a-17b98825359e, --assetsDir, C:\Users\Dylan Lunney\AppData\Local\.ftba\bin\assets, --assetIndex, 1.19, --uuid, cef43407-3d1e-48f8-96a5-ec6b2b30a9a9, --accessToken, ????????, --clientId, ${clientid}, --xuid, ${auth_xuid}, --userType, msa, --versionType, release, --width, 1720, --height, 840, --launchTarget, forgeclient, --fml.forgeVersion, 43.2.11, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [09Jun2023 15:31:10.160] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.4 by Eclipse Adoptium; OS Windows 10 arch amd64 version 10.0 [09Jun2023 15:31:10.180] [main/DEBUG] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Found launch services [fmlclientdev,forgeclient,minecraft,forgegametestserverdev,fmlserveruserdev,fmlclient,fmldatauserdev,forgeserverdev,forgeserveruserdev,forgeclientdev,forgeclientuserdev,forgeserver,forgedatadev,fmlserver,fmlclientuserdev,fmlserverdev,forgedatauserdev,testharness,forgegametestserveruserdev] [09Jun2023 15:31:10.190] [main/DEBUG] [cpw.mods.modlauncher.NameMappingServiceHandler/MODLAUNCHER]: Found naming services : [srgtomcp] [09Jun2023 15:31:10.203] [main/DEBUG] [cpw.mods.modlauncher.LaunchPluginHandler/MODLAUNCHER]: Found launch plugins: [mixin,eventbus,slf4jfixer,object_holder_definalize,runtime_enum_extender,capability_token_subclass,accesstransformer,runtimedistcleaner] [09Jun2023 15:31:10.211] [main/DEBUG] [cpw.mods.modlauncher.TransformationServicesHandler/MODLAUNCHER]: Discovering transformation services        
    • Are you tired of “modern” skyblock servers that are nothing like the original? Are you looking for a skyblock server that is just like the original skyblock servers used to be? So was I, but I couldn't find one, so, I decided to make my own. Many modern servers have mutated the Skyblock game mode to the point where it is unrecognizable compared to the original. We are seeking to create a space where those who loved classic Skyblock can enjoy the original game mode. Even if you have not played classic Skyblock before, we encourage you to join our community to learn about what the original mode was like and why there was so much excitement around it. Server Description Classic Skies is designed just like the original skyblock servers but in the modern version, 1.19.4. There is a server shop where you can buy some of the items that you can’t obtain naturally with in-game money, as well as a plugin that allows you to set up your own shops on your island, causing a mostly player-run economy. Classic Skies’ goal is to bring back the nostalgic and classic feel of the original Skyblock as much as possible. We have a dedicated staff team and an owner with years of experience running small to medium-sized Minecraft servers. Classic Skies is a small server with a tight-knit community, and we are looking for new members to enjoy our server. Additionally, we are dedicated to delivering a lag-free, fair, and safe experience for every member of the community. Server Info Server IP: play.classicskies.com Supports Java & Bedrock Edition Bedrock Port: 19132 Game Version: 1.19.4 Discord: https://discord.gg/n7qXHnhksA
    • https://gist.github.com/Jayv6/7e39a9c1b3eb10b0d5d76442718d80e0
    • Hey Harry007! I recently created a server called Classic Skies. It is an amazing skyblock server. Here is the information: Are you tired of “modern” skyblock servers that are nothing like the original? Are you looking for a skyblock server that is just like the original skyblock servers used to be? So was I, but I couldn't find one, so, I decided to make my own.   Many modern servers have mutated the Skyblock game mode to the point where it is unrecognizable compared to the original. We are seeking to create a space where those who loved classic Skyblock can enjoy the original game mode. Even if you have not played classic Skyblock before, we encourage you to join our community to learn about what the original mode was like and why there was so much excitement around it.   Server Description Classic Skies is designed just like the original skyblock servers but in the modern version, 1.19.4. There is a server shop where you can buy some of the items that you can’t obtain naturally with in-game money, as well as a plugin that allows you to set up your own shops on your island, causing a mostly player-run economy. Classic Skies’ goal is to bring back the nostalgic and classic feel of the original Skyblock as much as possible. We have a dedicated staff team and an owner with years of experience running small to medium-sized Minecraft servers. Classic Skies is a small server with a tight-knit community, and we are looking for new members to enjoy our server. Additionally, we are dedicated to delivering a lag-free, fair, and safe experience for every member of the community.   Server Info Server IP: play.classicskies.com Supports Java & Bedrock Edition Bedrock Port: 19132 Game Version: 1.19.4 Discord: https://discord.gg/n7qXHnhksA
    • I am trying to override or disable some vanilla recipes, as part of my mod. All of the methods that I have seen online, so far, do not work. So far, I have tried: Creating a JSON file in the "data/minecraft/recipes" folder, that has air as the ingredient and a barrier as the result This only works for crafting table recipes adding a smelting recipe this way works as intended Editing the ordering to AFTER in the forge dependency inside the "mods.toml" file Found an older post about using the FurnaceRecipe class, that no longer exists From: here So, what is required to disable a vanilla smelting recipe? I know some may say to not do this, but part of the progression of my mod kind of requires disabling some of the furnace recipes. Also, it seems that smelting recipes don't technically have to have the same filename as the block used, r as the result. When overriding crafting recipes, just adding the edited/removed recipe file in the minecraft data folder, under the same name as the original recipe.  Edit: the crafting recipes seem to be cached between worlds? I created a new world and the edited crafting recipes works, but it doesn't work in an already made world?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.