I'm editing some vanilla advancements to include my mod's features, and I've noticed something strange about the adventuring time advancement (the one where you have to discover all overworld biomes).

You can see my edited advancement json file here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/resources/data/minecraft/advancements/adventure/adventuring_time.json

What I did is simply add 3 biomes to the criteria and add them into the requirements as well. So the biomes required for the advancement should now be 56 instead of 53. However, in the advancement screen, it keeps saying that I need to discover 53 biomes, instead of 56, which is also strange due to the fact that if I go inside one of the 3 added biomes the counter for the discovered biomes increases, so it recognize that going into that biome will count towards the advancement.

I don't know what's causing this, since I did a similar thing to the "a balanced diet" advancement, where I added 2 foods to the requirements and the counter properly says the correct amount (which is 42 instead of vanilla 40, you can find the JSON here).

I've also tried to remove both modded biomes and a vanilla biome from the requirements, from which I expected the counter to at least go down by one, but it still says 53 no matter what... So how can I change this counter to display the correct amount of biomes that are required for the advancement? Could it have something to do with how I register the biomes (which I do here)?

When I try your mod it says I need 55 biomes.

I doubt advancements will change once you have created them? Unless you do something like vanilla's datafixerupper.

You probably need to create a new world/player to test any changes to the definition.

 

The way you are doing this is very brittle. Another mod doing the same thing is going to conflict.

But I don't know a better way to do it.

That's really weird, I've just created a new world both in a dev environment or with a real account, and in both cases the count is incorrect for some reason.

By the way I know this will cause mod conflicts, but since there aren't any other ways the only compromise I can think of is to use tags, but I don't know if that will actually work