Jump to content

Recommended Posts

Posted

I am attempting to make a belt sander that when you click on the central button it creates the respective output defined by recipe jsons. It almost works however when i try to take the items from the result slots they disappear and when i take from either of the input slots i get the item i put in and not what it says is there. What did i do wrong?

sandItems method

   public void sandItems() {
      LOGGER.info(hasRecipe(this)?"Sanding!":"Sanding failed :(");
      if (hasRecipe(this)) {
         ItemStack stack = this.inputSlot.getItem(0);
         boolean flag = !this.bookSlot.isEmpty() && stack.isEnchanted();
         SandingRecipe recipe = getRecipe(this);
         this.resultSlots.addItem(flag?recipe.getResultItem():enchantedOutput(recipe,stack));
         for (ItemStack item: recipe.rollResults()) {
            this.resultSlots.addItem(item);
         }
         if(flag) {
            ItemStack stack0 = this.bookSlot.getItem(0);
            if(!stack.is(Items.ENCHANTED_BOOK)) {
               stack0 = Items.ENCHANTED_BOOK.getDefaultInstance().copy();
            }
            EnchantmentHelper.setEnchantments(EnchantmentHelper.getEnchantments(stack),stack0);
            this.bookSlot.setItem(0,stack0);
         }
         stack.shrink(1);
         this.inputSlot.setItem(0,stack);
      }
   }

button class

package com.freyebeans.mgdim.inventory;

import com.mojang.blaze3d.systems.RenderSystem;
import com.mojang.blaze3d.vertex.PoseStack;
import net.minecraft.client.gui.components.AbstractButton;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.narration.NarratedElementType;
import net.minecraft.client.gui.narration.NarrationElementOutput;
import net.minecraft.client.renderer.GameRenderer;
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.TranslatableComponent;
import net.minecraft.resources.ResourceLocation;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

import java.util.function.Consumer;

@OnlyIn(Dist.CLIENT)
public class SandButton extends AbstractButton {

    private final ResourceLocation resourceLocation;
    private final BeltSanderMenu menu;
    private final BeltSanderScreen screen;

    private int leftPos;
    private int imageHeight;
    private int imageWidth;

    public SandButton(BeltSanderScreen screen, BeltSanderMenu menu, int imgh, int imgw, int lpos, ResourceLocation rl){
        super(lpos + 73,((screen.height - imgh) / 2) + 15,30,63, new TranslatableComponent("container.sander.sand"));
        this.menu = menu;
        this.screen = screen;
        this.resourceLocation = rl;
        leftPos = lpos;
        imageHeight = imgh;
        imageWidth = imgw;
    }

    public void screenSync(int imgh, int imgw, int lpos){
        leftPos = lpos;
        imageHeight = imgh;
        imageWidth = imgw;
        this.x = lpos + 73;
        this.y = ((screen.height - imgh) / 2) + 15;
    }

    public void renderButton(PoseStack p_94282_, int p_94283_, int p_94284_, float p_94285_){
        RenderSystem.setShader(GameRenderer::getPositionTexShader);
        RenderSystem.setShaderTexture(0, this.resourceLocation);

        int i = this.leftPos;
        int j = (screen.height - this.imageHeight) / 2;
        int k = 60;
        if (!menu.inputSlot.getItem(0).isEmpty()) {
            k -= this.isHoveredOrFocused() ? 30 : 60;
        }

        RenderSystem.enableDepthTest();
        this.blit(p_94282_, i + 73, j + 15, k, this.imageHeight, 30, 63);


    }

    @Override
    public void onPress() {
        menu.sandItems();
    }

    @Override
    public void updateNarration(NarrationElementOutput p_169152_) {

    }
}

 

Posted

first issue (not a cause of you problem but i can't ignore it) - buttons should not know about outside logic. they should fire a click event or toggle (change state) event and that's it. screen should provide handler for the button click event then it (screen) creates a button.

menu classes are... problematic. at first at least. the thing is you have TWO instances of menu class living at the same time. some parts execute on client, some parts on server. for example slot contents change happens on server and that (and there) is usually where you do your crafting. if the crafting is triggered by a button, you send a client-to-server message that the button is pressed. and only that - only the button identifier (of there are more buttons); message is to contain no information about slots etc. message handler receives the message, it gets the server player corresponding to client player that sent the message, gets the menu opened for that player, casts to your menu and calls some method.

Posted
  On 6/29/2023 at 6:33 AM, MFMods said:

if the crafting is triggered by a button, you send a client-to-server message that the button is pressed. and only that - only the button identifier (of there are more buttons); message is to contain no information about slots etc.

Expand  

what do you mean by message?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.