Jump to content

Recommended Posts

Posted

I'm trying to stop players from using certain items until they meet some prerequisites, but I can't seem to get a good comparison working that will allow me to do something with the item in the spot.

 

So far I've just created some conditional statements to test my ideas. Below you can see that I'm using the isSwingInProgress event in a player update event. I'm using this because I don't want the item to get kicked for having it, just using it.

 

Right now I am having the chat spit out the (player name) "is using a" currentItem. Well this comes out in chat as "Player### is using a 1xpickaxeStone@1 (2, 3 ...). So when I try to compare the .getCurrentItem to an ItemStack variable that I created I'm not getting the right comparison.

 

Any help is appreciated! Also, if more explanation is needed please let me know.

 

	@ForgeSubscribe
public void onPlayerUpdate(LivingUpdateEvent event){
	if(event.entityLiving instanceof EntityPlayer){
		EntityPlayer player = (EntityPlayer) event.entityLiving;


		if(player.isSwingInProgress){

			player.addChatMessage(player.getEntityName() + " is using a " + player.inventory.getCurrentItem());

			ItemStack heldItem = new ItemStack(Item.pickaxeStone);

			if(player.inventory..getCurrentItem() == heldItem){
				player.addChatMessage("Using a Stone Pickaxe."); //If I get this message to display then I know I can get the items kicked out of the slot, just need to get this if statement working.
			}
		}
	}
}

Posted

Sorry to say, but basic java:

 

ItemStack heldItem = new ItemStack(Item.pickaxeStone);
if(player.inventory.getCurrentItem() == heldItem){

'==' in this case has an other meaning than you think. It's checking if both objects are the one and the same, meaning they hold a reference to the same location in memory. The solution would be:

if(player.inventory.getCurrentItem().itemID == Item.pickaxeStone.itemID)

 

But please learn more about Java before proceding, it will make you life easier :).

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

There's also an .equals() function in class ItemStack, which will compare two item stacks for equality (same item ID, same metadata, same NBT tags).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
    • Add the mods in groups
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.