Draco18s

Textures are client side only. You will not find any server code related to colorization.

I have no idea what the problem even was. Glad you figured it out though.

Don't. There is no reason to. The only registry that matters in the Registry.Register<Item> event is the items registry, which is given to you by the event. A simpler way to do what? You don't do anything with that variable.

No, it makes the advancement that unlocks the bone -> bonemeal recipe impossible to get. Its not a new advancement at all, notice where it lives. If you create a similar advancement for the grindstone, then picking up a slab won't give you the grindstone recipe. Or you can alter the condition, unlock reward, etc.

Your one about saving information for each player? You already have an answer.

What? Why? Yes, but that still doesn't let you have different blocks in different tabs. No.

Should just be creating a dummy one that's essentially impossible to obtain. I swear I have it around somewhere... Ah ha there it is. Couldn't find it last night. https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/minecraft/advancements/recipes/misc/bone_meal.json

No. I mean "don't use a list." public static void createBlockItems(final RegistryEvent.Register<Item> event) { final IForgeRegistry<Item> registry = event.getRegistry(); registry.register(new BlockItem(ModBlock.BlockA, new Item.Properties().group(ItemGroup.GROUP)).setRegistryName(ModBlock.BlockA.getRegistryName())); registry.register(new BlockItem(ModBlock.BlockB, new Item.Properties().group(ItemGroup.BLOCKS)).setRegistryName(ModBlock.BlockB.getRegistryName())); registry.register(new BlockItem(ModBlock.BlockC, new Item.Properties().group(ItemGroup.REDSTONE)).setRegistryName(ModBlock.BlockC.getRegistryName())); registry.register(new BlockItem(ModBlock.BlockD, new Item.Properties().group(ItemGroup.DECORATION)).setRegistryName(ModBlock.BlockD.getRegistryName())); } Also this line: IForgeRegistry blockRegistry = GameRegistry.findRegistry(Block.class).getRegistrySuperType(); Is useless, you never actually do anything with the blockRegistry. Objects.requireNonNull(block.getRegistryName()) RequireNonNull here is also useless. If it was null, the game would have already crashed. 12 blockItem.setRegistryName(Objects.requireNonNull(block.getRegistryName())); 13 registry.register(blockItem); setRegistryName returns the object, removing the need for a local variable.

Don't use a giant massive list?

Yes.

No. Use packets. Why does your client need to know this information?

A tag with nothing in it generates an empty list. An empty list is special in that it contains zero items and is not null.

You could include a JSON tag file with no items in it. The whole point is that "an empty list" is still a valid list.

That's exactly what you need to do. Just remember to give a blank dummy for the original advancement.

IIRC this event is only fired on the server. And regardless, "will it work on the server?" is always true for things dealing with "game state" (and things dying is definitely game state information). Pretty much the answer is: "Does it involve visuals (textures, models), keyboard input, or sound files? No? Then it works on the server." Another way to tell is "is the 'client' in the package name?"

One of them should name-match (I recommend the one that has the desired output, name the other one something like "{original}_override" or "{original}_dummy"). If for nothing else than so people know what it's for.

There's a way to check on the Java side if a tag exists.

Textures is all about the json model file. Also, rather than extending Block you could extend one of the directional block classes (HorizontalBlock, etc) that already supplies most of that code already.

What do you mean, "format"? Its a list. It's ordered by its very nature and accepts objects of a single type.

Do not use only-in. Get the player from the context.

Then your modifier is broken, as even an empty loot drop list will still invoke all modifiers.

You aren't supposed to modify the original loot table json when using Loot Modifiers.

ItemStack#count()?

The fuck is wrong with: public void fill(NonNullList<ItemStack> items) { items.add( InitItems.PISTOL_COLT_1911.get(), InitItems.BULLET_CAL_45.get(), InitItems.PISTOL_CAL_45_PROTOTYPE_BASIC.get(), InitItems.BARREL_CAL_45_LIGHT.get(), InitItems.BARREL_CAL_45_MEDIUM.get(), InitItems.BARREL_CAL_45_HEAVY.get(), InitItems.MAG_CAL_45_SMALL.get(), InitItems.MAG_CAL_45_BIG.get(), InitItems.MAG_CAL_45_DRUM.get(), InitItems.MAG_CAL_45_BOX.get(), InitItems.GUN_BODY_LIGHT.get(), InitItems.GUN_BODY_MEDIUM.get(), InitItems.GUN_BODY_HEAVY.get(), InitItems.PIPE_CAL_45.get(), InitItems.GUN_GRIP.get(), InitItems.GUN_BUTT.get(), InitItems.ARMORED_GLASS_ITEM_BLOCK.get() ); }

GlobalLootModifiers. https://mcforge.readthedocs.io/en/1.15.x/items/globallootmodifiers/