Jump to content

Recommended Posts

Posted

Hi!

 

I found culegooner's lovely tutorial on how to make a core mod, which I've been following lately.

http://www.minecraftforum.net/topic/1854988-tutorial-162-changing-vanilla-without-editing-base-classes-coremods-and-events-very-advanced/

 

The tutorial is for 1.6.2, but I tried to use it for modding 1.6.4 instead and it worked perfectly fine within eclipse. But when obfuscated, it wouldn't work. There was no crash though, it simply didn't do anything and wouldn't show up in the mods list in minecraft. Interestingly enough the log says that forge actually finds it's "mcmod.info".

 

For testing, I downloaded culegooner's two example mods "creeper burn" and "explosion drops" and they work fine when I'm running minecraft 1.6.2. But as soon as I try to play 1.6.4 instead, they won't do anything.

 

What can be the significant difference between 1.6.2 and 1.6.4 when it comes to core mods, and why does it work within eclipse but not when obfuscated?

 

Ps: I know that I am supposed to avoid making a core mod as far as it's possible. But if I actually need to make a core mod one day, I would like to know how to.

 

 

 

 

Posted

Hi this may not be a solution, but the reason the 1.6.2 mod doesn't work with 1.6.4 is the obfuscation changes with each Minecraft version, so to make his mod compatible with 1.6.4 you have to fix all the references to obfuscated code.  The mappings can be found in the MCP files he mentioned (*.cvs and *.srg I think?).  Core mods always have to be updated for every new Minecraft version (sv.class in 1.6.2 could be gj.class in 1.6.4).

Posted

Thanks a lot for answers, sorry for being busy lately.

 

Yes, I have noted that the classes may change obfuscated names between minecraft updates. But that does not seem to be the problem... I have changed them to their right name, but still it won't work!

 

Although, I ran some test with the 1.6.2 version of the mod and noted that the mod doesn't show up in the mods list if it can't find which class to override. So now I am pretty convinced that the problem has to do with the mod not finding the obfuscated classes.

 

GotoLink, by "using searge names" you must mean adding some code so that minecraft with my mod can guess on its own which obfuscated class to override out from the searge name. Since I'm not a very experienced programmer, I think I'll have a hard time figuring out this piece of code by myself.

 

There must have been some path changes for the obfuscated classes since 1.6.4, or am I totally wrong?

Please keep replying!  :)

 

Posted

NO use the compile to SRG .bat to compile to serge Names. also try putting it in the mods folder that changed between one update can't remember if it was the 1.5.2 to 1.6.2 of what.

Posted

Chibill,

 

Eeerrr... I know that by running reobfuscate_srg.bat, I will make mcp create folders and class files with their serge names. What of it? When running minecraft with a core mod outside Eclipse, the core mod cannot refer to someting like: "net.minecraft.entity.monster.EntityCreeper" or even "EntityCreeper", because the classes are recompiled. Instead the mod must refer to it's compiled name: "tf" ("te" in 1.6.2)

Please tell me I'm wrong if I am.

 

The mod "Creeperburn" has no problem overriding "te.class" in 1.6.2

Same mod seems to not be able to find and override "tf.class" in 1.6.4 (Of course it cannot override te.class)

 

Of course I know that core mods no longer goes into the "core mods" folder but the "mods" folder nowadays!

 

I am not sure I got your message right, it was quite short.

Posted

Hahahaha! I solved the issue! (It was so basic I almost feed ashamed)

 

At the top of the CBFMLLoadingPlugin class there is a line that says:

@MCVersion(value = "1.6.2")

 

You must change it to 1.6.4, or else the mod will be ignored in 1.6.4

 

A little bit ashamed but very happy

/jacard

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.