Resource pack is not able to override vanilla text in en_us.json

[cwJn]

I am using a resource pack to override a few names of attributes and items from vanilla Minecraft. The pack is correctly formatted and loads fine, and even other lines of text in the same file work properly. The resourcepack is at the top of the loadorder for resourcepacks, which, as far as I know, means it has highest priority in terms of overrides. My game is set on the correct language, that being American english. Does anyone know what the problem could be? Below is a screenshot of the pack file structure, and below that is the contents of en_us.json. Thanks!

https://gyazo.com/ad37cf5601c5429f6df4506620488784

{
  "attribute.name.generic.attack_damage": "Physical Damage",
  "attribute.name.generic.armor": "Physical Defence",
  "attribute.name.generic.armor_toughness": "Weight",
  "effect.minecraft.fire_resistance": "Flame Immunity",
  "item.minecraft.tipped_arrow.effect.fire_resistance": "Arrow of Flame Immunity",
  "item.minecraft.potion.effect.fire_resistance": "Potion of Flame Immunity",
  "item.minecraft.splash_potion.effect.fire_resistance": "Splash Potion of Flame Immunity",
  "item.minecraft.lingering_potion.effect.fire_resistance": "Lingering Potion of Flame Immunity"
}

 

[warjort]

Duplicate of

 

[cwJn]

40 minutes ago, warjort said:

Duplicate of

 

I had already tried what you recommended on this post and it didn't work. I tried to use a resource pack instead which afaik should be able to override vanilla assets but for some reason can't in my case.

[warjort]

You can look at what order things get loaded by clicking "resource packs" in the client's options menu.

The initial order comes from the mod ordering and vanilla's default policy.

 

NOTE: This order gets saved in your options.txt and that order will be used "forever" when you have changed it once (this might be your problem?).

The "forever" is quoted because adding/removing mods can change it.

[cwJn]

21 minutes ago, warjort said:

You can look at what order things get loaded by clicking "resource packs" in the client's options menu.

The initial order comes from the mod ordering and vanilla's default policy.

 

NOTE: This order gets saved in your options.txt and that order will be used "forever" when you have changed it once (this might be your problem?).

The "forever" is quoted because adding/removing mods can change it.

The pack I made is at the top of the load order and therefore should have top priority over game resources. I've also checked whether or not the file works at all by overriding localizations from my own mod, and that works fine.

EDIT:

The problem was Archaeology API. I took a look at their source code and for some reason they include the entire minecraft lang file in their resources. I still have no idea why I can't override it, but at this point I'm too burnt out to care.

Edited December 28, 2023 by cwJn
Solution found

[warjort]

Don't know then.

I suggest you post a bug report with instructions on how to reproduce it (i.e. include a minimal resource pack that has the problem).

https://github.com/MinecraftForge/MinecraftForge/issues

 

[warjort]

I suspect this has something to do with that mod "moving" the language entries to its namespace?

Quote

https://github.com/min2222/Archaeology-API/blob/main/src/main/resources/assets/archaeology/lang/en_us.json

 

The minecraft language loader loads things in groups by namespace, but the actual ordering of namespaces comes from a HashMap, so the ordering is effectively random.

See MultiPackResourceManager.getNamespaces() and its constructor.

 

I bet if you put your lang file in the "archeaology" folder/namespace instead of "minecraft" it would work?

You should report this is a bug to that mod. The above file should be in assets/minecraft

Edited December 28, 2023 by warjort