Jump to content

[1.20.2] How can I create a fake player for loot params ?


Sweetmimike

Recommended Posts

Hello,

 

I'm currently updated my mod from 1.18.2 version to 1.20.2, and I was used to use the "FakePlayerFactory" that seems to have disappear in the 1.20.2 version.

This is how I created fake players.

	protected LivingEntity getOrCreateFakePlayer() {
        if (fakePlayer == null) {
            fakePlayer = FakePlayerFactory.getMinecraft((ServerLevel) this.level);
        }
        return fakePlayer;
    }

 

These fake players where used as parameters for creating a "LootParams" object like this :

protected LootParams constructLootParams(Mob mob) {
    Vec3 position = new Vec3(getBlockPos().getX(), getBlockPos().getY(), getBlockPos().getZ());
    Player fakePlayer = (Player) getOrCreateFakePlayer();

    return new LootParams.Builder((ServerLevel) this.level).withParameter(LootContextParams.ORIGIN, position)
      .withParameter(LootContextParams.THIS_ENTITY, mob)
      .withParameter(LootContextParams.DAMAGE_SOURCE, fakePlayer.damageSources().genericKill())
      .withParameter(LootContextParams.KILLER_ENTITY, fakePlayer)
      .withParameter(LootContextParams.LAST_DAMAGE_PLAYER, fakePlayer)
      .create(LootContextParamSets.ENTITY);
}

 So I would like to know if it is still possible to create fake players and if yes how ? And if not, how am I supposed to create the loot params in order to make it like it is a player that killed the entity ?

 

Thanks,

Edited by Sweetmimike
Link to comment
Share on other sites

  • Sweetmimike changed the title to [1.20.2] How can I create a fake player for loot params ?

https://github.com/MinecraftForge/MinecraftForge/commit/90dafb0df0651b52102e25f6a252554cde884878

Quote

Rewrite our GameTest hooks to be sane.

Add game test to GlobalLootModifierTest which validates the smelting modifiers.

Removed FakePlayer system, it's broken and needs a major rewrite.

 I would guess Mojang's recent changes to networking are what broke that implementation?

i.e. the NetHandler/DummyConnection no longer works properly and no one has volunteered to fix it.

 

A fake player is something that extends ServerPlayer but makes most methods do nothing - the implementation that got deleted if you want to have a go at fixing it:

https://github.com/MinecraftForge/MinecraftForge/blob/d80f106140b30813432808f8b94da4d66e76dbfe/src/main/java/net/minecraftforge/common/util/FakePlayerFactory.java

https://github.com/MinecraftForge/MinecraftForge/blob/d80f106140b30813432808f8b94da4d66e76dbfe/src/main/java/net/minecraftforge/common/util/FakePlayer.java
 

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.