1.20.4 [1.20.4] Config file not working for ShieldItem

[Rajhab]

Hello. I am trying to read the value (durability) from a config file for an Shield Item. I cant get the code to work and i need some help. So I just need help on how to call the value from the config file. The code from the Config file works absolutely fine. Here is the code of my Shield Item getting registered and getting the Properties.

 

public static final DeferredItem<Item> LEATHER_SHIELD = ITEMS.register("leather_shield", 
  () -> new ShieldItem(new Item.Properties().durability(MoreVanillaShieldsConfig.LEATHER_SHIELD_DURABILITY.get())){ 
  
  
      @Override public int getMaxDamage(ItemStack stack) {
        return MoreVanillaShieldsConfig.LEATHER_SHIELD_DURABILITY.get();
      } 
    
 });

 

[warjort]

You cannot access config during registration.

https://forge.gemwire.uk/wiki/Stages_of_Modloading

https://forge.gemwire.uk/wiki/Configs

  Quote

NOTE: Forge will only update the values of your config fields in code after the registry events are finished. Therefore, you should only attempt to grab the config values after the registry events are completed. (FMLCommonSetupEvent and later are safe)

Expand  

 

As I said on your hijack of the other thread, this question has been asked and answered many times before.

You can use search instead of posting repeat questions.

 

In your case, that config needs to be a server config so that client and server agree on what the durability is. Otherwise you will get inconsistencies.

 

Basicially the value won't be known until the player joins the server, either loading a world in single player world or joining a remote server.

That also means different single player worlds can set different values (like how game rules work).

 

In your registration of the item you should set it some default value so the game knows the item has durablity.

It does not matter what value you set as long as it not zero which would mean the item has no durability.

That value won't actually be used because you have overridden the method to get the value from somewhere else.

Edited January 6, 2024 by warjort

[warjort]

Also if you want help with your code, you need to post reproducable examples of the problem on github.

Not small snippets of code in the forum that contain that have no context.

[Rajhab]

  On 1/6/2024 at 9:00 PM, warjort said:

You cannot access config during registration.

https://forge.gemwire.uk/wiki/Stages_of_Modloading

https://forge.gemwire.uk/wiki/Configs

 

As I said on your hijack of the other thread, this question has been asked and answered many times before.

You can use search instead of posting repeat questions.

 

In your case, that config needs to be a server config so that client and server agree on what the durability is. Otherwise you will get inconsistencies.

 

Basicially the value won't be known until the player joins the server, either loading a world in single player world or joining a remote server.

That also means different single player worlds can set different values (like how game rules work).

 

In your registration of the item you should set it some default value so the game knows the item has durablity.

It does not matter what value you set as long as it not zero which would mean the item has no durability.

That value won't actually be used because you have overridden the method to get the value from somewhere else.

Expand  

Thanks for your information. Gonna try that out