Jump to content

Item id check not working with custom item


Toblexson

Recommended Posts

I am making a block which holds music disks or my own special item. The music disks can be placed inside the inventory but my item cannot. Here is the 'isItemValidForSlot' method for the tile entity:

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack) {
	return itemstack.itemID == soundcontrol.item.ItemInfo.DISKSLEEVE_ID || itemstack.itemID == Item.record11.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.recordBlocks.itemID || itemstack.itemID == Item.recordCat.itemID || itemstack.itemID == Item.recordChirp.itemID || itemstack.itemID == Item.recordFar.itemID || itemstack.itemID == Item.recordMall.itemID || itemstack.itemID == Item.recordMellohi.itemID || itemstack.itemID == Item.recordStal.itemID || itemstack.itemID == Item.recordStrad.itemID || itemstack.itemID == Item.recordWait.itemID || itemstack.itemID == Item.recordWard.itemID;
}

 

The first option, for the disksleeve item, is the one I am having trouble with. The code for the slot which is used in the container/inventory is identical.

 

Please help because I cannot think of what could be wrong.

 

 

Link to comment
Share on other sites

Sorry, I am new to modding, but what is the item instance item id and how would I use it?

 

Items are singletons and inherit from the class Item.

Classes have instances called instance objects.

itemID is a non-static public property of the Item class.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Sorry, I am new to modding, but what is the item instance item id and how would I use it?

 

Items are singletons and inherit from the class Item.

Classes have instances called instance objects.

itemID is a non-static public property of the Item class.

 

Thanks

I think I get what you mean, I needed to reference the item where I have initialised it rather than the actual class. I've done this and now it works.

@Override
public boolean isItemValid(ItemStack itemstack) {
	return itemstack.itemID == Items.disksleeve.itemID || itemstack.itemID == Item.record11.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.recordBlocks.itemID || itemstack.itemID == Item.recordCat.itemID || itemstack.itemID == Item.recordChirp.itemID || itemstack.itemID == Item.recordFar.itemID || itemstack.itemID == Item.recordMall.itemID || itemstack.itemID == Item.recordMellohi.itemID || itemstack.itemID == Item.recordStal.itemID || itemstack.itemID == Item.recordStrad.itemID || itemstack.itemID == Item.recordWait.itemID || itemstack.itemID == Item.recordWard.itemID; 
}

Link to comment
Share on other sites

You can also check for item equivalence.

 

itemstack.getItem() == Items.disksleeve

 

For instance.  Which is how things will work come 1.7

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello there! I am trying to make custom dimensions for a modpack I am making in an older minecraft version, 1.16.5. I like that version and it has a few other mods that have not been updated that I would still like to use. Anyway, I am having a terrible time with getting my dimension to work and have tried using code from other peoples projects to at least figure out what I'm supposed to be doing but it has not been as helpful as I would have liked. If anyone could help that would be greatly appreciated! Here is my github with all the code as I am using it: https://github.com/BladeColdsteel/InvigoratedDimensionsMod I have also included the last log, https://pastebin.com/zX9vsDSq, I had when I tried to load up a world, let me know if there is anything else I should send though, thank you!
    • Whether you are a fan of Hypixel Bedwars, SkyWars and PvP gamemodes like that, well you would enjoy this server! We have a very fun and unique style of PvP that a lot of our players really enjoy and we want to bring this server to more players like you! Yes you reading this post haha. Introducing, the Minezone Network, home of SUPER CRAFT BLOCKS. We've been working on this server for over 4 years now. Here is what we have to offer: SUPER CRAFT BLOCKS: This has 3 different gamemodes you can play, Classic, Duels and Frenzy. Each mode offers over 60 kits to choose from, along with a total of over 60 maps, allowing for various different playstyles on each map. There are also random powerups that spawn on the map which can include Health Pots, Bazookas, Nukes, Extra Lives and way way more! There is also double jump in this gamemode as well, which makes PvP a lot more fun & unique. You only need a minimum of 2 players to start any mode! Classic: Choose a kit, 5 lives for each player, fight it out and claim the #1 spot! Look out for lightning as they can spawn powerups to really give you an advantage in the game! Duels: Fight against another random player or one of your friends and see who is the best! Frenzy: Your kit is randomly selected for you, each life you will have a different kit. You can fight with up to 100 players in this mode and lets see who will be the best out of that 100! All the other stuff from Classic/Duels apply to this mode as well like powerups. We have 2 ranks on this server too, VIP and CAPTAIN which has a bunch of different perks for SCB and other things like Cosmetics and more.   SERVER IP: If this server has caught your interest in any way, please consider joining and you will NOT regret it! Bring some of your friends online for an even better experience and join in on the fun at: IP: minezone.club Hope to see you online!   SERVER TRAILER: https://www.youtube.com/watch?v=0phpMgu1mH0
    • The mod give new blocks  
    • I will a Mode for 1.21 in this Mod give new block, items and dimensions   
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.