Jump to content

[1.6.4] Game crashing when using a NBT


gmod622

Recommended Posts

When I load up a world and hover over my item, I crash with this error :

 

 

 2014-01-05 18:18:30 [iNFO] [sTDOUT] java.lang.NullPointerException
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at gmod.mods.roleplay.main.common.item.ItemLicence.addInformation(ItemLicence.java:54)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.item.ItemStack.getTooltip(ItemStack.java:663)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainer.drawItemStackTooltip(GuiContainer.java:226)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainerCreative.drawItemStackTooltip(GuiContainerCreative.java:778)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainer.drawScreen(GuiContainer.java:202)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.renderer.InventoryEffectRenderer.drawScreen(InventoryEffectRenderer.java:43)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainerCreative.drawScreen(GuiContainerCreative.java:683)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1036)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:946)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.run(Minecraft.java:838)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.main.Main.main(Main.java:93)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at java.lang.reflect.Method.invoke(Unknown Source)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:131)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.launchwrapper.Launch.main(Launch.java:27)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 
2014-01-05 18:18:30 [iNFO] [sTDOUT] 
2014-01-05 18:18:30 [iNFO] [sTDOUT] A detailed walkthrough of the error, its code path and all known details is as follows:
2014-01-05 18:18:30 [iNFO] [sTDOUT] ---------------------------------------------------------------------------------------
2014-01-05 18:18:30 [iNFO] [sTDOUT] 
2014-01-05 18:18:30 [iNFO] [sTDOUT] -- Head --
2014-01-05 18:18:30 [iNFO] [sTDOUT] Stacktrace:
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at gmod.mods.roleplay.main.common.item.ItemLicence.addInformation(ItemLicence.java:54)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.item.ItemStack.getTooltip(ItemStack.java:663)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainer.drawItemStackTooltip(GuiContainer.java:226)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainerCreative.drawItemStackTooltip(GuiContainerCreative.java:778)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainer.drawScreen(GuiContainer.java:202)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.renderer.InventoryEffectRenderer.drawScreen(InventoryEffectRenderer.java:43)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 	at net.minecraft.client.gui.inventory.GuiContainerCreative.drawScreen(GuiContainerCreative.java:683)
2014-01-05 18:18:30 [iNFO] [sTDOUT] 

 

 

My item code:

 

 

 package gmod.mods.roleplay.main.common.item;


import gmod.mods.roleplay.main.main_roleplay;

import java.util.List;



import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;

public class ItemLicence extends Item {

public ItemLicence(int par1) {
	super(par1);
	this.setCreativeTab(main_roleplay.tabRoleplay);
}

public static int theRandom;


 public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
	//here you can use the information about the itemstack nbt
	//ex:


	 if(par1ItemStack.stackTagCompound == null){
		//here we know the nbt is null
		 par1ItemStack.stackTagCompound = new NBTTagCompound();
		}else {

		 theRandom = par1ItemStack.stackTagCompound.getInteger("myRandomNumber");
			if(theRandom == 0){
				//here we DONT have anythin on the stack compound
				par1ItemStack.stackTagCompound.setInteger("myRandomNumber", (int)(Math.random()*100000));//generate a number between 0-100 and place it on the nbt
			}else{
			//	System.out.println("the number of this item is: "+theRandom);
			}
 }


			return par1ItemStack;

 }
 public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4)
 {
	        NBTTagCompound stackCompound = par1ItemStack.getTagCompound();
	        int idToDisplay = stackCompound.getInteger("myRandomNumber");
	        par3List.add("ID: " + idToDisplay);
	    }




}

 

 

 

 

Any help be appreciated

Not new to java >> New to modding.

Link to comment
Share on other sites

Well...if you never right-click it (which checks the nbt tag for null and if it is, sets values) what did you EXPECT to happen?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

how would I stop from it becoming null, ive already tried to check if the random number is equal to 0 execute the command, and ive tried using the nbt and checking if is(not) equal to 0, then do the command give; the code is  shown here (THIS DOES NOT WORK; EXAMPLE) :

 

      
public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4) {
    
    		if(par1ItemStack.stackTagCompound.getInteger("myRandomNumber") /* != */ == 0) {
    	NBTTagCompound stackCompound = par1ItemStack.getTagCompound(); 
        int idToDisplay = par1ItemStack.stackTagCompound.getInteger("myRandomNumber");
        par3List.add("ID: " + idToDisplay);
    		}
      }

Not new to java >> New to modding.

Link to comment
Share on other sites

It's not BECOMING null, it hasn't ever been SET YET.  The variable DOES NOT EXIST for you to see if it is not-zero.

 

Order of operations, dude.

 

if(par1ItemStack.stackTagCompound.getInteger("myRandomNumber") /* != */ == 0) {

 

THIS WILL FAIL BECAUSE stackTagCompound IS NULL RIGHT NOW.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

if(par1ItemStack.stackTagCompound.getInteger("myRandomNumber") != null)

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.