FluidTank NBT not saving

[chbachman]

I have read so many of the posts where people just stick the two lines of code that they think are causing the problem, and tell others to fix it. I am sorry if this comes off as one of those posts, but i am using code borrowed from build craft for saving the nbt of my tank and it is not working, and i cannot figure out why, because it traces back to code from KingLemming.

 

 

This is my nbt saving code:

 

the class extends the FluidTank class

 

@Override

public final NBTTagCompound writeToNBT(NBTTagCompound nbt) {

NBTTagCompound tankData = new NBTTagCompound();

super.writeToNBT(tankData);

this.writeTankToNBT(tankData);

nbt.setCompoundTag(this.name, tankData);

return nbt;

}

 

@Override

public final FluidTank readFromNBT(NBTTagCompound nbt) {

if (nbt.hasKey(this.name)) {

NBTTagCompound tankData = nbt.getCompoundTag(this.name);

super.readFromNBT(tankData);

this.readTankFromNBT(tankData);

}

return this;

}

 

 

public void writeTankToNBT(NBTTagCompound nbt) {

 

}

 

public void readTankFromNBT(NBTTagCompound nbt) {

 

}

 

Thank you for your time.

 

[Draco18s]

@Override

  public final NBTTagCompound writeToNBT(NBTTagCompound nbt) {

      NBTTagCompound tankData = new NBTTagCompound();

      super.writeToNBT(tankData);

      this.writeTankToNBT(tankData);

      nbt.setCompoundTag(this.name, tankData);

      return nbt;

  }

 

Woah.  Slow down.

 

First, you've unneccessarily duplicated your functions.  You shouldn't need the

 this.writeTankToNBT(tankData);

part at all (not to mention that that function is empty and does nothing).

Second, you've marked that function as final.  You don't need that.  In fact, probably shouldn't have it.

 

I have half a mind saying that because you marked it as final, the function signature changed and it's no longer overriding.  Though my other half says not.  Either way, you don't need it.

 

Third, don't use

this.name

as a key...you can't be sure that that name won't change between a save and a load...

[chbachman]

ok i fixed up the method, but the nbt is still not saving. I am sorry for asking, but i have been trying to figure this out for a week.

 

Here is the total source code:

https://github.com/chbachman/ModularStorage

with the relevant code here (i think):

https://github.com/chbachman/ModularStorage/blob/master/common/io/github/chbachman/fluid/Tank.java

and here:

https://github.com/chbachman/ModularStorage/blob/master/common/io/github/chbachman/blocks/modulartank/TileModularTank.java

 

Thank you for your help