Jump to content

Recommended Posts

Posted

I've seen a couple posts about this but so far I haven't seen an actual working fix for it, unless I am doing something wrong. Whenever I shoot my custom arrow, it just hits me. From what I have seen in other posts, it's because the arrow is being spawned right where the player is standing therefore hits the player? Problem is I do not know how to fix this. Any help? (I am extending from IThrowableEntity as a suggested fix, but still no difference.)

 

Entity:

 

public class EntityRuneArrow extends EntityArrow implements IThrowableEntity

{

    private int xTile = -1;

    private int yTile = -1;

    private int zTile = -1;

    private int inTile;

    private int inData;

    private boolean inGround;

 

    /** 1 if the player can pick up the arrow */

    public int canBePickedUp;

 

    /** Seems to be some sort of timer for animating an arrow. */

    public int arrowShake;

 

    /** The owner of this arrow. */

    public Entity shootingEntity;

    private int ticksInGround;

    private int ticksInAir;

    private double damage = 4.0D;

 

    /** The amount of knockback an arrow applies when it hits a mob. */

    private int knockbackStrength;

 

    public EntityRuneArrow(World par1World)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.setSize(0.5F, 0.5F);

    }

 

    public EntityRuneArrow(World par1World, double par2, double par4, double par6)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.setSize(0.5F, 0.5F);

        this.setPosition(par2, par4, par6);

        this.yOffset = 0.0F;

    }

 

    public EntityRuneArrow(World par1World, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase, float par4, float par5)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.shootingEntity = par2EntityLivingBase;

 

        if (par2EntityLivingBase instanceof EntityPlayer)

        {

            this.canBePickedUp = 1;

        }

 

        this.posY = par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight() - 0.10000000149011612D;

        double d0 = par3EntityLivingBase.posX - par2EntityLivingBase.posX;

        double d1 = par3EntityLivingBase.boundingBox.minY + (double)(par3EntityLivingBase.height / 3.0F) - this.posY;

        double d2 = par3EntityLivingBase.posZ - par2EntityLivingBase.posZ;

        double d3 = (double)MathHelper.sqrt_double(d0 * d0 + d2 * d2);

 

        if (d3 >= 1.0E-7D)

        {

            float f2 = (float)(Math.atan2(d2, d0) * 180.0D / Math.PI) - 90.0F;

            float f3 = (float)(-(Math.atan2(d1, d3) * 180.0D / Math.PI));

            double d4 = d0 / d3;

            double d5 = d2 / d3;

            this.setLocationAndAngles(par2EntityLivingBase.posX + d4, this.posY, par2EntityLivingBase.posZ + d5, f2, f3);

            this.yOffset = 0.0F;

            float f4 = (float)d3 * 0.2F;

            this.setThrowableHeading(d0, d1 + (double)f4, d2, par4, par5);

        }

    }

 

    public EntityRuneArrow(World par1World, EntityLivingBase par2EntityLivingBase, float par3)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.shootingEntity = par2EntityLivingBase;

 

        if (par2EntityLivingBase instanceof EntityPlayer)

        {

            this.canBePickedUp = 1;

        }

 

        this.setSize(0.5F, 0.5F);

        this.setLocationAndAngles(par2EntityLivingBase.posX, par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight(), par2EntityLivingBase.posZ, par2EntityLivingBase.rotationYaw, par2EntityLivingBase.rotationPitch);

        this.posX -= (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

        this.posY -= 0.10000000149011612D;

        this.posZ -= (double)(MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

        this.setPosition(this.posX, this.posY, this.posZ);

        this.yOffset = 0.0F;

        this.motionX = (double)(-MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

        this.motionZ = (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

        this.motionY = (double)(-MathHelper.sin(this.rotationPitch / 180.0F * (float)Math.PI));

        this.setThrowableHeading(this.motionX, this.motionY, this.motionZ, par3 * 1.5F, 1.0F);

    }

 

    protected void entityInit()

    {

        this.dataWatcher.addObject(16, Byte.valueOf((byte)0));

    }

 

    /**

    * Similar to setArrowHeading, it's point the throwable entity to a x, y, z direction.

    */

    public void setThrowableHeading(double par1, double par3, double par5, float par7, float par8)

    {

        float f2 = MathHelper.sqrt_double(par1 * par1 + par3 * par3 + par5 * par5);

        par1 /= (double)f2;

        par3 /= (double)f2;

        par5 /= (double)f2;

        par1 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par3 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par5 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par1 *= (double)par7;

        par3 *= (double)par7;

        par5 *= (double)par7;

        this.motionX = par1;

        this.motionY = par3;

        this.motionZ = par5;

        float f3 = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

        this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

        this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f3) * 180.0D / Math.PI);

        this.ticksInGround = 0;

    }

 

    @SideOnly(Side.CLIENT)

 

    /**

    * Sets the position and rotation. Only difference from the other one is no bounding on the rotation. Args: posX,

    * posY, posZ, yaw, pitch

    */

    public void setPositionAndRotation2(double par1, double par3, double par5, float par7, float par8, int par9)

    {

        this.setPosition(par1, par3, par5);

        this.setRotation(par7, par8);

    }

 

    @SideOnly(Side.CLIENT)

 

    /**

    * Sets the velocity to the args. Args: x, y, z

    */

    public void setVelocity(double par1, double par3, double par5)

    {

        this.motionX = par1;

        this.motionY = par3;

        this.motionZ = par5;

 

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

        {

            float f = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch;

            this.prevRotationYaw = this.rotationYaw;

            this.setLocationAndAngles(this.posX, this.posY, this.posZ, this.rotationYaw, this.rotationPitch);

            this.ticksInGround = 0;

        }

    }

 

    /**

    * Called to update the entity's position/logic.

    */

    public void onUpdate()

    {

        super.onUpdate();

 

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

        {

            float f = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f) * 180.0D / Math.PI);

        }

 

        int i = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

 

        if (i > 0)

        {

            Block.blocksList.setBlockBoundsBasedOnState(this.worldObj, this.xTile, this.yTile, this.zTile);

            AxisAlignedBB axisalignedbb = Block.blocksList.getCollisionBoundingBoxFromPool(this.worldObj, this.xTile, this.yTile, this.zTile);

 

            if (axisalignedbb != null && axisalignedbb.isVecInside(this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ)))

            {

                this.inGround = true;

            }

        }

 

        if (this.arrowShake > 0)

        {

            --this.arrowShake;

        }

 

        if (this.inGround)

        {

            int j = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

            int k = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

 

            if (j == this.inTile && k == this.inData)

            {

                ++this.ticksInGround;

 

                if (this.ticksInGround == 1200)

                {

                    this.setDead();

                }

            }

            else

            {

                this.inGround = false;

                this.motionX *= (double)(this.rand.nextFloat() * 0.2F);

                this.motionY *= (double)(this.rand.nextFloat() * 0.2F);

                this.motionZ *= (double)(this.rand.nextFloat() * 0.2F);

                this.ticksInGround = 0;

                this.ticksInAir = 0;

            }

        }

        else

        {

            ++this.ticksInAir;

            Vec3 vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

            Vec3 vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

            MovingObjectPosition movingobjectposition = this.worldObj.rayTraceBlocks_do_do(vec3, vec31, false, true);

            vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

            vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

 

            if (movingobjectposition != null)

            {

                vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(movingobjectposition.hitVec.xCoord, movingobjectposition.hitVec.yCoord, movingobjectposition.hitVec.zCoord);

            }

 

            Entity entity = null;

            List list = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.addCoord(this.motionX, this.motionY, this.motionZ).expand(1.0D, 1.0D, 1.0D));

            double d0 = 0.0D;

            int l;

            float f1;

 

            for (l = 0; l < list.size(); ++l)

            {

                Entity entity1 = (Entity)list.get(l);

 

                if (entity1.canBeCollidedWith() && (entity1 != this.shootingEntity || this.ticksInAir >= 5))

                {

                    f1 = 0.3F;

                    AxisAlignedBB axisalignedbb1 = entity1.boundingBox.expand((double)f1, (double)f1, (double)f1);

                    MovingObjectPosition movingobjectposition1 = axisalignedbb1.calculateIntercept(vec3, vec31);

 

                    if (movingobjectposition1 != null)

                    {

                        double d1 = vec3.distanceTo(movingobjectposition1.hitVec);

 

                        if (d1 < d0 || d0 == 0.0D)

                        {

                            entity = entity1;

                            d0 = d1;

                        }

                    }

                }

            }

 

            if (entity != null)

            {

                movingobjectposition = new MovingObjectPosition(entity);

            }

 

            if (movingobjectposition != null && movingobjectposition.entityHit != null && movingobjectposition.entityHit instanceof EntityPlayer)

            {

                EntityPlayer entityplayer = (EntityPlayer)movingobjectposition.entityHit;

 

                if (entityplayer.capabilities.disableDamage || this.shootingEntity instanceof EntityPlayer && !((EntityPlayer)this.shootingEntity).canAttackPlayer(entityplayer))

                {

                    movingobjectposition = null;

                }

            }

 

            float f2;

            float f3;

 

            if (movingobjectposition != null)

            {

                if (movingobjectposition.entityHit != null)

                {

                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

                    int i1 = MathHelper.ceiling_double_int((double)f2 * this.damage);

 

                    if (this.getIsCritical())

                    {

                        i1 += this.rand.nextInt(i1 / 2 + 2);

                    }

 

                    DamageSource damagesource = null;

 

                    if (this.shootingEntity == null)

                    {

                        damagesource = EntityRuneArrow.causeRuneArrowDamage(this, this);

                    }

                    else

                    {

                        damagesource = EntityRuneArrow.causeRuneArrowDamage(this, this.shootingEntity);

                       

                    }

 

                    if (this.isBurning() && !(movingobjectposition.entityHit instanceof EntityEnderman))

                    {

                        movingobjectposition.entityHit.setFire(5);

                    }

 

                    if (movingobjectposition.entityHit.attackEntityFrom(damagesource, (float)i1))

                    {

                        if (movingobjectposition.entityHit instanceof EntityLivingBase)

                        {

                            EntityLivingBase entitylivingbase = (EntityLivingBase)movingobjectposition.entityHit;

 

                            if (!this.worldObj.isRemote)

                            {

                                entitylivingbase.setArrowCountInEntity(entitylivingbase.getArrowCountInEntity() + 1);

                                entitylivingbase.addPotionEffect(new PotionEffect(Potion.wither.id, 200));

                            }

 

                            if (this.knockbackStrength > 0)

                            {

                                f3 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

 

                                if (f3 > 0.0F)

                                {

                                    movingobjectposition.entityHit.addVelocity(this.motionX * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3, 0.1D, this.motionZ * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3);

                                }

                            }

 

                            if (this.shootingEntity != null)

                            {

                                EnchantmentThorns.func_92096_a(this.shootingEntity, entitylivingbase, this.rand);

                            }

 

                            if (this.shootingEntity != null && movingobjectposition.entityHit != this.shootingEntity && movingobjectposition.entityHit instanceof EntityPlayer && this.shootingEntity instanceof EntityPlayerMP)

                            {

                                ((EntityPlayerMP)this.shootingEntity).playerNetServerHandler.sendPacketToPlayer(new Packet70GameEvent(6, 0));

                            }

                           

                         

                        }

                       

 

                        this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

 

                        if (!(movingobjectposition.entityHit instanceof EntityEnderman))

                        {

                            this.setDead();

                        }

                    }

                    else

                    {

                        this.motionX *= -0.10000000149011612D;

                        this.motionY *= -0.10000000149011612D;

                        this.motionZ *= -0.10000000149011612D;

                        this.rotationYaw += 180.0F;

                        this.prevRotationYaw += 180.0F;

                        this.ticksInAir = 0;

                    }

                }

                else

                {

                    this.xTile = movingobjectposition.blockX;

                    this.yTile = movingobjectposition.blockY;

                    this.zTile = movingobjectposition.blockZ;

                    this.inTile = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

                    this.inData = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

                    this.motionX = (double)((float)(movingobjectposition.hitVec.xCoord - this.posX));

                    this.motionY = (double)((float)(movingobjectposition.hitVec.yCoord - this.posY));

                    this.motionZ = (double)((float)(movingobjectposition.hitVec.zCoord - this.posZ));

                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

                    this.posX -= this.motionX / (double)f2 * 0.05000000074505806D;

                    this.posY -= this.motionY / (double)f2 * 0.05000000074505806D;

                    this.posZ -= this.motionZ / (double)f2 * 0.05000000074505806D;

                    this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

                    this.inGround = true;

                    this.arrowShake = 7;

                    this.setIsCritical(false);

 

                    if (this.inTile != 0)

                    {

                        Block.blocksList[this.inTile].onEntityCollidedWithBlock(this.worldObj, this.xTile, this.yTile, this.zTile, this);

                    }

                }

            }

 

            if (this.getIsCritical())

            {

                for (l = 0; l < 4; ++l)

                {

                    this.worldObj.spawnParticle("crit", this.posX + this.motionX * (double)l / 4.0D, this.posY + this.motionY * (double)l / 4.0D, this.posZ + this.motionZ * (double)l / 4.0D, -this.motionX, -this.motionY + 0.2D, -this.motionZ);

                }

            }

 

            this.posX += this.motionX;

            this.posY += this.motionY;

            this.posZ += this.motionZ;

            f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

            this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

 

            for (this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f2) * 180.0D / Math.PI); this.rotationPitch - this.prevRotationPitch < -180.0F; this.prevRotationPitch -= 360.0F)

            {

                ;

            }

 

            while (this.rotationPitch - this.prevRotationPitch >= 180.0F)

            {

                this.prevRotationPitch += 360.0F;

            }

 

            while (this.rotationYaw - this.prevRotationYaw < -180.0F)

            {

                this.prevRotationYaw -= 360.0F;

            }

 

            while (this.rotationYaw - this.prevRotationYaw >= 180.0F)

            {

                this.prevRotationYaw += 360.0F;

            }

 

            this.rotationPitch = this.prevRotationPitch + (this.rotationPitch - this.prevRotationPitch) * 0.2F;

            this.rotationYaw = this.prevRotationYaw + (this.rotationYaw - this.prevRotationYaw) * 0.2F;

            float f4 = 0.99F;

            f1 = 0.05F;

 

            if (this.isInWater())

            {

                for (int j1 = 0; j1 < 4; ++j1)

                {

                    f3 = 0.25F;

                    this.worldObj.spawnParticle("bubble", this.posX - this.motionX * (double)f3, this.posY - this.motionY * (double)f3, this.posZ - this.motionZ * (double)f3, this.motionX, this.motionY, this.motionZ);

                }

 

                f4 = 0.8F;

            }

 

            this.motionX *= (double)f4;

            this.motionY *= (double)f4;

            this.motionZ *= (double)f4;

            this.motionY -= (double)f1;

            this.setPosition(this.posX, this.posY, this.posZ);

            this.doBlockCollisions();

        }

    }

 

    /**

    * (abstract) Protected helper method to write subclass entity data to NBT.

    */

    public void writeEntityToNBT(NBTTagCompound par1NBTTagCompound)

    {

        par1NBTTagCompound.setShort("xTile", (short)this.xTile);

        par1NBTTagCompound.setShort("yTile", (short)this.yTile);

        par1NBTTagCompound.setShort("zTile", (short)this.zTile);

        par1NBTTagCompound.setByte("inTile", (byte)this.inTile);

        par1NBTTagCompound.setByte("inData", (byte)this.inData);

        par1NBTTagCompound.setByte("shake", (byte)this.arrowShake);

        par1NBTTagCompound.setByte("inGround", (byte)(this.inGround ? 1 : 0));

        par1NBTTagCompound.setByte("pickup", (byte)this.canBePickedUp);

        par1NBTTagCompound.setDouble("damage", this.damage);

    }

 

    /**

    * (abstract) Protected helper method to read subclass entity data from NBT.

    */

    public void readEntityFromNBT(NBTTagCompound par1NBTTagCompound)

    {

        this.xTile = par1NBTTagCompound.getShort("xTile");

        this.yTile = par1NBTTagCompound.getShort("yTile");

        this.zTile = par1NBTTagCompound.getShort("zTile");

        this.inTile = par1NBTTagCompound.getByte("inTile") & 255;

        this.inData = par1NBTTagCompound.getByte("inData") & 255;

        this.arrowShake = par1NBTTagCompound.getByte("shake") & 255;

        this.inGround = par1NBTTagCompound.getByte("inGround") == 1;

 

        if (par1NBTTagCompound.hasKey("damage"))

        {

            this.damage = par1NBTTagCompound.getDouble("damage");

        }

 

        if (par1NBTTagCompound.hasKey("pickup"))

        {

            this.canBePickedUp = par1NBTTagCompound.getByte("pickup");

        }

        else if (par1NBTTagCompound.hasKey("player"))

        {

            this.canBePickedUp = par1NBTTagCompound.getBoolean("player") ? 1 : 0;

        }

    }

 

    /**

    * Called by a player entity when they collide with an entity

    */

    public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)

    {

        if (!this.worldObj.isRemote && this.inGround && this.arrowShake <= 0)

        {

            boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2 && par1EntityPlayer.capabilities.isCreativeMode;

 

            if (this.canBePickedUp == 1 && !par1EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Item.arrow, 1)))

            {

                flag = false;

            }

 

            if (flag)

            {

                this.playSound("random.pop", 0.2F, ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);

                par1EntityPlayer.onItemPickup(this, 1);

                this.setDead();

            }

        }

    }

 

    /**

    * returns if this entity triggers Block.onEntityWalking on the blocks they walk on. used for spiders and wolves to

    * prevent them from trampling crops

    */

    protected boolean canTriggerWalking()

    {

        return false;

    }

 

    @SideOnly(Side.CLIENT)

    public float getShadowSize()

    {

        return 0.0F;

    }

 

    public void setDamage(double par1)

    {

        this.damage = par1;

    }

 

    public double getDamage()

    {

        return this.damage;

    }

 

    /**

    * Sets the amount of knockback the arrow applies when it hits a mob.

    */

    public void setKnockbackStrength(int par1)

    {

        this.knockbackStrength = par1;

    }

 

    /**

    * If returns false, the item will not inflict any damage against entities.

    */

    public boolean canAttackWithItem()

    {

        return false;

    }

 

    /**

    * Whether the arrow has a stream of critical hit particles flying behind it.

    */

    public void setIsCritical(boolean par1)

    {

        byte b0 = this.dataWatcher.getWatchableObjectByte(16);

 

        if (par1)

        {

            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 | 1)));

        }

        else

        {

            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 & -2)));

        }

    }

 

    /**

    * Whether the arrow has a stream of critical hit particles flying behind it.

    */

    public boolean getIsCritical()

    {

        byte b0 = this.dataWatcher.getWatchableObjectByte(16);

        return (b0 & 1) != 0;

    }

   

    public static DamageSource causeRuneArrowDamage(EntityRuneArrow par0EntityArrow, Entity par1Entity)

    {

        return (new EntityDamageSourceIndirect("arrow", par0EntityArrow, par1Entity)).setProjectile();

    }

 

    @Override

    public Entity getThrower() {

    return shootingEntity;

    }

 

    @Override

    public void setThrower(Entity entity) {

    this.shootingEntity = entity;

    }

 

Posted

Use an IDE to step through the code in debug. The following line looks like it is intended to prevent this from happening, so maybe something is wrong there, like shootingEntity being assigned the wrong reference or it taking long enough to clear the player for the second condition to be true?

 

if (entity1.canBeCollidedWith() && (entity1 != this.shootingEntity || this.ticksInAir >= 5))

Posted

I was having the same problem, and it seemed to be that custom arrows don't receive the same services as regular arrows, so the shooting entity wasn't in sync / didn't recognize the player as the shooter. Now I have no idea why that would happen, but I at least fixed the issue by adding my own shooter DataWatcher object:

 

/**
* Returns the shooter of this arrow or null if none was available
*/
public Entity getShooter() {
String name = dataWatcher.getWatchableObjectString(SHOOTER_DATAWATCHER_INDEX);
return (name.equals("") ? shootingEntity : worldObj.getPlayerEntityByName(name));
}

/**
* Used to update the datawatcher shooting entity object
*/
public EntityArrowCustom setShooter(EntityPlayer player) {
dataWatcher.updateObject(SHOOTER_DATAWATCHER_INDEX, player != null ? player.username : "");
return this;
}

Be sure to add the object during entityInit with the other datawatcher objects (add ""), and replace shootingEntity with getShooter() in your onUpdate and other non-constructor methods. Your arrow should no longer hit you.

Posted

alright so I need to add my own datawatcher to the EntityInit method, and it should look something like this I'm assuming?

this.dataWatcher.addObject(22, "SHOOTER_DATAWATCHER_INDEX"); 

 

I've switched out the shootingEntity references, and I am assuming I'm falling short on the whole Datawatcher thing? I haven't tried adding a DataWatcher before.

 

 

Posted

SHOOTER_DATAWATCHER_INDEX is just a static int I defined so if I need, I can quickly change the index (in case of a future conflict, for example).

 

If you don't know how to use DataWatcher, I suggest checking out the excellent wiki tutorial: http://www.minecraftforge.net/wiki/Datawatcher

 

Quick tip: the index comes first, then the value; and the value should initially be "" for no shooter. You set the shooter later.

Posted

I think I will understand it better if I were to see it in action.  All I can understand from the Tutorial is that I need a string type datawatcher, the string ending up being the players name? Could you show me what the code would look like in the EntityInit method?

 

Posted

Sure:

@Override
public void entityInit() {
super.entityInit();
dataWatcher.addObject(SHOOTER_DATAWATCHER_INDEX, "");
}

When you create your custom arrow using this method, though, you MUST call the 'setShooter(player)' method from earlier, as that is what updates the arrow's shooter:

// should look something like this:
EntityArrowCustom arrow = new EntityArrowCustom(world, player).setShooter(player);

Posted

Alright here is what I have. I wasn't able to get the code all worked out, but I believe I am close.

 

EntityArrow:

 

public class EntityRuneArrow extends EntityArrow implements IProjectile

{

    private int xTile = -1;

    private int yTile = -1;

    private int zTile = -1;

    private int inTile;

    private int inData;

    private boolean inGround;

 

    /** 1 if the player can pick up the arrow */

    public int canBePickedUp;

 

    /** Seems to be some sort of timer for animating an arrow. */

    public int arrowShake;

   

 

 

    /** The owner of this arrow. */

    public Entity shootingEntity;

    private int ticksInGround;

    private int ticksInAir;

    private double damage = 4.0D;

 

    /** The amount of knockback an arrow applies when it hits a mob. */

    private int knockbackStrength;

 

    public EntityRuneArrow(World par1World)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.setSize(0.5F, 0.5F);

    }

 

    public EntityRuneArrow(World par1World, double par2, double par4, double par6)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.setSize(0.5F, 0.5F);

        this.setPosition(par2, par4, par6);

        this.yOffset = 0.0F;

    }

 

    public EntityRuneArrow(World par1World, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase, float par4, float par5)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.shootingEntity = par2EntityLivingBase;

 

        if (par2EntityLivingBase instanceof EntityPlayer)

        {

            this.canBePickedUp = 1;

        }

 

        this.posY = par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight() - 0.10000000149011612D;

        double d0 = par3EntityLivingBase.posX - par2EntityLivingBase.posX;

        double d1 = par3EntityLivingBase.boundingBox.minY + (double)(par3EntityLivingBase.height / 3.0F) - this.posY;

        double d2 = par3EntityLivingBase.posZ - par2EntityLivingBase.posZ;

        double d3 = (double)MathHelper.sqrt_double(d0 * d0 + d2 * d2);

 

        if (d3 >= 1.0E-7D)

        {

            float f2 = (float)(Math.atan2(d2, d0) * 180.0D / Math.PI) - 90.0F;

            float f3 = (float)(-(Math.atan2(d1, d3) * 180.0D / Math.PI));

            double d4 = d0 / d3;

            double d5 = d2 / d3;

            this.setLocationAndAngles(par2EntityLivingBase.posX + d4, this.posY, par2EntityLivingBase.posZ + d5, f2, f3);

            this.yOffset = 0.0F;

            float f4 = (float)d3 * 0.2F;

            this.setThrowableHeading(d0, d1 + (double)f4, d2, par4, par5);

        }

    }

 

    public EntityRuneArrow(World par1World, EntityLivingBase par2EntityLivingBase, float par3)

    {

        super(par1World);

        this.renderDistanceWeight = 10.0D;

        this.shootingEntity = par2EntityLivingBase;

 

        if (par2EntityLivingBase instanceof EntityPlayer)

        {

            this.canBePickedUp = 1;

        }

 

        this.setSize(0.5F, 0.5F);

        this.setLocationAndAngles(par2EntityLivingBase.posX, par2EntityLivingBase.posY + (double)par2EntityLivingBase.getEyeHeight(), par2EntityLivingBase.posZ, par2EntityLivingBase.rotationYaw, par2EntityLivingBase.rotationPitch);

        this.posX -= (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

        this.posY -= 0.10000000149011612D;

        this.posZ -= (double)(MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * 0.16F);

        this.setPosition(this.posX, this.posY, this.posZ);

        this.yOffset = 0.0F;

        this.motionX = (double)(-MathHelper.sin(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

        this.motionZ = (double)(MathHelper.cos(this.rotationYaw / 180.0F * (float)Math.PI) * MathHelper.cos(this.rotationPitch / 180.0F * (float)Math.PI));

        this.motionY = (double)(-MathHelper.sin(this.rotationPitch / 180.0F * (float)Math.PI));

        this.setThrowableHeading(this.motionX, this.motionY, this.motionZ, par3 * 1.5F, 1.0F);

    }

 

    @Override

    protected void entityInit()

    {

    //super.entityInit();

        this.dataWatcher.addObject(16, Byte.valueOf((byte)0));

       

        this.dataWatcher.addObject(22, "");

        }

 

    /**

    * Similar to setArrowHeading, it's point the throwable entity to a x, y, z direction.

    */

    public void setThrowableHeading(double par1, double par3, double par5, float par7, float par8)

    {

        float f2 = MathHelper.sqrt_double(par1 * par1 + par3 * par3 + par5 * par5);

        par1 /= (double)f2;

        par3 /= (double)f2;

        par5 /= (double)f2;

        par1 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par3 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par5 += this.rand.nextGaussian() * (double)(this.rand.nextBoolean() ? -1 : 1) * 0.007499999832361937D * (double)par8;

        par1 *= (double)par7;

        par3 *= (double)par7;

        par5 *= (double)par7;

        this.motionX = par1;

        this.motionY = par3;

        this.motionZ = par5;

        float f3 = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

        this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

        this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f3) * 180.0D / Math.PI);

        this.ticksInGround = 0;

    }

 

    @SideOnly(Side.CLIENT)

 

    /**

    * Sets the position and rotation. Only difference from the other one is no bounding on the rotation. Args: posX,

    * posY, posZ, yaw, pitch

    */

    public void setPositionAndRotation2(double par1, double par3, double par5, float par7, float par8, int par9)

    {

        this.setPosition(par1, par3, par5);

        this.setRotation(par7, par8);

    }

 

    @SideOnly(Side.CLIENT)

 

    /**

    * Sets the velocity to the args. Args: x, y, z

    */

    public void setVelocity(double par1, double par3, double par5)

    {

        this.motionX = par1;

        this.motionY = par3;

        this.motionZ = par5;

 

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

        {

            float f = MathHelper.sqrt_double(par1 * par1 + par5 * par5);

            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(par1, par5) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(par3, (double)f) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch;

            this.prevRotationYaw = this.rotationYaw;

            this.setLocationAndAngles(this.posX, this.posY, this.posZ, this.rotationYaw, this.rotationPitch);

            this.ticksInGround = 0;

        }

    }

 

    /**

    * Called to update the entity's position/logic.

    */

    @Override

    public void onUpdate()

    {

        //super.onUpdate();

       

 

        if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)

        {

            float f = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

            this.prevRotationYaw = this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

            this.prevRotationPitch = this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f) * 180.0D / Math.PI);

        }

 

        int i = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

 

        if (i > 0)

        {

            Block.blocksList.setBlockBoundsBasedOnState(this.worldObj, this.xTile, this.yTile, this.zTile);

            AxisAlignedBB axisalignedbb = Block.blocksList.getCollisionBoundingBoxFromPool(this.worldObj, this.xTile, this.yTile, this.zTile);

 

            if (axisalignedbb != null && axisalignedbb.isVecInside(this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ)))

            {

                this.inGround = true;

            }

        }

 

        if (this.arrowShake > 0)

        {

            --this.arrowShake;

        }

 

        if (this.inGround)

        {

            int j = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

            int k = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

 

            if (j == this.inTile && k == this.inData)

            {

                ++this.ticksInGround;

 

                if (this.ticksInGround == 1200)

                {

                    this.setDead();

                }

            }

            else

            {

                this.inGround = false;

                this.motionX *= (double)(this.rand.nextFloat() * 0.2F);

                this.motionY *= (double)(this.rand.nextFloat() * 0.2F);

                this.motionZ *= (double)(this.rand.nextFloat() * 0.2F);

                this.ticksInGround = 0;

                this.ticksInAir = 0;

            }

        }

        else

        {

            ++this.ticksInAir;

            Vec3 vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

            Vec3 vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

            MovingObjectPosition movingobjectposition = this.worldObj.rayTraceBlocks_do_do(vec3, vec31, false, true);

            vec3 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX, this.posY, this.posZ);

            vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX + this.motionX, this.posY + this.motionY, this.posZ + this.motionZ);

 

            if (movingobjectposition != null)

            {

                vec31 = this.worldObj.getWorldVec3Pool().getVecFromPool(movingobjectposition.hitVec.xCoord, movingobjectposition.hitVec.yCoord, movingobjectposition.hitVec.zCoord);

            }

 

            Entity entity = null;

            List list = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox.addCoord(this.motionX, this.motionY, this.motionZ).expand(1.0D, 1.0D, 1.0D));

            double d0 = 0.0D;

            int l;

            float f1;

 

            for (l = 0; l < list.size(); ++l)

            {

                Entity entity1 = (Entity)list.get(l);

 

                if (entity1.canBeCollidedWith() && (entity1 != this.getShooter() || this.ticksInAir >= 5))

                {

                    f1 = 0.3F;

                    AxisAlignedBB axisalignedbb1 = entity1.boundingBox.expand((double)f1, (double)f1, (double)f1);

                    MovingObjectPosition movingobjectposition1 = axisalignedbb1.calculateIntercept(vec3, vec31);

 

                    if (movingobjectposition1 != null)

                    {

                        double d1 = vec3.distanceTo(movingobjectposition1.hitVec);

 

                        if (d1 < d0 || d0 == 0.0D)

                        {

                            entity = entity1;

                            d0 = d1;

                        }

                    }

                }

            }

 

            if (entity != null)

            {

                movingobjectposition = new MovingObjectPosition(entity);

            }

 

            if (movingobjectposition != null && movingobjectposition.entityHit != null && movingobjectposition.entityHit instanceof EntityPlayer)

            {

                EntityPlayer entityplayer = (EntityPlayer)movingobjectposition.entityHit;

 

                if (entityplayer.capabilities.disableDamage || this.getShooter() instanceof EntityPlayer && !((EntityPlayer)this.getShooter()).canAttackPlayer(entityplayer))

                {

                    movingobjectposition = null;

                }

            }

 

            float f2;

            float f3;

 

            if (movingobjectposition != null)

            {

                if (movingobjectposition.entityHit != null)

                {

                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

                    int i1 = MathHelper.ceiling_double_int((double)f2 * this.damage);

 

                    if (this.getIsCritical())

                    {

                        i1 += this.rand.nextInt(i1 / 2 + 2);

                    }

 

                    DamageSource damagesource = null;

 

                    if (this.getShooter() == null)

                    {

                        damagesource = EntityRuneArrow.causeRuneArrowDamage(this, this);

                    }

                    else

                    {

                        damagesource = EntityRuneArrow.causeRuneArrowDamage(this, this.getShooter());

                       

                    }

 

                    if (this.isBurning() && !(movingobjectposition.entityHit instanceof EntityEnderman))

                    {

                        movingobjectposition.entityHit.setFire(5);

                    }

 

                    if (movingobjectposition.entityHit.attackEntityFrom(damagesource, (float)i1))

                    {

                        if (movingobjectposition.entityHit instanceof EntityLivingBase)

                        {

                            EntityLivingBase entitylivingbase = (EntityLivingBase)movingobjectposition.entityHit;

 

                            if (!this.worldObj.isRemote)

                            {

                                entitylivingbase.setArrowCountInEntity(entitylivingbase.getArrowCountInEntity() + 1);

                                entitylivingbase.addPotionEffect(new PotionEffect(Potion.wither.id, 200));

                            }

 

                            if (this.knockbackStrength > 0)

                            {

                                f3 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

 

                                if (f3 > 0.0F)

                                {

                                    movingobjectposition.entityHit.addVelocity(this.motionX * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3, 0.1D, this.motionZ * (double)this.knockbackStrength * 0.6000000238418579D / (double)f3);

                                }

                            }

 

                            if (this.shootingEntity != null)

                            {

                                EnchantmentThorns.func_92096_a(this.getShooter(), entitylivingbase, this.rand);

                            }

 

                            if (this.getShooter() != null && movingobjectposition.entityHit != this.getShooter() && movingobjectposition.entityHit instanceof EntityPlayer && this.getShooter() instanceof EntityPlayerMP)

                            {

                                ((EntityPlayerMP)this.shootingEntity).playerNetServerHandler.sendPacketToPlayer(new Packet70GameEvent(6, 0));

                            }

                           

                         

                        }

                       

 

                        this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

 

                        if (!(movingobjectposition.entityHit instanceof EntityEnderman))

                        {

                            this.setDead();

                        }

                    }

                    else

                    {

                        this.motionX *= -0.10000000149011612D;

                        this.motionY *= -0.10000000149011612D;

                        this.motionZ *= -0.10000000149011612D;

                        this.rotationYaw += 180.0F;

                        this.prevRotationYaw += 180.0F;

                        this.ticksInAir = 0;

                    }

                }

                else

                {

                    this.xTile = movingobjectposition.blockX;

                    this.yTile = movingobjectposition.blockY;

                    this.zTile = movingobjectposition.blockZ;

                    this.inTile = this.worldObj.getBlockId(this.xTile, this.yTile, this.zTile);

                    this.inData = this.worldObj.getBlockMetadata(this.xTile, this.yTile, this.zTile);

                    this.motionX = (double)((float)(movingobjectposition.hitVec.xCoord - this.posX));

                    this.motionY = (double)((float)(movingobjectposition.hitVec.yCoord - this.posY));

                    this.motionZ = (double)((float)(movingobjectposition.hitVec.zCoord - this.posZ));

                    f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionY * this.motionY + this.motionZ * this.motionZ);

                    this.posX -= this.motionX / (double)f2 * 0.05000000074505806D;

                    this.posY -= this.motionY / (double)f2 * 0.05000000074505806D;

                    this.posZ -= this.motionZ / (double)f2 * 0.05000000074505806D;

                    this.playSound("random.bowhit", 1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));

                    this.inGround = true;

                    this.arrowShake = 7;

                    this.setIsCritical(false);

 

                    if (this.inTile != 0)

                    {

                        Block.blocksList[this.inTile].onEntityCollidedWithBlock(this.worldObj, this.xTile, this.yTile, this.zTile, this);

                    }

                }

            }

 

            if (this.getIsCritical())

            {

                for (l = 0; l < 4; ++l)

                {

                    this.worldObj.spawnParticle("crit", this.posX + this.motionX * (double)l / 4.0D, this.posY + this.motionY * (double)l / 4.0D, this.posZ + this.motionZ * (double)l / 4.0D, -this.motionX, -this.motionY + 0.2D, -this.motionZ);

                }

            }

 

            this.posX += this.motionX;

            this.posY += this.motionY;

            this.posZ += this.motionZ;

            f2 = MathHelper.sqrt_double(this.motionX * this.motionX + this.motionZ * this.motionZ);

            this.rotationYaw = (float)(Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

 

            for (this.rotationPitch = (float)(Math.atan2(this.motionY, (double)f2) * 180.0D / Math.PI); this.rotationPitch - this.prevRotationPitch < -180.0F; this.prevRotationPitch -= 360.0F)

            {

                ;

            }

 

            while (this.rotationPitch - this.prevRotationPitch >= 180.0F)

            {

                this.prevRotationPitch += 360.0F;

            }

 

            while (this.rotationYaw - this.prevRotationYaw < -180.0F)

            {

                this.prevRotationYaw -= 360.0F;

            }

 

            while (this.rotationYaw - this.prevRotationYaw >= 180.0F)

            {

                this.prevRotationYaw += 360.0F;

            }

 

            this.rotationPitch = this.prevRotationPitch + (this.rotationPitch - this.prevRotationPitch) * 0.2F;

            this.rotationYaw = this.prevRotationYaw + (this.rotationYaw - this.prevRotationYaw) * 0.2F;

            float f4 = 0.99F;

            f1 = 0.05F;

 

            if (this.isInWater())

            {

                for (int j1 = 0; j1 < 4; ++j1)

                {

                    f3 = 0.25F;

                    this.worldObj.spawnParticle("bubble", this.posX - this.motionX * (double)f3, this.posY - this.motionY * (double)f3, this.posZ - this.motionZ * (double)f3, this.motionX, this.motionY, this.motionZ);

                }

 

                f4 = 0.8F;

            }

 

            this.motionX *= (double)f4;

            this.motionY *= (double)f4;

            this.motionZ *= (double)f4;

            this.motionY -= (double)f1;

            this.setPosition(this.posX, this.posY, this.posZ);

            this.doBlockCollisions();

        }

    }

 

    /**

    * (abstract) Protected helper method to write subclass entity data to NBT.

    */

    public void writeEntityToNBT(NBTTagCompound par1NBTTagCompound)

    {

        par1NBTTagCompound.setShort("xTile", (short)this.xTile);

        par1NBTTagCompound.setShort("yTile", (short)this.yTile);

        par1NBTTagCompound.setShort("zTile", (short)this.zTile);

        par1NBTTagCompound.setByte("inTile", (byte)this.inTile);

        par1NBTTagCompound.setByte("inData", (byte)this.inData);

        par1NBTTagCompound.setByte("shake", (byte)this.arrowShake);

        par1NBTTagCompound.setByte("inGround", (byte)(this.inGround ? 1 : 0));

        par1NBTTagCompound.setByte("pickup", (byte)this.canBePickedUp);

        par1NBTTagCompound.setDouble("damage", this.damage);

    }

 

    /**

    * (abstract) Protected helper method to read subclass entity data from NBT.

    */

    public void readEntityFromNBT(NBTTagCompound par1NBTTagCompound)

    {

        this.xTile = par1NBTTagCompound.getShort("xTile");

        this.yTile = par1NBTTagCompound.getShort("yTile");

        this.zTile = par1NBTTagCompound.getShort("zTile");

        this.inTile = par1NBTTagCompound.getByte("inTile") & 255;

        this.inData = par1NBTTagCompound.getByte("inData") & 255;

        this.arrowShake = par1NBTTagCompound.getByte("shake") & 255;

        this.inGround = par1NBTTagCompound.getByte("inGround") == 1;

 

        if (par1NBTTagCompound.hasKey("damage"))

        {

            this.damage = par1NBTTagCompound.getDouble("damage");

        }

 

        if (par1NBTTagCompound.hasKey("pickup"))

        {

            this.canBePickedUp = par1NBTTagCompound.getByte("pickup");

        }

        else if (par1NBTTagCompound.hasKey("player"))

        {

            this.canBePickedUp = par1NBTTagCompound.getBoolean("player") ? 1 : 0;

        }

    }

 

    /**

    * Called by a player entity when they collide with an entity

    */

    public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)

    {

        if (!this.worldObj.isRemote && this.inGround && this.arrowShake <= 0)

        {

            boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2 && par1EntityPlayer.capabilities.isCreativeMode;

 

            if (this.canBePickedUp == 1 && !par1EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Main.RuneWoodArrow, 1)))

            {

                flag = false;

            }

 

            if (flag)

            {

                this.playSound("random.pop", 0.2F, ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);

                par1EntityPlayer.onItemPickup(this, 1);

                this.setDead();

            }

        }

    }

 

    /**

    * returns if this entity triggers Block.onEntityWalking on the blocks they walk on. used for spiders and wolves to

    * prevent them from trampling crops

    */

    protected boolean canTriggerWalking()

    {

        return false;

    }

 

    @SideOnly(Side.CLIENT)

    public float getShadowSize()

    {

        return 0.0F;

    }

 

    public void setDamage(double par1)

    {

        this.damage = par1;

    }

 

    public double getDamage()

    {

        return this.damage;

    }

 

    /**

    * Sets the amount of knockback the arrow applies when it hits a mob.

    */

    public void setKnockbackStrength(int par1)

    {

        this.knockbackStrength = par1;

    }

 

    /**

    * If returns false, the item will not inflict any damage against entities.

    */

    public boolean canAttackWithItem()

    {

        return false;

    }

 

    /**

    * Whether the arrow has a stream of critical hit particles flying behind it.

    */

    public void setIsCritical(boolean par1)

    {

        byte b0 = this.dataWatcher.getWatchableObjectByte(16);

 

        if (par1)

        {

            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 | 1)));

        }

        else

        {

            this.dataWatcher.updateObject(16, Byte.valueOf((byte)(b0 & -2)));

        }

    }

 

    /**

    * Whether the arrow has a stream of critical hit particles flying behind it.

    */

    public boolean getIsCritical()

    {

        byte b0 = this.dataWatcher.getWatchableObjectByte(16);

        return (b0 & 1) != 0;

    }

   

    public static DamageSource causeRuneArrowDamage(EntityRuneArrow par0EntityArrow, Entity par1Entity)

    {

        return (new EntityDamageSourceIndirect("arrow", par0EntityArrow, par1Entity)).setProjectile();

    }

 

    /**

    * Returns the shooter of this arrow or null if none was available

    */

    public Entity getShooter() {

    String name = dataWatcher.getWatchableObjectString(22);

    return (name.equals("") ? shootingEntity : worldObj.getPlayerEntityByName(name));

    }

   

    /**

    * Used to update the datawatcher shooting entity object

    */

    public EntityRuneArrow setShooter(EntityPlayer player) {

    dataWatcher.updateObject(new Byte((byte)0), player != null ? player.username : "");

    return this;

    }

}

 

 

CustomBow that spawns arrow:

 

public class RuneBow extends Item{

private Icon[] Texture = new Icon[4];

 

public RuneBow(int par1)

    {

        super(par1);

        this.maxStackSize = 1;

        this.setMaxDamage(800);

        this.setFull3D();

        this.setCreativeTab(Main.tabRunesMod);

    }

@Override

public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)

    {

        int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

        ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);

        MinecraftForge.EVENT_BUS.post(event);

 

        if (event.isCanceled())

        {

            return;

        }

 

        j = event.charge;

        boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

 

        if (flag || par3EntityPlayer.inventory.hasItem(Main.RuneWoodArrow.itemID));

        {

            float f = (float)j / 20.0F;

            f = (f * f + f * 2.0F) / 3.0F;

 

            if ((double)f < 0.1D)

            {

                return;

            }

 

            if (f > 1.0F)

            {

                f = 1.0F;

            }

 

            EntityRuneArrow entityarrow = new EntityRuneArrow(par2World, par3EntityPlayer, f * 2.0F).setShooter(par3EntityPlayer);

            //EntityRuneArrow entityarrow = new EntityRuneArrow(par2World, par3EntityPlayer, f * 2.0F);

 

            if (f == 1.0F)

            {

                entityarrow.setIsCritical(true);

            }

 

            int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

 

            if (k > 0)

            {

                entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);

            }

 

            int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

 

            if (l > 0)

            {

                entityarrow.setKnockbackStrength(l);

            }

 

            if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)

            {

                entityarrow.setFire(100);

            }

 

            par1ItemStack.damageItem(1, par3EntityPlayer);

            par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

 

            if (flag)

            {

                entityarrow.canBePickedUp = 2;

            }

            else

            {

                par3EntityPlayer.inventory.consumeInventoryItem(Main.RuneWoodArrow.itemID);

            }

 

            if (!par2World.isRemote)

            {

                par2World.spawnEntityInWorld(entityarrow);

               

            }

        }

    }

 

public ItemStack onEaten(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)

    {

        return par1ItemStack;

    }

 

    /**

    * How long it takes to use or consume an item

    */

    public int getMaxItemUseDuration(ItemStack par1ItemStack)

    {

        return 72000;

    }

 

    /**

    * returns the action that specifies what animation to play when the items is being used

    */

    public EnumAction getItemUseAction(ItemStack par1ItemStack)

    {

        return EnumAction.bow;

    }

 

    /**

    * Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer

    */

    public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)

    {

        ArrowNockEvent event = new ArrowNockEvent(par3EntityPlayer, par1ItemStack);

        MinecraftForge.EVENT_BUS.post(event);

 

        if (event.isCanceled())

        {

            return event.result;

        }

 

        if (par3EntityPlayer.capabilities.isCreativeMode || par3EntityPlayer.inventory.hasItem(Main.RuneWoodArrow.itemID))

        {

            par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));

        }

 

        return par1ItemStack;

    }

 

    /**

    * Return the enchantability factor of the item, most of the time is based on material.

    */

    public int getItemEnchantability()

    {

        return 1;

    }

 

@SideOnly(Side.CLIENT)

 

public void registerIcons(IconRegister iconRegister)

 

{

itemIcon = iconRegister.registerIcon(Main.modid + ":" + (this.getUnlocalizedName().substring(5) + "_0"));

        for (int N = 0; N < 4; N++)

                  {

      this.Texture[N] = iconRegister.registerIcon(Main.modid + ":" + (this.getUnlocalizedName().substring(5) + "_" + N));

                  }

}

public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)

{

                        if(player.getItemInUse() == null) return this.itemIcon;

                        int Pulling = stack.getMaxItemUseDuration() - useRemaining;

                        if (Pulling >= 18)

                        {

                                        return Texture[3];

                        }

                        else if (Pulling > 13)

                        {

                                        return Texture[2];

                        }

                        else if (Pulling > 0)

                        {

                                        return Texture[1];

                        }

                        return Texture[0];

                        }

}

 

Posted

If that's still not working the only thing I can see that is different is I save the shooter's name to NBT:

// save
compound.setString("shooter", getShooter() instanceof EntityPlayer ? ((EntityPlayer) getShooter()).username : "");
// load
dataWatcher.updateObject(SHOOTER_DATAWATCHER_INDEX, compound.hasKey("shooter") ? compound.getString("shooter") : "");

  • 2 months later...
Posted

Hello i was just wondering if there is an update for this fix for 1.7.2?

I tried using your fix and replaced  player.username with player.getDisplayName() but it gave me a nullPointExeption when i tryed to spawn the arrow.

 

I found that removing super.onUpdate() from onUpdate() partially fixed the problem (the arrow no longer hits the player) but the arrow still hits the player client side which doesn't affect the player but it looks bad any idea how i can fix this?

 

 

I am the author of Draconic Evolution

Posted

Hello i was just wondering if there is an update for this fix for 1.7.2?

I tried using your fix and replaced  player.username with player.getDisplayName() but it gave me a nullPointExeption when i tryed to spawn the arrow.

 

I found that removing super.onUpdate() from onUpdate() partially fixed the problem (the arrow no longer hits the player) but the arrow still hits the player client side which doesn't affect the player but it looks bad any idea how i can fix this?

1. Always start your own topic, especially if the one you reply to is old like this one.

2. I would only remove the super.onUpdate() if you really know what you are doing

3. Use 'player.getCommandSenderName()'

4. Start your own topic if you still need help

Posted

Thankyou!!! i have been trying to figure this out for hours.

 

To be honest i dont really know what im doing with some of this im still very new to java and modding but i am learning.

And in the future i will start my own topic. 

 

Edit: Hmm... i thought it was working... maby i forgot to switch to servival... well guess its time to start a new thread... after i do some more troubleshooting.

 

I am the author of Draconic Evolution

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.