Jump to content

Recommended Posts

Posted

Hey, I'm back with another problem,

 

At first, thanks to everyone who was helping me in my previous question about how to come along with the "new" event system. However, I discovered another hurdle on my way to a new release. I set up a LivingHurtEvent and want to find out the distance between the player and the dead hurt entity, but for some reason Forge won't let me know if there's been an entity murdered hurted. Here the most important code snippets:

 

Main Mod Class:

 

	@EventHandler
public void onInit(FMLInitializationEvent event) {
	ForgeUtils.getForgeEventBus().register(new SkillCombatListener()); // registered at MinecraftForge.EVENT_BUS
}

 

Death Handler:

 

	@SubscribeEvent
public void onLivingHurt(LivingHurtEvent event) {
	if (event.entity instanceof EntityLiving && !(event.entity instanceof EntityPlayer)) {
		System.out.println(event.entity.getDistanceToEntity(ForgeUtils.getPlayer()) + " " + event.source.damageType);
	}
}

 

I've tried to find typos in the code with some basic console logging but Forge doesn't even seem to call the LivingHurtEvent. Though LivingHurtEvent extends LivingEvent it doesn't seem to do anything. Am I just missing something or is this a bug?

 

Greets from Germany

~sep87x

Posted

Hello sep87x,

 

You are using the wrong event. To see al entityLiving events, go to the package called net.minecraftforge.event.entity.living.

To check if an entity has been murdered, you should use the LivingDeathEvent event. The LivingHurtEvent event only fires when an entity

is hurt, not killed. Also, make sure that the event only runs on the server side using;

if(event.entityPlayer.worldObj.isRemote) return;

 

Hope this helps you!

 

Follow me on twitter: https://twitter.com/CoderAce_

Posted

You are using the wrong event.

 

Oh, that's my fault. I misspelt something in my post. Of course I want the hurt event, not the kill event.

Posted

Also, you should note that the if-statement contains unnecessery code.

 

	@SubscribeEvent
public void onLivingHurt(LivingHurtEvent event) {
	System.out.println("FEHFOUHUOjhgriwgwrg");
	if (!(event.entity instanceof EntityPlayer)) {
		System.out.println(event.entity.getDistanceToEntity(ForgeUtils.getPlayer()) + " " + event.source.damageType);
	}
}

 

I already expected that, but I was too lazy to change this. However, this wouldn't change anything in how the handler works. As I said in my first post, I've already tried some standard logging (like above) but it doesn't even send the output to the console. It should work and that's my main problem here.

Posted

I register my events using this code; MinecraftForge.EVENT_BUS.register(new ItemPickupHandler());

Maybe try that? It seems like it goes wrong at the registring part.

 

ForgeUtils.getForgeEventBus().register(new SkillCombatListener());

 

is basically just an alias for

 

MinecraftForge.EVENT_BUS.register(new SkillCombatListener());

 

I wrote the ForgeUtils class for me so it's easier for me to get into the new 1.7.2 system. In the first place I wrote the class to distinguish the Forge event bus from the FML event bus because they're two things on their own ... soooo the typo can't be at this place.

 

Edit: I might just take a nap and make a new attempt tomorrow. I'll let you guys know whether your advice was helping me out or not.

Posted

Well, for some reason and I can't explain why, the event handling worked as I restarted and reopened my IDE for the third time in total. Hope it'll stay working as good as it does now.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
    • That's just plain wrong... newer versions are much better optimised and start a lot faster than 1.8.9, both Forge and Minecraft itself. Comparing Fabric 1.21 with Forge 1.8 is like comparing apples and oranges... one's brand new and the other's over a decade old.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.