Jump to content

Recommended Posts

Posted

Hello and thanks for reading.

 

I'm trying to store nbtdata to see if a player has researched a item.

I'm now storing the nbtdata to an itemstack but that means everytime I get a new itemstack the player would have to research it again.

 

How would I set researched to "true" for every type of that item?

 

Thanks for your help!

 

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Yeah I have seen something like storing the data per player using that

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

After a bit of fiddling around with nbt I noticed that you can't store a string array? are there any equivalent methods for this? setbytearray?

 

Or should i set everything in a large string? like: "grass,dirt,air"

I think that would be kinda slow because I'll have to iterate through the string if I want to check for a block. Because if I wouldn't split the string it could return true if it'll look for grass and I only have Grass Block for example

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Performance should not be a problem. A comma-separated array should work just fine.

You could also have an NBT tag compound with the recipe name as the key, only storing simple booleans. To determine if something is unlocked, you would have to check if the NBT tag compound contains the key instead.

Posted

Ah well for anyone interrested heres my sourcecode:

 

playerclass:

package molecularscience.api;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

public class ExtendedPlayer implements IExtendedEntityProperties
{

public final static String EXT_PROP_NAME = "ExtendedPlayer";

private final EntityPlayer player;

private static String researches;

public ExtendedPlayer(EntityPlayer player){
	this.player = player;
}

public static final void register(EntityPlayer player){
	player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player){
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}


@Override
public void saveNBTData(NBTTagCompound compound){	
	NBTTagCompound properties = new NBTTagCompound();
	properties.setString("researched", this.researches);
	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound){
	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);
	this.researches = properties.getString("researched");
}

@Override
public void init(Entity entity, World world){}

public static void Research(String item)
{
	item = item + ",";
	researches = researches + item;
}

public static boolean IsResearched(String item){
	if(researches != null){
		String[] researched = researches.split(",");
		for(String p: researched){
			if(p.equals(item)){
				return true;
			}
		}
	}
	return false;
}
}

 

itemclass

package molecularscience.moditems;

import java.util.List;

import org.apache.commons.lang3.StringUtils;

import molecularscience.Config;
import molecularscience.MolecularScience;
import molecularscience.api.ExtendedPlayer;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;


public class ItemSample extends Item {

    public ItemSample()
    {
        super();
        this.setHasSubtypes(true);
        this.setCreativeTab(MolecularScience.Molecules);
    }
    
public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4) {

	String Itemname = par1ItemStack.getDisplayName();
	Itemname = StringUtils.removeEnd(Itemname, " Sample");

	Object Itemmolecule = null;
	String moleculesinitem = null;

	if(Config.Blockmolecules.get(Itemname) != null){
		Itemmolecule = Config.Blockmolecules.get(Itemname);
		moleculesinitem = Itemmolecule.toString();
	}

	if(ExtendedPlayer.IsResearched(Itemname)){
		if(Config.Blockmolecules.get(Itemname) != null){
			par3List.add( "This Sample consists of: " + Itemmolecule );
			if(moleculesinitem.contains(",")){
				String[] splitmolecule = moleculesinitem.split(",");
				for( int i = 0; i <= splitmolecule.length - 1; i++){
					par3List.add(Config.Moleculesatoms.get(splitmolecule[i]));
				}
			}else{
				par3List.add(Config.Moleculesatoms.get(Itemmolecule));
			}
		}
	}else{
		par3List.add("You have not yet researched this sample");
	}
}
}

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Yeah, well it works.

Do you know any other methods I should use(I'm just fiddeling around here with java)?

should I use the NBTTagList?

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Ah okay thanks.

 

1 more question is metadata still viable? since minecraft doesn't have ids anymore.

It could still be usefull for registering 5 items that are nearly the same like logs.

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Posted

Dunno how it could not sometimes I find metadata annoying to use :P well thanks for your help!

I'm always happy to help others!

 

Java is not my main programming language but I have alot experience in PHP/HTML/JS/CSS3/C#/SQL

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
    • That's just plain wrong... newer versions are much better optimised and start a lot faster than 1.8.9, both Forge and Minecraft itself. Comparing Fabric 1.21 with Forge 1.8 is like comparing apples and oranges... one's brand new and the other's over a decade old.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.