[1.7.2] - Sending data from a gui to the server [Solved]

AppliedOnce · March 17, 2014

Hi, I'm currently working on a project and got into a small problem. I try to change a value that is saved in the player using the ExtendedEntityProperties stuff, inside a gui. The only I am having is that the way I am doing it, I only change the values on the client side which makes a lot of problems. So I was wondering how I can fix this problem, is there something missing in my packet or something or do I need a new one?

Here is all the classes I am using for it:

Mod class:

package com.xetosphere.pantheon.entity;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

import com.xetosphere.pantheon.PantheonCraft;
import com.xetosphere.pantheon.lib.Reference;
import com.xetosphere.pantheon.network.packet.SyncPlayerPropsPacket;
import com.xetosphere.pantheon.proxy.CommonProxy;

public class ExtendedPlayer implements IExtendedEntityProperties {

public static final String IDENTIFIER = Reference.MOD_ID + "_properties";

private final EntityPlayer player;

private int culture, maxCulture, pantheonId;

private String pantheon;

public static final int CULTURE_WATCHER = 25;
public static final int PANTHEON_WATCHER = 26;
public static final int ID_WATCHER = 27;

public ExtendedPlayer(EntityPlayer player) {

	this.player = player;
	culture = 0;
	maxCulture = 1000;
	pantheon = "None";
	pantheonId = 1;
	player.getDataWatcher().addObject(CULTURE_WATCHER, culture);
	player.getDataWatcher().addObject(PANTHEON_WATCHER, pantheon);
	player.getDataWatcher().addObject(ID_WATCHER, pantheonId);
}

public static final void register(EntityPlayer player) {

	player.registerExtendedProperties(IDENTIFIER, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player) {

	return (ExtendedPlayer) player.getExtendedProperties(IDENTIFIER);
}

@Override
public void saveNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = new NBTTagCompound();
	properties.setInteger("Culture", player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER));
	properties.setInteger("MaxCulture", maxCulture);
	properties.setString("Pantheon", player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER));
	properties.setInteger("IdPantheon", player.getDataWatcher().getWatchableObjectInt(ID_WATCHER));
	compound.setTag(IDENTIFIER, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = (NBTTagCompound) compound.getTag(IDENTIFIER);
	player.getDataWatcher().updateObject(CULTURE_WATCHER, properties.getInteger("Culture"));
	maxCulture = properties.getInteger("MaxCulture");
	player.getDataWatcher().updateObject(PANTHEON_WATCHER, properties.getString("Pantheon"));
	player.getDataWatcher().updateObject(ID_WATCHER, properties.getInteger("IdPantheon"));
	System.out.println("[XETOPC PROPS] Culture from NBT: " + player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER) + "/" + maxCulture);
	System.out.println("[XETOPC PROPS] Pantheon from NBT: [iD = " + player.getDataWatcher().getWatchableObjectInt(ID_WATCHER) + "] " + player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER));
}

@Override
public void init(Entity entity, World world) {
}

public final boolean consumeCulture(int amount) {
	boolean sufficient = amount <= getCulture();
	setCulture(getCulture() - amount);
	return sufficient;
}

public final int getCulture() {

	return player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER);
}

public final String getPantheon() {

	return player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER);
}

public final int getPantheonId() {

	return player.getDataWatcher().getWatchableObjectInt(ID_WATCHER);
}

public final void setCulture(int amount) {

	player.getDataWatcher().updateObject(CULTURE_WATCHER, amount > 0 ? (amount < maxCulture ? amount : maxCulture) : 0);
}

public final void setPantheon(String pantheon) {

	player.getDataWatcher().updateObject(PANTHEON_WATCHER, pantheon);
}

public final void setPantheonId(int id) {

	player.getDataWatcher().updateObject(ID_WATCHER, id);
}

public final int getMaxCulture() {

	return maxCulture;
}

public final void setMaxCulture(int amount) {

	maxCulture = (amount > 0 ? amount : 0);
	PantheonCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

private static final String getSaveKey(EntityPlayer player) {

	return player.getCommandSenderName() + ":" + IDENTIFIER;
}

public static final void saveProxyData(EntityPlayer player) {

	NBTTagCompound savedData = new NBTTagCompound();
	ExtendedPlayer.get(player).saveNBTData(savedData);
	CommonProxy.storeEntityData(getSaveKey(player), savedData);
}

public static final void loadProxyData(EntityPlayer player) {

	ExtendedPlayer playerData = ExtendedPlayer.get(player);
	NBTTagCompound savedData = CommonProxy.getEntityData(getSaveKey(player));
	if (savedData != null) {
		playerData.loadNBTData(savedData);
	}

	PantheonCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

}

ItemTalisman class:

package com.xetosphere.pantheon.item;

import net.minecraft.entity.effect.EntityLightningBolt;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.MovingObjectPosition.MovingObjectType;
import net.minecraft.util.Vec3;
import net.minecraft.world.World;

import org.lwjgl.input.Keyboard;

import com.xetosphere.pantheon.PantheonCraft;
import com.xetosphere.pantheon.entity.ExtendedPlayer;
import com.xetosphere.pantheon.lib.GuiIds;

public class ItemTalisman extends ItemPC {

public ItemTalisman() {

}

public ItemTalisman(EntityPlayer player) {

}

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

	String pantheon = ExtendedPlayer.get(player).getPantheon();

	final double EYE_HEIGHT = 1.62;
	final double REACH_DISTANCE = 300;

	Vec3 startPos = player.getPosition(1.0F);

	if (!world.isRemote) startPos = startPos.addVector(0, EYE_HEIGHT, 0);

	Vec3 look = player.getLook(1.0F);
	Vec3 endPos = startPos.addVector(look.xCoord * REACH_DISTANCE, look.yCoord * REACH_DISTANCE, look.zCoord * REACH_DISTANCE);

	MovingObjectPosition objectMouseOver = world.rayTraceBlocks(startPos, endPos);

	if (Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)) {

		if (world.isRemote) {

			player.openGui(PantheonCraft.instance, GuiIds.RELIGION_GUI, world, (int) player.posX, (int) player.posY, (int) player.posZ);
		}

	}

	// TODO Greek
	if (pantheon.equals("Greek") && !Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)) {

		if (ExtendedPlayer.get(player).getCulture() >= 100 && objectMouseOver != null && objectMouseOver.typeOfHit == MovingObjectType.BLOCK) {

			ExtendedPlayer.get(player).consumeCulture(100);

			int i = objectMouseOver.blockX;
			int j = objectMouseOver.blockY;
			int k = objectMouseOver.blockZ;

			player.addChatComponentMessage(new ChatComponentText("This is ran. Greek"));

			world.spawnEntityInWorld(new EntityLightningBolt(world, i, j, k));

		} else {

			if (!world.isRemote) {

				player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
				ExtendedPlayer.get(player).setCulture(100);
			}
		}
	}

	// TODO Norse
	if (pantheon.equals("Norse") && !Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)) {

		if (ExtendedPlayer.get(player).getCulture() >= 100) {

			ExtendedPlayer.get(player).consumeCulture(100);
			player.addPotionEffect(new PotionEffect(Potion.moveSpeed.id, 2400, 0, false));
			player.addChatComponentMessage(new ChatComponentText("This is ran. Norse"));

		} else {

			if (!world.isRemote) {

				player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
				ExtendedPlayer.get(player).setCulture(100);
			}
		}
	}

	// TODO Roman
	if (pantheon.equals("Roman") && !Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)) {

		if (ExtendedPlayer.get(player).getCulture() >= 100 && objectMouseOver != null && objectMouseOver.typeOfHit == MovingObjectType.BLOCK) {
			ExtendedPlayer.get(player).consumeCulture(100);

			int i = objectMouseOver.blockX;
			int j = objectMouseOver.blockY;
			int k = objectMouseOver.blockZ;
			player.addChatComponentMessage(new ChatComponentText("This is ran. Roman"));

			if (!world.isRemote) world.createExplosion(player, i, j, k, 5, true);

		} else {

			if (!world.isRemote) {

				player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
				ExtendedPlayer.get(player).setCulture(100);
			}
		}
	}

	// TODO Egyptian
	if (pantheon.equals("Egyptian") && !Keyboard.isKeyDown(Keyboard.KEY_LSHIFT)) {

		if (ExtendedPlayer.get(player).getCulture() >= 100) {

			ExtendedPlayer.get(player).consumeCulture(100);
			player.addPotionEffect(new PotionEffect(Potion.nightVision.id, 2400, 0, false));
			player.addChatComponentMessage(new ChatComponentText("This is ran. Egyptian"));

		} else {

			if (!world.isRemote) {

				player.addChatComponentMessage(new ChatComponentText("You don't have enough culture."));
				ExtendedPlayer.get(player).setCulture(100);
			}
		}
	}

	return itemStack;
}
}

GuiReligion class:

package com.xetosphere.pantheon.client.gui;

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ChatComponentText;

import org.lwjgl.opengl.GL11;

import com.xetosphere.pantheon.entity.ExtendedPlayer;
import com.xetosphere.pantheon.lib.Textures;

public class GuiReligion extends GuiScreen {

private int xSize = 176;

private int ySize = 166;

EntityPlayer player;

private String[] pantheons = { "None", "Greek", "Norse", "Roman", "Egyptian" };

public GuiReligion(EntityPlayer player) {

	this.player = player;
}

public void updateScreen() {
	super.updateScreen();
}

public void drawScreen(int x, int y, float f) {

	drawDefaultBackground();

	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);

	mc.getTextureManager().bindTexture(Textures.GUI_RELIGION);

	int posX = (width - xSize) / 2;
	int posY = (height - ySize) / 2;

	drawTexturedModalRect(posX, posY, 0, 0, xSize, ySize);
	drawCenteredString(fontRendererObj, ExtendedPlayer.get(player).getPantheon(), posX + (xSize / 4 * 3), posY + 15, 0xffffffff);

	super.drawScreen(x, y, f);
}

public boolean doesGuiPauseGame() {

	return false;
}

@SuppressWarnings("unchecked")
public void initGui() {

	this.buttonList.clear();

	int posX = (width - xSize) / 2;
	int posY = (height - ySize) / 2;

	this.buttonList.add(new GuiButton(0, posX + 10, posY + 10, 50, 20, pantheons[0]));
	this.buttonList.add(new GuiButton(1, posX + 10, posY + 40, 50, 20, pantheons[1]));
	this.buttonList.add(new GuiButton(2, posX + 10, posY + 70, 50, 20, pantheons[2]));
	this.buttonList.add(new GuiButton(3, posX + 10, posY + 100, 50, 20, pantheons[3]));
	this.buttonList.add(new GuiButton(4, posX + 10, posY + 130, 50, 20, pantheons[4]));
}

public void actionPerformed(GuiButton button) {

	switch (button.id) {
		case 0:
			ExtendedPlayer.get(player).setPantheon(pantheons[0]);
			ExtendedPlayer.get(player).setPantheonId(0);
			System.out.println("[XETOPC] Pantheon = " + ExtendedPlayer.get(player).getPantheon());
			System.out.println("[XETOPC] PantheonId = " + ExtendedPlayer.get(player).getPantheonId());
			player.addChatComponentMessage(new ChatComponentText("You set your pantheon to: " + ExtendedPlayer.get(player).getPantheon()));
			break;
		case 1:
			ExtendedPlayer.get(player).setPantheon(pantheons[1]);
			ExtendedPlayer.get(player).setPantheonId(1);
			System.out.println("[XETOPC] Pantheon = " + ExtendedPlayer.get(player).getPantheon());
			System.out.println("[XETOPC] PantheonId = " + ExtendedPlayer.get(player).getPantheonId());
			player.addChatComponentMessage(new ChatComponentText("You set your pantheon to: " + ExtendedPlayer.get(player).getPantheon()));
			break;
		case 2:
			ExtendedPlayer.get(player).setPantheon(pantheons[2]);
			ExtendedPlayer.get(player).setPantheonId(2);
			System.out.println("[XETOPC] Pantheon = " + ExtendedPlayer.get(player).getPantheon());
			System.out.println("[XETOPC] PantheonId = " + ExtendedPlayer.get(player).getPantheonId());
			player.addChatComponentMessage(new ChatComponentText("You set your pantheon to: " + ExtendedPlayer.get(player).getPantheon()));
			break;
		case 3:
			ExtendedPlayer.get(player).setPantheon(pantheons[3]);
			ExtendedPlayer.get(player).setPantheonId(3);
			System.out.println("[XETOPC] Pantheon = " + ExtendedPlayer.get(player).getPantheon());
			System.out.println("[XETOPC] PantheonId = " + ExtendedPlayer.get(player).getPantheonId());
			player.addChatComponentMessage(new ChatComponentText("You set your pantheon to: " + ExtendedPlayer.get(player).getPantheon()));
			break;
		case 4:
			ExtendedPlayer.get(player).setPantheon(pantheons[4]);
			ExtendedPlayer.get(player).setPantheonId(4);
			System.out.println("[XETOPC] Pantheon = " + ExtendedPlayer.get(player).getPantheon());
			System.out.println("[XETOPC] PantheonId = " + ExtendedPlayer.get(player).getPantheonId());
			player.addChatComponentMessage(new ChatComponentText("You set your pantheon to: " + ExtendedPlayer.get(player).getPantheon()));
			break;
	}
}
}

PacketPipeline class:

package com.xetosphere.pantheon.network;

import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelHandler;
import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.MessageToMessageCodec;

import java.util.Collections;
import java.util.Comparator;
import java.util.EnumMap;
import java.util.LinkedList;
import java.util.List;

import com.xetosphere.pantheon.lib.Reference;
import com.xetosphere.pantheon.network.packet.SyncPlayerPropsPacket;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.network.INetHandler;
import net.minecraft.network.NetHandlerPlayServer;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.network.FMLEmbeddedChannel;
import cpw.mods.fml.common.network.FMLOutboundHandler;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.network.internal.FMLProxyPacket;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

@ChannelHandler.Sharable
public class PacketPipeline extends MessageToMessageCodec<FMLProxyPacket, AbstractPacket> {

private EnumMap<Side, FMLEmbeddedChannel> channels;
private LinkedList<Class<? extends AbstractPacket>> packets = new LinkedList<Class<? extends AbstractPacket>>();
private boolean isPostInitialised = false;

public boolean registerPacket(Class<? extends AbstractPacket> clazz) {

	if (this.packets.size() > 256) {

		return false;
	}

	if (this.packets.contains(clazz)) {

		return false;
	}

	if (this.isPostInitialised) {

		return false;
	}

	this.packets.add(clazz);
	return true;
}

protected void encode(ChannelHandlerContext ctx, AbstractPacket msg, List<Object> out) throws Exception {

	ByteBuf buffer = Unpooled.buffer();
	Class<? extends AbstractPacket> clazz = msg.getClass();

	if (!this.packets.contains(msg.getClass())) {

		throw new NullPointerException("No Packet Registered for: " + msg.getClass().getCanonicalName());
	}

	byte discriminator = (byte) this.packets.indexOf(clazz);
	buffer.writeByte(discriminator);
	msg.encodeInto(ctx, buffer);
	FMLProxyPacket proxyPacket = new FMLProxyPacket(buffer.copy(), ctx.channel().attr(NetworkRegistry.FML_CHANNEL).get());
	out.add(proxyPacket);
}

@Override
protected void decode(ChannelHandlerContext ctx, FMLProxyPacket msg, List<Object> out) throws Exception {

	ByteBuf payload = msg.payload();
	byte discriminator = payload.readByte();
	Class<? extends AbstractPacket> clazz = this.packets.get(discriminator);

	if (clazz == null) {

		throw new NullPointerException("No packet registered for discriminator: " + discriminator);
	}

	AbstractPacket pkt = clazz.newInstance();
	pkt.decodeInto(ctx, payload.slice());

	EntityPlayer player;
	switch (FMLCommonHandler.instance().getEffectiveSide()) {
		case CLIENT:
			player = this.getClientPlayer();
			pkt.handleClientSide(player);
			break;

		case SERVER:
			INetHandler netHandler = ctx.channel().attr(NetworkRegistry.NET_HANDLER).get();
			player = ((NetHandlerPlayServer) netHandler).playerEntity;
			pkt.handleServerSide(player);
			break;

		default:
	}

	out.add(pkt);
}

public void initialise() {

	this.channels = NetworkRegistry.INSTANCE.newChannel(Reference.MOD_ID, this);
	registerPackets();
}

public void registerPackets() {

	registerPacket(SyncPlayerPropsPacket.class);
}

public void postInitialise() {

	if (this.isPostInitialised) {

		return;
	}

	this.isPostInitialised = true;
	Collections.sort(this.packets, new Comparator<Class<? extends AbstractPacket>>() {

		@Override
		public int compare(Class<? extends AbstractPacket> clazz1, Class<? extends AbstractPacket> clazz2) {

			int com = String.CASE_INSENSITIVE_ORDER.compare(clazz1.getCanonicalName(), clazz2.getCanonicalName());

			if (com == 0) {

				com = clazz1.getCanonicalName().compareTo(clazz2.getCanonicalName());
			}

			return com;
		}
	});
}

@SideOnly(Side.CLIENT)
private EntityPlayer getClientPlayer() {

	return Minecraft.getMinecraft().thePlayer;
}

public void sendToAll(AbstractPacket message) {

	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGET).set(FMLOutboundHandler.OutboundTarget.ALL);
	this.channels.get(Side.SERVER).writeAndFlush(message);
}

public void sendTo(AbstractPacket message, EntityPlayerMP player) {

	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGET).set(FMLOutboundHandler.OutboundTarget.PLAYER);
	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGETARGS).set(player);
	this.channels.get(Side.SERVER).writeAndFlush(message);
}

public void sendToAllAround(AbstractPacket message, NetworkRegistry.TargetPoint point) {

	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGET).set(FMLOutboundHandler.OutboundTarget.ALLAROUNDPOINT);
	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGETARGS).set(point);
	this.channels.get(Side.SERVER).writeAndFlush(message);
}

public void sendToDimension(AbstractPacket message, int dimensionId) {

	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGET).set(FMLOutboundHandler.OutboundTarget.DIMENSION);
	this.channels.get(Side.SERVER).attr(FMLOutboundHandler.FML_MESSAGETARGETARGS).set(dimensionId);
	this.channels.get(Side.SERVER).writeAndFlush(message);
}

public void sendToServer(AbstractPacket message) {

	this.channels.get(Side.CLIENT).attr(FMLOutboundHandler.FML_MESSAGETARGET).set(FMLOutboundHandler.OutboundTarget.TOSERVER);
	this.channels.get(Side.CLIENT).writeAndFlush(message);
}
}

SyncPlayerPropsPacket class:

package com.xetosphere.pantheon.network.packet;

import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;

import com.xetosphere.pantheon.entity.ExtendedPlayer;
import com.xetosphere.pantheon.network.AbstractPacket;

import cpw.mods.fml.common.network.ByteBufUtils;

public class SyncPlayerPropsPacket extends AbstractPacket {

private NBTTagCompound data;

public SyncPlayerPropsPacket() {
}

public SyncPlayerPropsPacket(EntityPlayer player) {

	data = new NBTTagCompound();
	ExtendedPlayer.get(player).saveNBTData(data);
}

@Override
public void encodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {

	ByteBufUtils.writeTag(buffer, data);
}

@Override
public void decodeInto(ChannelHandlerContext ctx, ByteBuf buffer) {

	data = ByteBufUtils.readTag(buffer);
}

@Override
public void handleClientSide(EntityPlayer player) {

	ExtendedPlayer.get(player).loadNBTData(data);
}

@Override
public void handleServerSide(EntityPlayer player) {
}
}

CultureEventHandler class:

package com.xetosphere.pantheon.event;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.entity.EntityEvent.EntityConstructing;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.event.entity.living.LivingDeathEvent;

import com.xetosphere.pantheon.entity.ExtendedPlayer;

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

public class CultureEventHandler {

@SubscribeEvent
public void onEntityConstructing(EntityConstructing event) {

	if (event.entity instanceof EntityPlayer) {

		if (ExtendedPlayer.get((EntityPlayer) event.entity) == null)

		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}

@SubscribeEvent
public void onEntityJoinWorld(EntityJoinWorldEvent event) {

	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer) {

		ExtendedPlayer.loadProxyData((EntityPlayer) event.entity);
	}
}

@SubscribeEvent
public void onLivingDeathEvent(LivingDeathEvent event) {

	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer) {

		ExtendedPlayer.saveProxyData((EntityPlayer) event.entity);
	}
}
}

CommonProxy class:

package com.xetosphere.pantheon.proxy;

import java.util.HashMap;
import java.util.Map;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;

import com.xetosphere.pantheon.client.gui.GuiReligion;
import com.xetosphere.pantheon.lib.GuiIds;

import cpw.mods.fml.common.network.IGuiHandler;

public class CommonProxy implements IGuiHandler {

private static final Map<String, NBTTagCompound> extendedEntityData = new HashMap<String, NBTTagCompound>();

public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z) {

	if (id == GuiIds.RELIGION_GUI) {

		return null;
	}

	return null;
}

public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z) {

	if (id == GuiIds.RELIGION_GUI) {

		return new GuiReligion(player);
	}

	return null;
}

public static void storeEntityData(String name, NBTTagCompound compound) {

	extendedEntityData.put(name, compound);
}

public static NBTTagCompound getEntityData(String name) {

	return extendedEntityData.remove(name);
}
}

ExtendedPlayer class:

package com.xetosphere.pantheon.entity;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

import com.xetosphere.pantheon.PantheonCraft;
import com.xetosphere.pantheon.lib.Reference;
import com.xetosphere.pantheon.network.packet.SyncPlayerPropsPacket;
import com.xetosphere.pantheon.proxy.CommonProxy;

public class ExtendedPlayer implements IExtendedEntityProperties {

public static final String IDENTIFIER = Reference.MOD_ID + "_properties";

private final EntityPlayer player;

private int culture, maxCulture, pantheonId;

private String pantheon;

public static final int CULTURE_WATCHER = 25;
public static final int PANTHEON_WATCHER = 26;
public static final int ID_WATCHER = 27;

public ExtendedPlayer(EntityPlayer player) {

	this.player = player;
	culture = 0;
	maxCulture = 1000;
	pantheon = "None";
	pantheonId = 1;
	player.getDataWatcher().addObject(CULTURE_WATCHER, culture);
	player.getDataWatcher().addObject(PANTHEON_WATCHER, pantheon);
	player.getDataWatcher().addObject(ID_WATCHER, pantheonId);
}

public static final void register(EntityPlayer player) {

	player.registerExtendedProperties(IDENTIFIER, new ExtendedPlayer(player));
}

public static final ExtendedPlayer get(EntityPlayer player) {

	return (ExtendedPlayer) player.getExtendedProperties(IDENTIFIER);
}

@Override
public void saveNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = new NBTTagCompound();
	properties.setInteger("Culture", player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER));
	properties.setInteger("MaxCulture", maxCulture);
	properties.setString("Pantheon", player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER));
	properties.setInteger("IdPantheon", player.getDataWatcher().getWatchableObjectInt(ID_WATCHER));
	compound.setTag(IDENTIFIER, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = (NBTTagCompound) compound.getTag(IDENTIFIER);
	player.getDataWatcher().updateObject(CULTURE_WATCHER, properties.getInteger("Culture"));
	maxCulture = properties.getInteger("MaxCulture");
	player.getDataWatcher().updateObject(PANTHEON_WATCHER, properties.getString("Pantheon"));
	player.getDataWatcher().updateObject(ID_WATCHER, properties.getInteger("IdPantheon"));
	System.out.println("[XETOPC PROPS] Culture from NBT: " + player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER) + "/" + maxCulture);
	System.out.println("[XETOPC PROPS] Pantheon from NBT: [iD = " + player.getDataWatcher().getWatchableObjectInt(ID_WATCHER) + "] " + player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER));
}

@Override
public void init(Entity entity, World world) {
}

public final boolean consumeCulture(int amount) {
	boolean sufficient = amount <= getCulture();
	setCulture(getCulture() - amount);
	return sufficient;
}

public final int getCulture() {

	return player.getDataWatcher().getWatchableObjectInt(CULTURE_WATCHER);
}

public final String getPantheon() {

	return player.getDataWatcher().getWatchableObjectString(PANTHEON_WATCHER);
}

public final int getPantheonId() {

	return player.getDataWatcher().getWatchableObjectInt(ID_WATCHER);
}

public final void setCulture(int amount) {

	player.getDataWatcher().updateObject(CULTURE_WATCHER, amount > 0 ? (amount < maxCulture ? amount : maxCulture) : 0);
}

public final void setPantheon(String pantheon) {

	player.getDataWatcher().updateObject(PANTHEON_WATCHER, pantheon);
}

public final void setPantheonId(int id) {

	player.getDataWatcher().updateObject(ID_WATCHER, id);
}

public final int getMaxCulture() {

	return maxCulture;
}

public final void setMaxCulture(int amount) {

	maxCulture = (amount > 0 ? amount : 0);
	PantheonCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

private static final String getSaveKey(EntityPlayer player) {

	return player.getCommandSenderName() + ":" + IDENTIFIER;
}

public static final void saveProxyData(EntityPlayer player) {

	NBTTagCompound savedData = new NBTTagCompound();
	ExtendedPlayer.get(player).saveNBTData(savedData);
	CommonProxy.storeEntityData(getSaveKey(player), savedData);
}

public static final void loadProxyData(EntityPlayer player) {

	ExtendedPlayer playerData = ExtendedPlayer.get(player);
	NBTTagCompound savedData = CommonProxy.getEntityData(getSaveKey(player));
	if (savedData != null) {
		playerData.loadNBTData(savedData);
	}

	PantheonCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

}

AppliedOnce · March 17, 2014

Anyone knows what I am doing wrong here?

sequituri · March 18, 2014

First, you're not using extended properties properly. Second, this code will register your Entity data with a null player. Reverse to == to != and it should fix one problem.

public void onEntityConstructing(EntityConstructing event) {
	if (event.entity instanceof EntityPlayer) {
		if (ExtendedPlayer.get((EntityPlayer) event.entity) == null)
		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}

Advice, the init() method is called when entity is created to set the initial properties for the entity. Yours does nothing. (maybe not critical, as the defaults are 0... in the case of objects it another story).

loadNBTData() and saveNBTData() are called on entity spawn (player spawn in this case), and on entity despawn. This is where the data in the ExtendedEntity itself is loaded and saved.

DataWatcher is nice only to the extent that it lets you know if the data has changed and communicates it to the other side immediately. However, you need to keep a valid copy in the data fields of this object. (So, when the datawatcher changes, you grab the data and update).

Beyond that, I have not looked closely enough to give you an absolute fix. I'll keep looking, though.

AppliedOnce · March 18, 2014

First, you're not using extended properties properly. Second, this code will register your Entity data with a null player. Reverse to == to != and it should fix one problem.
public void onEntityConstructing(EntityConstructing event) {
	if (event.entity instanceof EntityPlayer) {
		if (ExtendedPlayer.get((EntityPlayer) event.entity) == null)
		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}
Advice, the init() method is called when entity is created to set the initial properties for the entity. Yours does nothing. (maybe not critical, as the defaults are 0... in the case of objects it another story).

loadNBTData() and saveNBTData() are called on entity spawn (player spawn in this case), and on entity despawn. This is where the data in the ExtendedEntity itself is loaded and saved.

DataWatcher is nice only to the extent that it lets you know if the data has changed and communicates it to the other side immediately. However, you need to keep a valid copy in the data fields of this object. (So, when the datawatcher changes, you grab the data and update).

Beyond that, I have not looked closely enough to give you an absolute fix. I'll keep looking, though.

No, I am pretty sure what that code does is, if the player haven't been registered yet then register it. Other than that thank you for replying and helping me out. (btw if I use != it just crashes when the player joins the world)

Chibill · March 18, 2014

Dude you have it as == the guy just said make it != and you say I can't make it == it crashes.

AppliedOnce · March 18, 2014

Dude you have it as == the guy just said make it != and you say I can't make it == it crashes.

No, what I meant to say is that when I have it as "!=" it crashes when I open the world. I get a nullpointer exception when using "!=".

Crashlog:

[13:29:11] [server thread/INFO]: Xetosphere joined the game

[13:29:11] [server thread/ERROR] [FML]: HandshakeCompletionHandler exception

java.lang.NullPointerException

at com.xetosphere.pantheon.network.packet.SyncPlayerPropsPacket.<init>(SyncPlayerPropsPacket.java:23) ~[syncPlayerPropsPacket.class:?]

at com.xetosphere.pantheon.entity.ExtendedPlayer.loadProxyData(ExtendedPlayer.java:146) ~[ExtendedPlayer.class:?]

at com.xetosphere.pantheon.event.CultureEventHandler.onEntityJoinWorld(CultureEventHandler.java:30) ~[CultureEventHandler.class:?]

at cpw.mods.fml.common.eventhandler.ASMEventHandler_4_CultureEventHandler_onEntityJoinWorld_EntityJoinWorldEvent.invoke(.dynamic) ~[?:?]

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51) ~[ASMEventHandler.class:?]

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122) ~[EventBus.class:?]

at net.minecraft.world.World.spawnEntityInWorld(World.java:1516) ~[World.class:?]

at net.minecraft.server.management.ServerConfigurationManager.playerLoggedIn(ServerConfigurationManager.java:288) ~[serverConfigurationManager.class:?]

at net.minecraft.server.management.ServerConfigurationManager.initializeConnectionToPlayer(ServerConfigurationManager.java:151) ~[serverConfigurationManager.class:?]

at cpw.mods.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:172) ~[NetworkDispatcher.class:?]

at cpw.mods.fml.common.network.handshake.NetworkDispatcher.completeHandshake(NetworkDispatcher.java:428) ~[NetworkDispatcher.class:?]

at cpw.mods.fml.common.network.internal.HandshakeCompletionHandler.channelRead0(HandshakeCompletionHandler.java:17) ~[HandshakeCompletionHandler.class:?]

at cpw.mods.fml.common.network.internal.HandshakeCompletionHandler.channelRead0(HandshakeCompletionHandler.java:11) ~[HandshakeCompletionHandler.class:?]

at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[simpleChannelInboundHandler.class:?]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]

at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:?]

at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) [MessageToMessageCodec.class:?]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]

at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:?]

at cpw.mods.fml.common.network.internal.FMLProxyPacket.processPacket(FMLProxyPacket.java:80) [FMLProxyPacket.class:?]

at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:242) [NetworkManager.class:?]

at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:190) [NetworkSystem.class:?]

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:763) [MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:651) [MinecraftServer.class:?]

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:120) [integratedServer.class:?]

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:530) [MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:788) [MinecraftServer$2.class:?]

[13:29:11] [server thread/ERROR] [FML]: There was a critical exception handling a packet on channel FML