Eating a stack in shapeless crafting

[meganmorgangames]

 

 

GameRegistry.addShapelessRecipe(new ItemStack(CustomItem.cannonFuse, 16), new Object[]{new ItemStack(Items.string, 16), new ItemStack(Items.gunpowder)});

 

 

 

Obviously didn't work.  I'm trying to get the recipe to each 16 strings and 1 gunpowder to return 16 fuses.  Is there an easy way to do this?

[GotoLink]

You mean consume more than 1 from each stack ?

You need to use ICraftingHandler (1.6.4) or ItemCraftedEvent (1.7.2).

[meganmorgangames]

Makes sense.  So I figured out how to create the event handler, and have it registered.  So that much is out of the way.

 

I have the listener in place

 

 

 

@SubscribeEvent
public void itemCrafted(ItemCraftedEvent evt){
	if (!evt.player.worldObj.isRemote){
		System.out.println("ItemCrafted Called");
		if(evt.crafting.getItem() == CustomItem.cannonFuse){
			for (int i = 0; i < 10; i++){
				if(evt.craftMatrix.getStackInSlot(i) != null){
					if (evt.craftMatrix.getStackInSlot(i).stackSize >= 16 && evt.craftMatrix.getStackInSlot(i).getItem() == Items.string){
						evt.craftMatrix.decrStackSize(i, 15);
					} else {
						//evt.setCanceled(true);
					}
				}
			}
		}
	}
}

 

 

 

First point of interest.  Is that the most efficient way to do that?  Is this going to cause conflict with things like NEI?

 

Second point of interest.  The stack is decreased, but it doesn't show on the crafting table.  The item amount is decreased when I return the strings to my inventory, however.  How should I refresh this?

 

Third point of interest.  The evt.setCanceled is commented out because it crashed the game.  How should I tell the listener not to craft the item?

 

Sorry for sounding so needy.  Usually I can find all the answers I need on Google, but sometime my Google-Fu is not strong.  Thanks for all the help

[sequituri]

First, that event is not cancellable. The item is crafted after the event returns.

Second, the onPickupFromSlot() method that fires that event also decrements the stacksize by 1 for every item in the craftMatrix, so you need to use 1 less.

Third, always call craftMatrix.getSizeInventory rather than using a hard coded number like 10 for your loop. You will sometimes get ArrayIndexOutOfBounds exception and crash otherwise.

Last, I don't see you using the ICrafting interface. Of course, that may be too hard, but it is the only way to alter the crafting matrix (especially from the server side.)

[meganmorgangames]

Progress continues, and thank you for your patience.

 

So, I figured out the best way to cancel it if the stacks aren't exactly right (item and size) was to create a class that implemented IRecipe, and it works like a charm.  I'm still using the ItemCraftedEvent (After fixing the loop...I feel like an idiot sometimes, I should have caught that, especially considering it is only a 2 slot recipe, meaning a crafting table isn't even nessicary) to decrease the stack size by the additional 15 (Also should have caught that).  Only thing left is getting the GUI to show the actual stack sizes and not what it thinks they should be :-/

 

 

@SubscribeEvent
public void itemCrafted(ItemCraftedEvent evt){
	if (!evt.player.worldObj.isRemote){
		//System.out.println("ItemCrafted Called");
		if(evt.crafting.getItem() == CustomItem.cannonFuse){
			for (int i = 0; i < evt.craftMatrix.getSizeInventory(); i++){
				if(evt.craftMatrix.getStackInSlot(i) != null){
					if (evt.craftMatrix.getStackInSlot(i).stackSize >= 15 && evt.craftMatrix.getStackInSlot(i).getItem() == Items.string){
						evt.craftMatrix.decrStackSize(i, 15);
					}
				}
			}
		}
	}
	this.sendContainerAndContentsToPlayer(evt.player.openContainer, evt.player.openContainer.inventoryItemStacks);
}

@Override
public void sendContainerAndContentsToPlayer(Container var1, List var2) {
	// TODO Auto-generated method stub
	var1.detectAndSendChanges();
}

 

 

This almost did the trick, it takes away 16 strings but now it is only showing that it took away 15 strings in the GUI.  Kind of the exact opposite problem from what I had before.  I'm certain that I'm calling detectAndSendChanges wrong, or at the wrong time, or in the wrong listener...I make things way more complicated than they need to be...lol

 

Anyway.  Thank you for being so very patient with me.  I'm gonna continue to try and hammer this out after I make breakfast for the family, but any advice you can offer is greatly appreciated.  Applauds and Thank You to both of you

 

[edit] Okay.  I'm completely lost now :-/

 

 

package com.mmg.cannon.recipes;

import net.minecraft.inventory.InventoryCrafting;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.IRecipe;
import net.minecraft.world.World;

public class CustomShapelessRecipe implements IRecipe {

public ItemStack result;
public ItemStack[] ingredients;

public CustomShapelessRecipe(ItemStack var1, ItemStack[] var2){
	this.result = var1;
	this.ingredients = var2;
}

@Override
public boolean matches(InventoryCrafting var1, World var2) {
	// TODO Auto-generated method stub
		int count = 0;
		for(int i = 0; i < var1.getSizeInventory(); i++)
		{
			ItemStack stack = var1.getStackInSlot(i);
			if(stack != null)
			{
				for(int j = 0; j < ingredients.length; j++){
					if (stack.getItem() == ingredients[j].getItem() && stack.stackSize >= ingredients[j].stackSize){
						count++;
					}
				}
			}
		}
		if (count == ingredients.length) System.out.println("Valid Recipe " + result);
		return count == ingredients.length;
}

@Override
public ItemStack getCraftingResult(InventoryCrafting var1) {
	// TODO Auto-generated method stub
	return result;
}

@Override
public int getRecipeSize() {
	// TODO Auto-generated method stub
	return 0;
}

@Override
public ItemStack getRecipeOutput() {
	// TODO Auto-generated method stub
	return null;
}

}

 

 

It works fine the first time I craft the fuses, but then for some reason the result stacksize is set to 0, and the fuses I just crafted stacksize is set to 0.  I'm not really sure what I've done wrong...Really starting to think trying to make fuses this way is a bad idea...lol